Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <810f3a69-0004-9dff-a911-b7ff97220ae0@linux.intel.com> <0652b8dd-e753-7c10-27e9-af9524e7ccc5@linux.intel.com>
In-Reply-To: <0652b8dd-e753-7c10-27e9-af9524e7ccc5@linux.intel.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Wed, 14 Oct 2020 19:52:01 +0900
Message-ID: <CAM9d7cgrXsiPWuAYjg1og0N=03-mfx075-n7KUrvYyAMLZ8_7A@mail.gmail.com>
Subject: Re: [PATCH v1 08/15] perf record: write trace data into mmap trace files
To:     Alexey Budankov <alexey.budankov@linux.intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Mon, Oct 12, 2020 at 6:01 PM Alexey Budankov
<alexey.budankov@linux.intel.com> wrote:
>
>
> Write trace data into per mmap trace files located
> at data directory. Streaming thread adjusts its affinity
> according to mask of the buffer being processed.
>
> Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
> ---
[SNIP]
> @@ -1184,8 +1203,12 @@ static int record__mmap_read_evlist(struct record *rec, struct evlist *evlist,
>         /*
>          * Mark the round finished in case we wrote
>          * at least one event.
> +        *
> +        * No need for round events in directory mode,
> +        * because per-cpu maps and files have data
> +        * sorted by kernel.
>          */
> -       if (bytes_written != rec->bytes_written)
> +       if (!record__threads_enabled(rec) && bytes_written != rec->bytes_written)
>                 rc = record__write(rec, NULL, &finished_round_event, sizeof(finished_round_event));

This means it needs to keep all events in the ordered events queue
when perf report processes the data, right?

Thanks
Namhyung