Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: jSoXj9Rmk5swizHfTOZdRbCNBcwDQTFH3Q1OqfYTB7wkQMaGVU5cK30OFbmqqZLr7IwT8a0APh
 gCT2PwKsDR2A==
IronPort-SDR: VHiQZi061gOdJ2cguYhr+PhjdOYUHuxbuF8Z+Wd7SboWu1nQa9UMqhWyo0dUwFUfvTlfVLmHpM
 0NILskVqq1DQ==
Subject: Re: [PATCH v1 08/15] perf record: write trace data into mmap trace
 files
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <810f3a69-0004-9dff-a911-b7ff97220ae0@linux.intel.com>
 <0652b8dd-e753-7c10-27e9-af9524e7ccc5@linux.intel.com>
 <CAM9d7cgrXsiPWuAYjg1og0N=03-mfx075-n7KUrvYyAMLZ8_7A@mail.gmail.com>
From:   Alexey Budankov <alexey.budankov@linux.intel.com>
Organization: Intel Corp.
Message-ID: <81ffefab-ac4e-c51c-809a-b9ba96d6d867@linux.intel.com>
Date:   Wed, 14 Oct 2020 15:09:00 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.1
MIME-Version: 1.0
In-Reply-To: <CAM9d7cgrXsiPWuAYjg1og0N=03-mfx075-n7KUrvYyAMLZ8_7A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 14.10.2020 13:52, Namhyung Kim wrote:
> Hi,
> 
> On Mon, Oct 12, 2020 at 6:01 PM Alexey Budankov
> <alexey.budankov@linux.intel.com> wrote:
>>
>>
>> Write trace data into per mmap trace files located
>> at data directory. Streaming thread adjusts its affinity
>> according to mask of the buffer being processed.
>>
>> Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
>> ---
> [SNIP]
>> @@ -1184,8 +1203,12 @@ static int record__mmap_read_evlist(struct record *rec, struct evlist *evlist,
>>         /*
>>          * Mark the round finished in case we wrote
>>          * at least one event.
>> +        *
>> +        * No need for round events in directory mode,
>> +        * because per-cpu maps and files have data
>> +        * sorted by kernel.
>>          */
>> -       if (bytes_written != rec->bytes_written)
>> +       if (!record__threads_enabled(rec) && bytes_written != rec->bytes_written)
>>                 rc = record__write(rec, NULL, &finished_round_event, sizeof(finished_round_event));
> 
> This means it needs to keep all events in the ordered events queue
> when perf report processes the data, right?

Looks so.

Alexei