Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 09/11] [DEBUG] firmware: arm_scmi: add example SCMI driver
 for custom protocol
To:     Cristian Marussi <cristian.marussi@arm.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc:     sudeep.holla@arm.com, lukasz.luba@arm.com,
        james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com,
        f.fainelli@gmail.com, etienne.carriere@linaro.org,
        thara.gopinath@linaro.org, vincent.guittot@linaro.org,
        souvik.chakravarty@arm.com
References: <20201014150545.44807-1-cristian.marussi@arm.com>
 <20201014150545.44807-10-cristian.marussi@arm.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <8f879e6b-8be2-1186-6620-f54762bd35e0@infradead.org>
Date:   Wed, 14 Oct 2020 08:55:08 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20201014150545.44807-10-cristian.marussi@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 10/14/20 8:05 AM, Cristian Marussi wrote:
> Add an example SCMI driver using custom vendor protocol 0x99 and also
> registering for Performance protocol notifications.
> 
> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> ---
>  drivers/firmware/Kconfig                      |   7 +
>  drivers/firmware/arm_scmi/Makefile            |   2 +
>  drivers/firmware/arm_scmi/scmi_custom_dummy.c | 126 ++++++++++++++++++
>  3 files changed, 135 insertions(+)
>  create mode 100644 drivers/firmware/arm_scmi/scmi_custom_dummy.c
> 
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index 75e2668a6490..d209df6fd3ee 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -48,6 +48,13 @@ config ARM_SCMI_POWER_DOMAIN
>  	  will be called scmi_pm_domain. Note this may needed early in boot
>  	  before rootfs may be available.
>  
> +config ARM_SCMI_CUSTOM_DUMMY
> +	tristate "SCMI Custom Dummy driver"
> +	depends on ARM_SCMI_PROTOCOL_CUSTOM || (COMPILE_TEST && OF)

Just an info note here: <linux/of.h> has lots of stubs for when CONFIG_OF is not
set/enabled, so COMPILE_TEST is usually enough of a dependency without adding "OF".

> +	default n
> +	help
> +	  Custom Dummy driver


-- 
~Randy