Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp673558pxu; Wed, 14 Oct 2020 10:41:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZepg7z2a37qUenQwDM8JGqBtAr9j3kILZbeecTFlxBtQNbFoqnWXdTDylGxwzwOG/v+cv X-Received: by 2002:a50:a693:: with SMTP id e19mr6629639edc.333.1602697307166; Wed, 14 Oct 2020 10:41:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602697307; cv=none; d=google.com; s=arc-20160816; b=u3GvI+rjTGqVb7ShYvsuaOYcyLjXU8E+C8Dem0di8jO6sQTobEM/+mEJDxl/mHdfNN +ExFdzyYvsO0Fn0YMxW/NsmKC8p7FEltBsuodecU+g1sbE3EBLMjoZxNYFdxk6fPLLLO FRKH6QjMAdgTHqE0UzyjSxxFdaft7sxLSzZj916EvxyvE/0vfqN/O8yuS4i8FBi+Bg8q qy/FGKuPMwgDSA5EYlZKp0i1Zz5S8slElcU1hmoyGK510ATSuCPjW3kMZjGqy7CTgvDx ZWOx0ZSc22sDcOqbJq70oJY+vIjorNRyshZXOmWj+l0TquYSDiSJH0lSCKQpLW+jjAvc Xhhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=L4HL1QbqHP1x4Gg1Q9Pi9mkmEUR7hv9riSw0Fw8OIgg=; b=q4E2KPc6Oi5L2Pg9b/qZbofvvYeluHfL38Nx6Y9m4OfFk4iffCTtJIAu5w91VZoVkk 7m08qGtCJa3M/AhJ1NVgLDpB9uOrtQZqDikryImWWySFoM8p5eVYaPScVINKy4XPsP2L zR0zkyQq/udu2ENXavdE/aiYUneKf9VRWtob4hdntHe18Tzbh3vWYsXHh560GAvbxiP2 UZfSiczv3nFM5p/F2EqiA3Tec/afoIW3nTJsgYsjDzlJaSHraui3goAa4fm+4Cb0uv3F VcW5Bp8lkdGD/kFyhMXG5fbcjtSaA3djFvga9YHF8LX4AjqatVNq2AdqksIUsxUqXWWX h2qA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r6si118997edw.131.2020.10.14.10.41.25; Wed, 14 Oct 2020 10:41:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730751AbgJNQ3Y (ORCPT + 99 others); Wed, 14 Oct 2020 12:29:24 -0400 Received: from mga02.intel.com ([134.134.136.20]:47384 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727071AbgJNQ3X (ORCPT ); Wed, 14 Oct 2020 12:29:23 -0400 IronPort-SDR: erbcOGVkNQeDx8Df2RRIY87F0vTZ8nMd2LXDkoqmtJn/BhTzUqcYu+CSKJHms4Z3O3mYPq1+aH OxF5fWqsjiNA== X-IronPort-AV: E=McAfee;i="6000,8403,9773"; a="153083713" X-IronPort-AV: E=Sophos;i="5.77,375,1596524400"; d="scan'208";a="153083713" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 09:29:23 -0700 IronPort-SDR: s0CzUVAUDc3xMILhqOKsrWZjy/mVlNCZvn9ereW+9OzQ1mJTS/vRXEptwuFA61sj9BsTAvW1uQ ekF3taKh3CHA== X-IronPort-AV: E=Sophos;i="5.77,375,1596524400"; d="scan'208";a="463943188" Received: from kwhitemx-mobl.amr.corp.intel.com (HELO [10.213.181.206]) ([10.213.181.206]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 09:29:22 -0700 Subject: Re: [RFC PATCH 13/22] x86/fpu/xstate: Expand dynamic user state area on first use To: Andy Lutomirski Cc: "Brown, Len" , Andy Lutomirski , "Bae, Chang Seok" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , X86 ML , "Liu, Jing2" , "Shankar, Ravi V" , LKML References: <78F221DB-CB61-40DB-9C6F-6C86D0F1BCDF@amacapital.net> <226772b9-7109-c632-2e9a-372df38b81a0@intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <69721125-4e1c-ca9c-ff59-8e1331933e6c@intel.com> Date: Wed, 14 Oct 2020 09:29:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/14/20 9:10 AM, Andy Lutomirski wrote: >> Actually, I think the modified optimization would survive such a scheme: >> >> * copy page array into percpu area >> * XRSTORS from percpu area, modified optimization tuple is saved >> * run userspace >> * XSAVES back to percpu area. tuple matches, modified optimization >> is still in play >> * copy percpu area back to page array >> >> Since the XRSTORS->XSAVES pair is both done to the percpu area, the >> XSAVE tracking hardware never knows it isn't working on the "canonical" >> buffer (the page array). > I was suggesting something a little bit different. We'd keep XMM, > YMM, ZMM, etc state stored exactly the way we do now and, for > AMX-using tasks, we would save the AMX state in an entirely separate > buffer. This way the pain of having a variable xstate layout is > confined just to AMX tasks. OK, got it. So, we'd either need a second set of XSAVE/XRSTORs, or "manual" copying of the registers out to memory. We can preserve the modified optimization if we're careful about ordering, but only for *ONE* of the XSAVE buffers (if we use two). > I'm okay with vmalloc() too, but I do think we need to deal with the > various corner cases like allocation failing. Yeah, agreed about handling the corner cases. Also, if we preserve plain old vmalloc() for now, we need good tracepoints or stats so we can precisely figure out how many vmalloc()s (and IPIs) are due to AMX.