Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp673706pxu;
        Wed, 14 Oct 2020 10:42:00 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJyeJOQbNyAaScYWZmnFvJtcdCLc2cerChqVmXCEZB5Xyy5iFKwfXjbzEoA6UBEgBBNPIUjw
X-Received: by 2002:a17:906:4cc2:: with SMTP id q2mr175525ejt.422.1602697320685;
        Wed, 14 Oct 2020 10:42:00 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1602697320; cv=none;
        d=google.com; s=arc-20160816;
        b=dcavueTtUkavr4DYZc6w1tRhsDrcuWRWOTcIWzXQkEEGP5mVXopQsu+usPJPNxg1UD
         1L73keyodonApP+2O+ZQMAxX4uwlftheHHsJhJMaB6wHWfnl+7YuxIe19jGDmaLPubIK
         SwVutPK1sgdA1tfxRffmWqREkhrZ3qyXspZp3y0CISMjMJkuefY8cGkPibcC/H1qLtx6
         dWtVr3TDyQsDvY42WqvEFdVJOKDykLvRvzDWjkYDL0fY0o+OlpdhrgM63aYU4N9c9p3s
         ZsqI1x6ARnae9YRlaWkul3yqmrqCQSegXbaOiVqHCytLm8b2HONKTEvTxhYKCxqNBv2N
         2TXw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:dkim-signature
         :dkim-signature:date;
        bh=iCzjYxqIDkmw4xzx1KXku7b0cbN/u38jxZbnzmQ3jN8=;
        b=gGVm7H1n+YlkST3fGLu0Ep60vnWvPPnDJgSmcLJZVt8Z81YonI+TM2d2gzpsT/sNwz
         BkhI0cCfIm+r8pJwIaFBCocuGCr/fcDZyPAvlm9HUUWN4/0vriwkz1z3eAIGNmwyVsf7
         hIVfhzYF/KnzW540JNLB4AfVz9Z+pHHGIS9BkEIlzFOrDKjwJnz4068bPT8masK4zbHc
         b+mXmPd4znSiECambrXfS37RoaXeic0ZXb7wxBdk5DmyQI31IzTkYDRNIIix52XLuNFv
         buSxbW9e8r8ZaCJvi3nbj1BlGQNFp14HdqNkem7O/do+FcBP+oTapMqyw066e2ZwbsZW
         xjew==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@linutronix.de header.s=2020 header.b=L+xCqI9G;
       dkim=neutral (no key) header.i=@linutronix.de;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id dd2si261078ejb.347.2020.10.14.10.41.38;
        Wed, 14 Oct 2020 10:42:00 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@linutronix.de header.s=2020 header.b=L+xCqI9G;
       dkim=neutral (no key) header.i=@linutronix.de;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2388342AbgJNQ1W (ORCPT <rfc822;kerneldev.sdk@gmail.com>
        + 99 others); Wed, 14 Oct 2020 12:27:22 -0400
Received: from Galois.linutronix.de ([193.142.43.55]:59738 "EHLO
        galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727071AbgJNQ1S (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 14 Oct 2020 12:27:18 -0400
Date:   Wed, 14 Oct 2020 18:27:14 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
        s=2020; t=1602692836;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=iCzjYxqIDkmw4xzx1KXku7b0cbN/u38jxZbnzmQ3jN8=;
        b=L+xCqI9GxpRCoP8PngWCWAQ9wkdzpZ5WodbiV80p51AGMLkCWCgkkJouSD5NDTKKaAroqH
        bEi6bv6abvSonjh+1Y12R0IyATkDhSK/gIBIqmUccHFDatfo1IDsEiCXwj/KvxA6xcB969
        +QvmLvKCGJH+ljJRLWshZ7jhABUTtdtr7oF3r534O+65KNP+5PElTQ4ZLtbTPMG9aD58PS
        cDKitk7SPcV0bjRsHW8LaycZTd7vJ45QOKO9ZwUrJBaHGZ0duR9einY6Sx9lu0AsA6t7MA
        d8RfzgrkXilE9GPgUHUD0YyBNnf1JF+Rhl06BFTBmLBY5d1iHAlG7C7OIEDXqQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
        s=2020e; t=1602692836;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=iCzjYxqIDkmw4xzx1KXku7b0cbN/u38jxZbnzmQ3jN8=;
        b=Tcm1BnHk6fiDiswRFgM+Nea81sLWNx1RNxoZwpZ/WAKUDTLpiU48x1RzsOa3CKc7I7gjpu
        NnAHKINmRZmU+DAw==
From:   Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To:     Alan Stern <stern@rowland.harvard.edu>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Johan Hovold <johan@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org,
        Thomas Winischhofer <thomas@winischhofer.net>,
        "Ahmed S. Darwish" <a.darwish@linutronix.de>,
        Mathias Nyman <mathias.nyman@intel.com>,
        Valentina Manea <valentina.manea.m@gmail.com>,
        Shuah Khan <shuah@kernel.org>, linux-omap@vger.kernel.org,
        Kukjin Kim <kgene@kernel.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, Felipe Balbi <balbi@kernel.org>,
        Duncan Sands <duncan.sands@free.fr>
Subject: Re: [patch 03/12] USB: serial: keyspan_pda: Consolidate room query
Message-ID: <20201014162714.ctv5earlhwsp4iqs@linutronix.de>
References: <20201014145215.518912759@linutronix.de>
 <20201014145727.338773481@linutronix.de>
 <20201014161433.GB712494@rowland.harvard.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201014161433.GB712494@rowland.harvard.edu>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2020-10-14 12:14:33 [-0400], Alan Stern wrote:
> Instead, consider using the new usb_control_msg_recv() API.  But it 
> might be better to allocate the buffer once and for all.

This will still allocate and free buffer on each invocation. What about
moving the query_buf to the begin of the struct / align it?

> Alan Stern

Sebastian