Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp793873pxu; Wed, 14 Oct 2020 14:02:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzIx26BInjvuat/a6beLw7JbGolPJpUpvq1YpOqUw7W4RVz8PaE5HFcJCh0kMmmZipUkWR7 X-Received: by 2002:a17:906:d159:: with SMTP id br25mr1037056ejb.155.1602709357684; Wed, 14 Oct 2020 14:02:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602709357; cv=none; d=google.com; s=arc-20160816; b=M01eVdVsC0ak1On3K44WegWSn931jDq0lrX6yXhMmzbPhAbgiD9FEkx/nnEmlq4x0q ih/kYhFKZnKdg8EaFvnD2mER0J34o4gMmZLPxTxTw6P04wf/gFMsKwV7B88bFpamzGhz /RXUpvyuIlqs0+je+OnmBlg8PERfU5ft9/ipGW2I+K8NWIArY44FymLr/u1OhRVer5Tv yRVKFGzajMuQWj2omkRj4ktduPqKCl1o5y2euIWiQ5mx69CsKE5USsjhD7kfCzGGdV+G 2VO+z6VzbeGDHktvqs2+OEPecFVFi8QSqLu7ray0PppvuSATpztVm3Gyx1gv4JCU3z8v Ttqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=3H6mGsRZewK80OZHFyPkl46RKkyXB0PbUSdyfxyv/nQ=; b=Q+bRNydG/qab1Sp7N4c8MFJkpzsepI4sSKVNmBavOr9iuJleZkYc6WouLwn+PdSdXQ LZ/tFJyGQ2leGk32zhP5qpctzVUhccLgsItJStwOYegyJOf7dDQ8+xGZ9nDQjFJQYQkv Gy7jIR7DfTxE6pXo524akpY86plYVP9N4RI2pZHk9uBJGUffuXuyVF4YQjojAQ65Tk0r 3luT1uMvmlPVusRBMj4tTORKfFDtotDzxQqof1so3CrN5jGBP1jEitHGKkxoxzwgsiEf xYQ2JceqHCSQFeE4F7oYse/y64muT0u9phjK/zoKziEddUtBDAD8Fbe30/DW13D+kJ2J TyoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="HyQv8i/w"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mb2si666858ejb.352.2020.10.14.14.02.12; Wed, 14 Oct 2020 14:02:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="HyQv8i/w"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730677AbgJNLYC (ORCPT + 99 others); Wed, 14 Oct 2020 07:24:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:28282 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730676AbgJNLYB (ORCPT ); Wed, 14 Oct 2020 07:24:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602674640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3H6mGsRZewK80OZHFyPkl46RKkyXB0PbUSdyfxyv/nQ=; b=HyQv8i/wihW30LtwkNZJtEMWb+T2k30mpmJA/FVZxsGHKDhlwwLMWXBGslf4AdVILGnenF HLRJLe0uPskFpXlWqCCylz7KV5782SRj+fFQbcw5Dr1yqsa6+jm91BEsiySwYN/8+SUC3y ShWM/wQtEnJGiUdyF1FbPCmjaA/vtkw= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-158-CtZ0tLdpMjSGkjWqWf90kg-1; Wed, 14 Oct 2020 07:23:57 -0400 X-MC-Unique: CtZ0tLdpMjSGkjWqWf90kg-1 Received: by mail-ej1-f72.google.com with SMTP id i21so1061055ejb.5 for ; Wed, 14 Oct 2020 04:23:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3H6mGsRZewK80OZHFyPkl46RKkyXB0PbUSdyfxyv/nQ=; b=ewhu586zoRCMLlBCmi6c+/rRhg4Zb5OtuU1i0X4LkZ/bSk7VZ5KufaRkvPyrmp61+m 5YAL+tuuifDHgbOLulJtYGeRzAwkrHOVyqJ+lOj1ZwNooIzGw4bMv5NMXRSfmqbMRaG9 GLg68xS9IJ7HHXZ0RQUk8DhVfL/9dM5e9ow/xuphyTGgNVqctD1iQbZK/kgGu3S5MvrQ /StoecLAeRAE62gVuGjd3OouTqhCPTT7pa/pHYS5eZ5nLgQNslRZuRPteqO1cCAwpGqh 4y4RVtT1yZDSCn2PFmmTKqooVAf0XpTY/yKuoIQPwhy+QiJUihAOYDA4Gz7xZ4gleDbh svVA== X-Gm-Message-State: AOAM533vlLBYF9ISAs/Hg3EOJjCMUtjjkx/WFj/8HsQA+Rp7R+T46vL1 ClWwweNAXp35xXV8oU6wraInO4GHrddUF8Fq7Q+I71rbFT2X8fb+XxUjnrTUJEgCEakgHKUVBnM USUusSxh8bCjPIxqh9m+ot9u0 X-Received: by 2002:a17:906:5052:: with SMTP id e18mr4562636ejk.530.1602674635888; Wed, 14 Oct 2020 04:23:55 -0700 (PDT) X-Received: by 2002:a17:906:5052:: with SMTP id e18mr4562615ejk.530.1602674635646; Wed, 14 Oct 2020 04:23:55 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c0c-fe00-d2ea-f29d-118b-24dc.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:d2ea:f29d:118b:24dc]) by smtp.gmail.com with ESMTPSA id rn10sm1584899ejb.8.2020.10.14.04.23.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Oct 2020 04:23:55 -0700 (PDT) Subject: Re: [PATCH AUTOSEL 5.8 17/20] i2c: core: Call i2c_acpi_install_space_handler() before i2c_acpi_register_devices() To: kieran.bingham@ideasonboard.com, Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mika Westerberg , Wolfram Sang , linux-i2c@vger.kernel.org References: <20200921144027.2135390-1-sashal@kernel.org> <20200921144027.2135390-17-sashal@kernel.org> <1977b57b-fae6-d9d4-e6bf-3d4013619537@ideasonboard.com> From: Hans de Goede Message-ID: Date: Wed, 14 Oct 2020 13:23:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1977b57b-fae6-d9d4-e6bf-3d4013619537@ideasonboard.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 10/14/20 1:09 PM, Kieran Bingham wrote: > Hi Hans, Sasha, > > As mentioned on https://github.com/linux-surface/kernel/issues/63, I'm > afraid I've bisected a boot time issue on the Microsoft Surface Go 2 to > this commit on the stable 5.8 tree. > > The effect as reported there is that the boot process stalls just after > loading the usbhid module. > > Typing, or interacting with the Keyboard (Type Cover) at that point > appears to cause usb bus resets, but I don't know if that's a related > symptom or just an effect of some underlying root cause. > > I have been running a linux-media kernel on this device without issue. > > Is this commit in 5.9? I'll build a vanilla v5.9 kernel and see if it > occurs there too. Yes the commit is in 5.9 too. Still would be interesting to see if 5.9 hits this issue too. I guess it will, but as I mentioned in: https://github.com/linux-surface/kernel/issues/63 I do not understand why this commit is causing this issue. So I just checked and the whole acpidump is not using I2C opregion stuff at all: [hans@x1 microsoft-surface-go2]$ ack GenericSerialBus *.dsl [hans@x1 microsoft-surface-go2]$ And there is only 1 _REG handler which is for the embedded-controller. So this patch should not make a difference at all on the GO2, other then maybe a subtle timing difference somewhere ... ? Regards, Hans > On 21/09/2020 15:40, Sasha Levin wrote: >> From: Hans de Goede >> >> [ Upstream commit 21653a4181ff292480599dad996a2b759ccf050f ] >> >> Some ACPI i2c-devices _STA method (which is used to detect if the device >> is present) use autodetection code which probes which device is present >> over i2c. This requires the I2C ACPI OpRegion handler to be registered >> before we enumerate i2c-clients under the i2c-adapter. >> >> This fixes the i2c touchpad on the Lenovo ThinkBook 14-IIL and >> ThinkBook 15 IIL not getting an i2c-client instantiated and thus not >> working. >> >> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1842039 >> Signed-off-by: Hans de Goede >> Reviewed-by: Mika Westerberg >> Signed-off-by: Wolfram Sang >> Signed-off-by: Sasha Levin >> --- >> drivers/i2c/i2c-core-base.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c >> index 4f09d4c318287..7031393c74806 100644 >> --- a/drivers/i2c/i2c-core-base.c >> +++ b/drivers/i2c/i2c-core-base.c >> @@ -1336,8 +1336,8 @@ static int i2c_register_adapter(struct i2c_adapter *adap) >> >> /* create pre-declared device nodes */ >> of_i2c_register_devices(adap); >> - i2c_acpi_register_devices(adap); >> i2c_acpi_install_space_handler(adap); >> + i2c_acpi_register_devices(adap); >> >> if (adap->nr < __i2c_first_dynamic_bus_num) >> i2c_scan_static_board_info(adap); >> > >