Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp29129pxu; Wed, 14 Oct 2020 19:06:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZ/XWOIM9OE2988YpaLf4zdzHtCvh0atBzGRWOPLiTPkV/BbqOgSbxlQ7KY5QuzTF+TdIB X-Received: by 2002:a17:906:4e06:: with SMTP id z6mr2164366eju.370.1602727596076; Wed, 14 Oct 2020 19:06:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602727596; cv=none; d=google.com; s=arc-20160816; b=X7gKRrivKGiGvtOMBVeX+5U/X4QSIEmU5lf0MaMYJIE/RLv5PzD2APFrBsJAUzRcvq dAmt7VSIwwhp+QNHTsOaPXv9hOna0H7GHaOWWwe48hgv1xPZyeQVONgYdkWlhSxV4KAf LM0PkBvBzh7O663I1cVZ5mR4AIxB+H8clyM4sXQpu6qOR5HBol/PYyC40Q1J04bNBY1w dD3HzXOAElJ7DEm0xSqJ+Jzn7t4/F/udrAHglS+lLd86HMadB9bNlqcqTNWsH+MOPnbr Xjsk0FTReI4NUCz3MBoP1Q8NgN0QhZmy7294RCW/5+zG38gwiklkui9OxvZKLMMkdH3Q 4y6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=SWrjDZ0fM+fi/dlxSYWjn8YNDLZjZcQ9Ze7BMW23GS4=; b=HYlsEwh11XbvirS6/jv4BIKqsCnHj4dRoYRr8C5Y53/MvedrzfWqf4VlIM8QQUTY7J SWXrNrm99CROsM+VywjPwDou1J/dYLzWHQIZHs73dC550we5Bes0FFSYZKJeG5SsD2tf 4UgxuhRV3GFCEdCiBLF1torJcGAPkdreSYUToi7ALSjeXfO6e1WR5DkrjcBtCn4XguqL ZcDlIzglJfmBtzMorF3GdIwhzHZMHy/GtaAYKMMGF3LCDr9igcB64QVW7deRTKHIe61N VsZ5VVvsdnBRdaiv0e2ZW84xDKAPsQA6idWaQ9od/uPmQ8S9NPD6kQXyDFZNaftGBQpa uPYQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q1si1090105ejf.509.2020.10.14.19.06.12; Wed, 14 Oct 2020 19:06:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729828AbgJNUQK (ORCPT + 99 others); Wed, 14 Oct 2020 16:16:10 -0400 Received: from mga12.intel.com ([192.55.52.136]:7341 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728714AbgJNUQK (ORCPT ); Wed, 14 Oct 2020 16:16:10 -0400 IronPort-SDR: RFB3TK6ynsZOeHsI7pJper5VRAnjqfSuT3DM6Eh8hBgynIPIxAbvOtjXcstI3mMdLBfFBLKhMi US9FJW54FOCw== X-IronPort-AV: E=McAfee;i="6000,8403,9774"; a="145493675" X-IronPort-AV: E=Sophos;i="5.77,375,1596524400"; d="scan'208";a="145493675" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 13:16:04 -0700 IronPort-SDR: bma3EIcu2t3AtD1FjXgy3cO7cczzf2iL5Q77hyi3BPPuAqGQKF1iUvgB3Tpz1V1HGTzIo5Ls/i K/gz7dOM5PhQ== X-IronPort-AV: E=Sophos;i="5.77,375,1596524400"; d="scan'208";a="314279670" Received: from kwhitemx-mobl.amr.corp.intel.com (HELO [10.213.181.206]) ([10.213.181.206]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 13:16:02 -0700 Subject: Re: [PATCH v39 11/24] x86/sgx: Add SGX enclave driver To: Jarkko Sakkinen , Greg KH Cc: Haitao Huang , x86@kernel.org, linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Jethro Beekman , Chunyang Hui , Jordan Hand , Nathaniel McCallum , Seth Moore , Darren Kenny , Sean Christopherson , Suresh Siddha , andriy.shevchenko@linux.intel.com, asapek@google.com, bp@alien8.de, cedric.xing@intel.com, chenalexchen@google.com, conradparker@google.com, cyhanish@google.com, haitao.huang@intel.com, kai.huang@intel.com, kai.svahn@intel.com, kmoy@google.com, ludloff@google.com, luto@kernel.org, nhorman@redhat.com, puiterwijk@redhat.com, rientjes@google.com, tglx@linutronix.de, yaozhangx@google.com, mikko.ylinen@intel.com References: <20201003045059.665934-1-jarkko.sakkinen@linux.intel.com> <20201003045059.665934-12-jarkko.sakkinen@linux.intel.com> <20201003143925.GB800720@kroah.com> <20201004143246.GA3561@linux.intel.com> <20201005094246.GB151835@kroah.com> <20201005124221.GA191854@linux.intel.com> <20201007192655.GA104072@kroah.com> <20201009064414.GA2744@linux.intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <737f452f-b309-5bfa-0a7b-819a36f78748@intel.com> Date: Wed, 14 Oct 2020 13:16:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201009064414.GA2744@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/8/20 11:44 PM, Jarkko Sakkinen wrote: >> Why is this so special that you need a subdirectory for a single driver >> with a mere 2 device nodes? Do any other misc drivers have a new >> subdirectory in /dev/ for them? > Absolutely nothing as far as I'm concerned. Should have done that > already at the time when I switched to misc based on your feedback. I > was acting too reactive I guess. For sure I'll rename. Plus, if anyone *REALLY* cares, they can get their precious directory back with a couple of lines of udev rules, I believe: KERNEL=="sgx_provision", SYMLINK+="sgx/provision" KERNEL=="sgx_enclave", SYMLINK+="sgx/enclave"