Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp32275pxu; Wed, 14 Oct 2020 19:13:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxhC7mKAc+MNWo2HoCYF1zdyrqJwbF8Ig92jisXN4K45T6ueb8e0WPKar0A6VM4ZsmUaO2u X-Received: by 2002:a17:906:4e16:: with SMTP id z22mr2017951eju.527.1602728004204; Wed, 14 Oct 2020 19:13:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602728004; cv=none; d=google.com; s=arc-20160816; b=WqE9ydRnOfhoJjbaMpVdeK/2OPwD+W/elPVvdn/36Dqh0dWNgzGxRWyaWnOwxoj8R4 EE73avIgV+UrmAW7LQU5oTfrF9HNVhPE97vRIr+oDvEkTYTTatrv1nwaauATDveVkbgd hOWDVEJ9dHhjVJEyvqz2ofsMCsSNRsNa9bEZGVzAbf5916O+vWxEaZ8qeEcMBjyszTPI pgO+94tVGTBZ3XQ8HSIi5aaKHabtCQmuwzSFOdtu91uzRD2J6PCAKin41nANA8sq2hS8 Ah7QwLYSU3j6Vio1cS7V+GW2jD7d1O6oDXl3uwg6jxSSyy1o82RLIaUOPpFz23ejKdzc ycpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:to:from:subject:message-id; bh=bTpnX7DQMK7eSgabdjqs9VruvUH15J2szLcHbnd4zY0=; b=Lc7+Rqa0l9q2Gfeemd1kRe9KU3Ei9UduBAwZGX/eMwqKuFB1GeqzhGgWm011D/fA9O pww7DOXyUX6enlBtOnJO6AvD2y9nBc37YB4HOWhwYFXrk8MENtVaSnshfjwzajvh8r/C BKREiebxHgBDQWcPNRC34ieBDxFCKINYUBOeXCBSjKrPF9yEONPJhMoqcepM9oJYFwsg 3uoBnxOYuSYMbCttp7AMEAoBsSrrPhb0SDOsac/jWDENONzHDGRTDqJ/RmfK6Admg7lb FlgDlYpx7cx6ZBv2JPWcfXCSv4/ZrckT39Lw3M8TRnwTiUsiVLee2h/r5P+lUg5LB2MI yxFg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h16si1146825edv.69.2020.10.14.19.13.01; Wed, 14 Oct 2020 19:13:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729140AbgJNUsj (ORCPT + 99 others); Wed, 14 Oct 2020 16:48:39 -0400 Received: from smtprelay0239.hostedemail.com ([216.40.44.239]:56500 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727413AbgJNUsj (ORCPT ); Wed, 14 Oct 2020 16:48:39 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 6EB9618224D68; Wed, 14 Oct 2020 20:48:38 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,,RULES_HIT:41:69:355:379:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1381:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:4321:5007:10004:10400:10848:11026:11232:11658:11914:12043:12291:12297:12663:12683:12740:12760:12895:13069:13311:13357:13439:14096:14097:14181:14659:14721:14915:21080:21451:21622:30012:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: fan01_4617e032720e X-Filterd-Recvd-Size: 2449 Received: from XPS-9350 (cpe-72-134-80-165.natsow.res.rr.com [72.134.80.165]) (Authenticated sender: joe@perches.com) by omf17.hostedemail.com (Postfix) with ESMTPA; Wed, 14 Oct 2020 20:48:37 +0000 (UTC) Message-ID: <8aff1623d069f37e089c5dcc7fb3fa00c272a886.camel@perches.com> Subject: Re: [PATCH 0/2] module: some refactoring in module_sig_check() From: Joe Perches To: Sergey Shtylyov , Jessica Yu , linux-kernel@vger.kernel.org Date: Wed, 14 Oct 2020 13:48:36 -0700 In-Reply-To: References: <789a4e5c-8efd-bb1c-86e2-eed8b2b7b0af@omprussia.ru> <3897a8ce5760affa304952c2d30c1266589407f2.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-10-14 at 22:44 +0300, Sergey Shtylyov wrote: > On 10/14/20 11:35 AM, Joe Perches wrote: > > [...] > > > > > Here are 2 patches against the 'modules-next' branch of Jessica Yu's 'linux.git' repo. > > > > > I'm doing some little refactoring in module_sig_check()... > > > > > > > > > > [1/2] module: merge repetitive strings in module_sig_check() > > > > > [2/2] module: unindent comments in module_sig_check() > > > > > > > > I think this code is rather cryptic and could be made clearer. > > > > > > > > How about: > > > > --- > > > > kernel/module.c | 51 ++++++++++++++++++++++++++------------------------- > > > > 1 file changed, 26 insertions(+), 25 deletions(-) > > > > > > Looks good. Do you want to post complete patch(es)? :-) > > > > I don't like posting actual patches on top of other people. > > It's a complete and compilable diff, it's just unsigned. > > It does too many things simultaneously, I'll need to decompose it... > > > If you want a Signed-off-by: here's one: > > > > Signed-off-by: Joe Perches > > I think I'll rather use Suggested-by: where appropriate... I don't think it does too many things and I'm not a big fan of micro-patches, but no worries, do what you want to it. I just thought the code poor and a bit unreadable given the internal goto in a switch/case block.