Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peng Fan <peng.fan@nxp.com>
To:     Mathieu Poirier <mathieu.poirier@linaro.org>,
        "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        "ohad@wizery.com" <ohad@wizery.com>
CC:     "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 01/13] remoteproc: Re-check state in rproc_shutdown()
Thread-Topic: [PATCH 01/13] remoteproc: Re-check state in rproc_shutdown()
Thread-Index: AQHWe8jP8/+8ndV5lUW//Ng5RVV1N6mYLUFw
Date:   Thu, 15 Oct 2020 01:28:40 +0000
Message-ID: <DB6PR0402MB2760DB90DA376F4BB2DBB9D888020@DB6PR0402MB2760.eurprd04.prod.outlook.com>
References: <20200826164529.224476-1-mathieu.poirier@linaro.org>
 <20200826164529.224476-2-mathieu.poirier@linaro.org>
In-Reply-To: <20200826164529.224476-2-mathieu.poirier@linaro.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f1f220e-cb78-42d5-c183-08d870a9a620
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2020 01:28:40.9964
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: a5oOvAO3bRRg0kESrPkSltRAifrdF1h43Fly1Y7zHMMdEPF7+GCRlPfEevsOUZIyWRzam22qgVOWu+66mm2tSQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4090
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH 01/13] remoteproc: Re-check state in rproc_shutdown()
>=20
> The state of the remote processor may have changed between the time a cal=
l
> to rproc_shutdown() was made and the time it is executed.  To avoid movin=
g
> forward with an operation that may have been cancelled, recheck while
> holding the mutex.
>=20
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
>  drivers/remoteproc/remoteproc_core.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/drivers/remoteproc/remoteproc_core.c
> b/drivers/remoteproc/remoteproc_core.c
> index 7f90eeea67e2..fb2632cbd2df 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -1834,6 +1834,9 @@ void rproc_shutdown(struct rproc *rproc)
>  		return;
>  	}
>=20
> +	if (rproc->state !=3D RPROC_RUNNING)
> +		goto out;
> +
>  	/* if the remote proc is still needed, bail out */
>  	if (!atomic_dec_and_test(&rproc->power))
>  		goto out;
> --

Reviewed-by: Peng Fan <peng.fan@nxp.com>