Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peng Fan <peng.fan@nxp.com>
To:     Mathieu Poirier <mathieu.poirier@linaro.org>,
        "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        "ohad@wizery.com" <ohad@wizery.com>
CC:     "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 08/13] remoteproc: Rename function rproc_actuate()
Thread-Topic: [PATCH 08/13] remoteproc: Rename function rproc_actuate()
Thread-Index: AQHWe8i2FY2XICtKNU+E0/X+bT23t6mYOnnw
Date:   Thu, 15 Oct 2020 02:15:58 +0000
Message-ID: <DB6PR0402MB27602C9085027346DE35F3A788020@DB6PR0402MB2760.eurprd04.prod.outlook.com>
References: <20200826164529.224476-1-mathieu.poirier@linaro.org>
 <20200826164529.224476-9-mathieu.poirier@linaro.org>
In-Reply-To: <20200826164529.224476-9-mathieu.poirier@linaro.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d3ec6e61-2b4a-46cc-890f-08d870b04131
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2020 02:15:58.1656
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Wffl3rVzavlEJanlfydhsI3NtSIKTXXDa8tSFu7NpQNp4uOWKXoWmonDLGp+KAMtt8foZmYftx5y12fBqC9uNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6857
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH 08/13] remoteproc: Rename function rproc_actuate()
>=20
> Align what was done for rproc_detach() by renaming function rproc_actuate=
().
> That way it is easier to figure out the opposite of each functions.
>=20
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
>  drivers/remoteproc/remoteproc_core.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>=20
> diff --git a/drivers/remoteproc/remoteproc_core.c
> b/drivers/remoteproc/remoteproc_core.c
> index f3943a1e2754..c4b80ce6f22d 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -1393,7 +1393,7 @@ static int rproc_start(struct rproc *rproc, const
> struct firmware *fw)
>  	return ret;
>  }
>=20
> -static int rproc_attach(struct rproc *rproc)
> +static int __rproc_attach(struct rproc *rproc)
>  {
>  	struct device *dev =3D &rproc->dev;
>  	int ret;
> @@ -1518,7 +1518,7 @@ static int rproc_fw_boot(struct rproc *rproc, const
> struct firmware *fw)
>   * Attach to remote processor - similar to rproc_fw_boot() but without
>   * the steps that deal with the firmware image.
>   */
> -static int rproc_actuate(struct rproc *rproc)
> +static int rproc_attach(struct rproc *rproc)
>  {
>  	struct device *dev =3D &rproc->dev;
>  	int ret;
> @@ -1558,7 +1558,7 @@ static int rproc_actuate(struct rproc *rproc)
>  		goto clean_up_resources;
>  	}
>=20
> -	ret =3D rproc_attach(rproc);
> +	ret =3D __rproc_attach(rproc);
>  	if (ret)
>  		goto clean_up_resources;
>=20
> @@ -1802,7 +1802,7 @@ int rproc_boot(struct rproc *rproc)
>  	if (rproc->state =3D=3D RPROC_DETACHED) {
>  		dev_info(dev, "attaching to %s\n", rproc->name);
>=20
> -		ret =3D rproc_actuate(rproc);
> +		ret =3D rproc_attach(rproc);
>  	} else {
>  		dev_info(dev, "powering up %s\n", rproc->name);
>=20
> @@ -1893,7 +1893,7 @@ EXPORT_SYMBOL(rproc_shutdown);
>   *
>   * @rproc: the remote processor
>   *
> - * Detach a remote processor (previously attached to with rproc_actuate(=
)).
> + * Detach a remote processor (previously attached to with rproc_attach()=
).
>   *
>   * In case @rproc is still being used by an additional user(s), then
>   * this function will just decrement the power refcount and exit,
> --

Reviewed-by: Peng Fan <peng.fan@nxp.com>