Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peng Fan <peng.fan@nxp.com>
To:     Mathieu Poirier <mathieu.poirier@linaro.org>,
        "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        "ohad@wizery.com" <ohad@wizery.com>
CC:     "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 10/13] remoteproc: Properly deal with a stop request when
 attached
Thread-Topic: [PATCH 10/13] remoteproc: Properly deal with a stop request when
 attached
Thread-Index: AQHWe8i11hJitluPOE2eW7GIU2JGu6mYPk/A
Date:   Thu, 15 Oct 2020 02:29:24 +0000
Message-ID: <DB6PR0402MB276006E781EF4EAEA3C242D088020@DB6PR0402MB2760.eurprd04.prod.outlook.com>
References: <20200826164529.224476-1-mathieu.poirier@linaro.org>
 <20200826164529.224476-11-mathieu.poirier@linaro.org>
In-Reply-To: <20200826164529.224476-11-mathieu.poirier@linaro.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ee6c7b7-af5e-4cb4-2b1f-08d870b221e4
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2020 02:29:24.6426
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: I5PjI81lAGvLoNZvbGdDMdfCi5BSDdcss3KNYnf8j5xLc8+YFD0+nM08aIateXwgv4/PI7j4bLkPcMjs3mVVRA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6618
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH 10/13] remoteproc: Properly deal with a stop request when
> attached
>=20
> This patch introduces the capability to stop a remote processor that has =
been
> attached to by the remoteproc core.  For that to happen a rproc::ops::sto=
p()
> operation need to be available.
>=20
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
>  drivers/remoteproc/remoteproc_cdev.c  | 5 +++--
> drivers/remoteproc/remoteproc_core.c  | 6 +++++-
> drivers/remoteproc/remoteproc_sysfs.c | 5 +++--
>  3 files changed, 11 insertions(+), 5 deletions(-)
>=20
> diff --git a/drivers/remoteproc/remoteproc_cdev.c
> b/drivers/remoteproc/remoteproc_cdev.c
> index b19ea3057bde..d06f8d4919c7 100644
> --- a/drivers/remoteproc/remoteproc_cdev.c
> +++ b/drivers/remoteproc/remoteproc_cdev.c
> @@ -37,10 +37,11 @@ static ssize_t rproc_cdev_write(struct file *filp, co=
nst
> char __user *buf, size_
>=20
>  		ret =3D rproc_boot(rproc);
>  	} else if (!strncmp(cmd, "stop", len)) {
> -		if (rproc->state !=3D RPROC_RUNNING)
> +		if (rproc->state !=3D RPROC_RUNNING &&
> +		    rproc->state !=3D RPROC_ATTACHED)
>  			return -EINVAL;
>=20
> -		rproc_shutdown(rproc);
> +		ret =3D rproc_shutdown(rproc);
>  	} else {
>  		dev_err(&rproc->dev, "Unrecognized option\n");
>  		ret =3D -EINVAL;
> diff --git a/drivers/remoteproc/remoteproc_core.c
> b/drivers/remoteproc/remoteproc_core.c
> index c6c6aba66098..95bb40b4ebb3 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -1619,6 +1619,10 @@ static int rproc_stop(struct rproc *rproc, bool
> crashed)
>  	struct device *dev =3D &rproc->dev;
>  	int ret;
>=20
> +	/* No need to continue if a stop() operation has not been provided */
> +	if (!rproc->ops->stop)
> +		return -EINVAL;
> +
>  	/* Stop any subdevices for the remote processor */
>  	rproc_stop_subdevices(rproc, crashed);
>=20
> @@ -1857,7 +1861,7 @@ int rproc_shutdown(struct rproc *rproc)
>  		return ret;
>  	}
>=20
> -	if (rproc->state !=3D RPROC_RUNNING) {
> +	if (rproc->state !=3D RPROC_RUNNING && rproc->state !=3D
> RPROC_ATTACHED) {
>  		ret =3D -EPERM;
>  		goto out;
>  	}
> diff --git a/drivers/remoteproc/remoteproc_sysfs.c
> b/drivers/remoteproc/remoteproc_sysfs.c
> index c152d11a4d3c..6134d2f083ce 100644
> --- a/drivers/remoteproc/remoteproc_sysfs.c
> +++ b/drivers/remoteproc/remoteproc_sysfs.c
> @@ -113,10 +113,11 @@ static ssize_t state_store(struct device *dev,
>  		if (ret)
>  			dev_err(&rproc->dev, "Boot failed: %d\n", ret);
>  	} else if (sysfs_streq(buf, "stop")) {
> -		if (rproc->state !=3D RPROC_RUNNING)
> +		if (rproc->state !=3D RPROC_RUNNING &&
> +		    rproc->state !=3D RPROC_ATTACHED)
>  			return -EINVAL;
>=20
> -		rproc_shutdown(rproc);
> +		ret =3D rproc_shutdown(rproc);
>  	} else {
>  		dev_err(&rproc->dev, "Unrecognised option: %s\n", buf);
>  		ret =3D -EINVAL;
> --

Reviewed-by: Peng Fan <peng.fan@nxp.com>