Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp93476pxu; Wed, 14 Oct 2020 21:28:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJ9bsdG4cqW9KzKvL42HLTcirEJs1iKZBr8edS/gWQ/ds5GEv0gsh3m7twMtGcZ8FxhWn3 X-Received: by 2002:a17:906:3290:: with SMTP id 16mr2438239ejw.308.1602736092728; Wed, 14 Oct 2020 21:28:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602736092; cv=none; d=google.com; s=arc-20160816; b=TES3Ee1ktuJmP/Y8J8//OjTVQxpi0kMHv1iW8+Sjz0XlB0ag4FqqiB+bluHkrTW/bP 06RZ4TtA9vaBEXDwK48CLmN9b12THThrxd6HNiUu2msNBc6ompj9z4BLhTf4GxH/+JxR S3cro26f8A8rmIdj2p01Y1TnWjNV/8vj8Xcv0XxW8/F2/tJO8nGVzicOtjrnYlmRBte9 KlAAOZsJ9pZs/pSUXf8Gx2W/cCMnMmfLdtY0pr5HWPzIhOMqKXWiddVQISKtEW2my8SC 8E8C1RKQtfyJosLTXm/U8OfGNSaLMUq9flRqZIHGxASEntC13JjU4GihhL8lgMwTJVm3 8BGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=sPmN39XMdhH/ZRzEWbdWRJa4YGst6YX4ITt4ggC9sgk=; b=nRZjG4jH8cmypV0xpYl42MM2HYL0Ynhrsj5o/qKM3F4KOIcSTtmHeXL6UXY7iaG5s4 DPs6TQhaqkXVrY8ZHNJNqIv4ppkh4Q2N9SYEtmWKIHgqPn98dHAAsN4d3BHePvbB3pGi 99hK8aTdxZI+HLSaJOG1Q6oclM5nNZwQHY2XySKIMLkSd5xY6eLNrCPJMOH6++MaNsu/ gOzRENYWRxfgMWfIama9yxxSI4I0KK/1btOajgAACVRyZu6J2rL+VrKIE5kDUk9V9zR3 +QqboPU/VQtvGut4dfZEloxW1/VZSsbL6lcTkaEFL8Ytcp/JnytOoFnVfYXsGnQbx/Za mEGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=H7wKZzmk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v11si1271604ejw.321.2020.10.14.21.27.50; Wed, 14 Oct 2020 21:28:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=H7wKZzmk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730636AbgJOCsq (ORCPT + 99 others); Wed, 14 Oct 2020 22:48:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726395AbgJOCsq (ORCPT ); Wed, 14 Oct 2020 22:48:46 -0400 Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1531CC061755 for ; Wed, 14 Oct 2020 19:48:46 -0700 (PDT) Received: by mail-lf1-x141.google.com with SMTP id z2so1808560lfr.1 for ; Wed, 14 Oct 2020 19:48:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sPmN39XMdhH/ZRzEWbdWRJa4YGst6YX4ITt4ggC9sgk=; b=H7wKZzmknLGSwJX8VVMAlFL2hjitpKjoF2M0l3LGbtFcQhq6fmjQGIu0Mb77YCa8qb bpr2OddXeAy1ASmwtlmu8twK2w5a/a1VchvtD/FmunIJolvudip8ACBxLYa7jJ06ix40 ZpAiCTTlJ3OI59TEjqTICKyQyumqI82mBPYIU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sPmN39XMdhH/ZRzEWbdWRJa4YGst6YX4ITt4ggC9sgk=; b=nhSWbJWeVDrlc81uLX9NBQf+yBAScqVVIY9Sq2F308xbCQeR2gHunp8ih/B4V2igMV HfuQ6voWCVBM7gg+3H/el77CyT1d9TFYS4RSqxUR5m6x3ePaicLx78P5keHGQkEoNa8R l699ObqcfB17szMtY9wNg8MAllYhUlL7kKJUXR17SwcOmLyrqt/REFJTznLacED8RRKL 7NNlyNazTUoddipjy7+sTndGoUzXdHjhFcv6tQeb5mDliodh1+HLGH64FhK7c8YgQfk0 9HuwtPF9/GXak3nUZpn0tStrORsfeQU0C3wO2UEq8ighdWd+ZG8QEmpafT0LwPQ59xIx 9fiA== X-Gm-Message-State: AOAM532GKcUqGrkKe1od/e+2qg1HRvWg1coOW0QwHqPhdhWUo/QpOgni gFsEfi6xJYKwmx2qeYEJA68C4PRYqSS9aw== X-Received: by 2002:a19:ee12:: with SMTP id g18mr338138lfb.515.1602730124339; Wed, 14 Oct 2020 19:48:44 -0700 (PDT) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com. [209.85.167.49]) by smtp.gmail.com with ESMTPSA id p145sm456383lfa.256.2020.10.14.19.48.42 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Oct 2020 19:48:42 -0700 (PDT) Received: by mail-lf1-f49.google.com with SMTP id c141so1783341lfg.5 for ; Wed, 14 Oct 2020 19:48:42 -0700 (PDT) X-Received: by 2002:a19:4815:: with SMTP id v21mr336886lfa.603.1602730121761; Wed, 14 Oct 2020 19:48:41 -0700 (PDT) MIME-Version: 1.0 References: <160272187483.913987.4254237066433242737.stgit@magnolia> In-Reply-To: <160272187483.913987.4254237066433242737.stgit@magnolia> From: Linus Torvalds Date: Wed, 14 Oct 2020 19:48:25 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/2] vfs: move the clone/dedupe/remap helpers to a single file To: "Darrick J. Wong" Cc: Andrew Morton , Al Viro , Linux-MM , Linux Kernel Mailing List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 14, 2020 at 5:31 PM Darrick J. Wong wrote: > > So, I have a few questions, particularly for Al, Andrew, and Linus: > > (1) Do you find this reorganizing acceptable? I don't see a problem. > (3) Can I just grab the copyrights from mm/filemap.c? Or fs/read_write.c? > Or something entirely different? Heh. Those copyright notices look pretty old, and I'm not sure how much - if anything - I had to do with the remap helpers. I suspect just a // SPDX-License-Identifier: GPL-2.0-only is fine, with no need to try to drag along any other copyright notice history from those two files. Linus