Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peng Fan <peng.fan@nxp.com>
To:     Mathieu Poirier <mathieu.poirier@linaro.org>,
        "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        "ohad@wizery.com" <ohad@wizery.com>
CC:     "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 11/13] remoteproc: Properly deal with detach request
Thread-Topic: [PATCH 11/13] remoteproc: Properly deal with detach request
Thread-Index: AQHWe8ilgzet8FtReUWF3NILfcsyS6mYPobw
Date:   Thu, 15 Oct 2020 02:30:11 +0000
Message-ID: <DB6PR0402MB27608C80AA68CFB8DAB3C6F088020@DB6PR0402MB2760.eurprd04.prod.outlook.com>
References: <20200826164529.224476-1-mathieu.poirier@linaro.org>
 <20200826164529.224476-12-mathieu.poirier@linaro.org>
In-Reply-To: <20200826164529.224476-12-mathieu.poirier@linaro.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: fce2cb08-7692-4a5c-44c8-08d870b23d8a
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2020 02:30:11.1276
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ljxV2C3GYFvrPfKoGKnmFBGJhV7+Jb0zI36dSDSxOD103gWQySawSEm00U1h1cRKbvDWPb8wLg4JjNhWj832AA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6618
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH 11/13] remoteproc: Properly deal with detach request
>=20
> This patch introduces the capability to detach a remote processor that ha=
s
> been attached to or booted by the remoteproc core.  For that to happen a
> rproc::ops::detach() operation need to be available.
>=20
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
>  drivers/remoteproc/remoteproc_cdev.c  | 6 ++++++
> drivers/remoteproc/remoteproc_sysfs.c | 6 ++++++
>  2 files changed, 12 insertions(+)
>=20
> diff --git a/drivers/remoteproc/remoteproc_cdev.c
> b/drivers/remoteproc/remoteproc_cdev.c
> index d06f8d4919c7..3a3830e27050 100644
> --- a/drivers/remoteproc/remoteproc_cdev.c
> +++ b/drivers/remoteproc/remoteproc_cdev.c
> @@ -42,6 +42,12 @@ static ssize_t rproc_cdev_write(struct file *filp, con=
st
> char __user *buf, size_
>  			return -EINVAL;
>=20
>  		ret =3D rproc_shutdown(rproc);
> +	} else if (!strncmp(cmd, "detach", len)) {
> +		if (rproc->state !=3D RPROC_RUNNING &&
> +		    rproc->state !=3D RPROC_ATTACHED)
> +			return -EINVAL;
> +
> +		ret =3D rproc_detach(rproc);
>  	} else {
>  		dev_err(&rproc->dev, "Unrecognized option\n");
>  		ret =3D -EINVAL;
> diff --git a/drivers/remoteproc/remoteproc_sysfs.c
> b/drivers/remoteproc/remoteproc_sysfs.c
> index 6134d2f083ce..013231f69837 100644
> --- a/drivers/remoteproc/remoteproc_sysfs.c
> +++ b/drivers/remoteproc/remoteproc_sysfs.c
> @@ -118,6 +118,12 @@ static ssize_t state_store(struct device *dev,
>  			return -EINVAL;
>=20
>  		ret =3D rproc_shutdown(rproc);
> +	} else if (sysfs_streq(buf, "detach")) {
> +		if (rproc->state !=3D RPROC_RUNNING &&
> +		    rproc->state !=3D RPROC_ATTACHED)
> +			return -EINVAL;
> +
> +		ret =3D rproc_detach(rproc);
>  	} else {
>  		dev_err(&rproc->dev, "Unrecognised option: %s\n", buf);
>  		ret =3D -EINVAL;
> --

Reviewed-by: Peng Fan <peng.fan@nxp.com>