Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp286125pxu; Thu, 15 Oct 2020 04:06:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyif/lqcg6NAk/G/MNVCWM4+PDdBwusXjr/hlqf/nRHZOibB/zmpCcvUElUMCtndTb1v9HJ X-Received: by 2002:a05:6402:21c5:: with SMTP id bi5mr3860481edb.380.1602759977696; Thu, 15 Oct 2020 04:06:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602759977; cv=none; d=google.com; s=arc-20160816; b=nneM/wiTfh1oUci+Fxafyz2GZ8m74QQ/9sSv4Rnkss6J1+uwcCrefBCvuN2hGzbNTb tw/hOIn8EfzPYYkgny18WTAa4VJY9PZyZD+hkFALcldXEHc7fchAvzN6eDREXUhmCzCZ v/2uGvkE4Ju4uNbzCXNRd0TqFb6drDPa3ZH/0UQOOLOVOpTis2vsiTL60I3qNSa4MEmO 8kmYT4J/f8OjKs+ASQ7bu3fTWalrQ3KoibnXeuCXoGch8M8ddWn3aarDJ3R1Tdx8T74b wot+RG0Xp5zS/genB8c2hzHYpSD3/r5yiRs3Tc6kGqvYAw6jtusJi+V41LXPDkC9ZvJD GzWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Fh7RBjR4gWJAcXHXeFIXuxtprpG5sdnXQMpcASE4DN0=; b=uDB5Q1//IET1a457TBoNx4Td0hDpskPh6V6g41n0QJSnsZeltwXf6puB909ojWAx56 NIiWiWK5XvOjHL9z5tXV30HCPeOr0EsuYD7O2fW7GME/SAZmS+t/rJr6veGzriV9iJLV KT06YbLx58iMqRspVQmd9/odv0iBipZFTBZzieaVKvFftHBQzeRskRJz8gErDn5wYDoy F2Ifg/ISyiw2JHbcDT9+s4g+ePdpM9JMqfnPWrA0e5ha838kBnHHV3dSuAIBDlgi55p4 e2NJeo21syjvphwTf+Cjvq2+3CnmptIctCpjtgFpuj2bavuqaCaCG04wb9m3GlNLmgVD 8FWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=YdcSBxFc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h18si1761397ejl.297.2020.10.15.04.05.55; Thu, 15 Oct 2020 04:06:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=YdcSBxFc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728598AbgJOGnn (ORCPT + 99 others); Thu, 15 Oct 2020 02:43:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725208AbgJOGnn (ORCPT ); Thu, 15 Oct 2020 02:43:43 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08409C061755; Wed, 14 Oct 2020 23:43:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Fh7RBjR4gWJAcXHXeFIXuxtprpG5sdnXQMpcASE4DN0=; b=YdcSBxFc1sJyff9DT3WX6ebAk1 YqKc24tKHSkGeQrJ/mNIYdAdFYn78PdoVQ/No8o354uaBUU6+y7HZtjF4pLBt8cczoCeRgdjL6TUr pm2q4R+VSV2ok2dhEvSe4t5jfGc2MaPGeLPxT31xKOrxSCmEGA8fyci2VyvIghe1y8K2VkSeYBkyj gmqjvZmiTw+Hg1blKMOtYp1OivN/YBMRG6xRv2CyCDSAYKUShqj+CnyXQ8VXpofMpUzsUWQIA7GjG BjJYSVVUDbTQdHG+54Oq0NQem6dhiV+72RpiTwNTU56CY9hkqZ1QCH4Sk3rRSh1/qVPyQKHDYKsxl bwkXikuQ==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSwz3-0003TV-Kj; Thu, 15 Oct 2020 06:43:29 +0000 Date: Thu, 15 Oct 2020 07:43:29 +0100 From: Christoph Hellwig To: "Kuppuswamy, Sathyanarayanan" Cc: Christoph Hellwig , sathyanarayanan.nkuppuswamy@gmail.com, bhelgaas@google.com, okaya@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, ashok.raj@intel.com, Keith Busch Subject: Re: [PATCH v4 2/2] PCI/ERR: Split the fatal and non-fatal error recovery handling Message-ID: <20201015064329.GA12987@infradead.org> References: <5c5bca0bdb958e456176fe6ede10ba8f838fbafc.1602263264.git.sathyanarayanan.kuppuswamy@linux.intel.com> <20201013115600.GA11976@infradead.org> <2fa2e5ed-dbfb-f335-5429-8bbb13f004e2@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2fa2e5ed-dbfb-f335-5429-8bbb13f004e2@linux.intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 13, 2020 at 08:17:39AM -0700, Kuppuswamy, Sathyanarayanan wrote: > > > On 10/13/20 4:56 AM, Christoph Hellwig wrote: > > You might want to split out pcie_do_fatal_recovery and get rid of the > > state argument: > This is how it was before Keith merged fatal and non-fatal error recovery > paths. When the comparison is between additional-parameter vs new-interface > , I choose the former. But I can merge your change in next version. But now you split the implementation. Keith merged made complete sense when the code was mostly identical. But now that the code is separate again it doesn't make sense to hide it under a common interface that uses a flags value to call different functions.