Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp323956pxu; Thu, 15 Oct 2020 05:05:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywFzIQq7m7aGFdX4EMjxZRxgsLrOEvVP8pjSoxFS984+oouUKK8Pqbuua3uzU+5Rg9bck5 X-Received: by 2002:a05:6402:195:: with SMTP id r21mr3923698edv.164.1602763503607; Thu, 15 Oct 2020 05:05:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602763503; cv=none; d=google.com; s=arc-20160816; b=bR4FAGNnssfF6d5Oxw9Ejx+gboHpRR7El7AjsfXH6WqUZ7HvNSQB5CrqOEp7tO4rIY zgCW/fjgMfg8dUoX8WlKqLCgUntT2qjo3h9B8zN4m9HWv6NE8lGhjD+vsZ7GbpfNRdvC Y2dZfqGJnCLhLllWR3LoZPOSJsRVU7dd7QNcCRzu/NSdpbC1gQxbDXH7BN47Mr8urhp8 LDrmCHqVDC63c946S3jFyiQq4GTrt4wIGrBqrXjWEH9Rwgl92RZgRyxOskmwFy0XxGsF OO8CpX8wR6LJwVUskLv7Ksou4iPU3q0AcrgLQ0STJupAbtO5RVomD9GBSo0wSiReKQgk KhQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=gVyg09n03RAD6Nsv9fxaQ7MGpUm3qJlZbGsaBv8b2Ok=; b=t68yU480YpYeWQbw9MPHpHghsWhdSZYNsUEEudCj7hyedh+Z+510rUh/Aquo6EmjH4 JXspzkU5XKzCf/VmCDYI8C12x6zUqLbL9LG95iMXat/vxSf3M+Q5C/e13iwnOtgI9c1a /F0sKNsc630NQxVn9bQAMjPYoPPHSI+r0d3BfF8BtKjIpjk6oCRAIiakKYu/ZE2TWrCl Q0Pslmb6lWcXzcOJBWTL3l3CW8J+Azvb6Pof88s+au/B02homvLtob29UZvfwIAojJee 80ouawXpolk1ex7fHPTtaSe8nyLFX1eOwNfxJD7L24lOAG7bF8JeJEWo2Ruc/CLVhtiP yILg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k22si1870922edr.463.2020.10.15.05.04.35; Thu, 15 Oct 2020 05:05:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726692AbgJOKuH (ORCPT + 99 others); Thu, 15 Oct 2020 06:50:07 -0400 Received: from mga02.intel.com ([134.134.136.20]:10477 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726019AbgJOKuH (ORCPT ); Thu, 15 Oct 2020 06:50:07 -0400 IronPort-SDR: PWZsg1gTud0v72FYPadAcSHLG3n6z3eVlcDoz6GmB0dEkQKoln1e4o9+uzWp35G8vSdc+cJK4y +gjbMLrgwGYw== X-IronPort-AV: E=McAfee;i="6000,8403,9774"; a="153246165" X-IronPort-AV: E=Sophos;i="5.77,378,1596524400"; d="scan'208";a="153246165" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2020 03:50:07 -0700 IronPort-SDR: XRJgxpgsxB4D8wBiqZnKJX82Bk4f1AUWT+2R8p9xT6iB3rw/VzqF/BhBLRPBXaIElicUARBrwz Ddg00+IephIg== X-IronPort-AV: E=Sophos;i="5.77,378,1596524400"; d="scan'208";a="330757409" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2020 03:50:03 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kT0qf-007N8B-4h; Thu, 15 Oct 2020 13:51:05 +0300 Date: Thu, 15 Oct 2020 13:51:05 +0300 From: Andy Shevchenko To: Vitor Massaru Iha Cc: kunit-dev@googlegroups.com, brendanhiggins@google.com, elver@google.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org, gregkh@linuxfoundation.org, tglx@linutronix.de, geert@linux-m68k.org, paul.gortmaker@windriver.com, akpm@linux-foundation.org, torvalds@linux-foundation.org, arnd@arndb.de, elfring@users.sourceforge.net, mhocko@suse.com Subject: Re: [PATCH v2] lib: kunit: add list_sort test conversion to KUnit Message-ID: <20201015105105.GS4077@smile.fi.intel.com> References: <20201015014616.309000-1-vitor@massaru.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201015014616.309000-1-vitor@massaru.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 14, 2020 at 10:46:16PM -0300, Vitor Massaru Iha wrote: > This adds the conversion of the runtime tests of test_list_sort, > from `lib/test_list_sort.c` to KUnit tests. Please, provide better commit message. For example, add the output of _succeeded_ *and* _failed_ test cases (yes, you have to break code manually to reproduce failed test cases) _before_ *and* _after_ the change. W/o above information I'm going to NAK this as I promised before. -- With Best Regards, Andy Shevchenko