Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp440007pxu; Thu, 15 Oct 2020 07:46:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwrVLxb0VH5pmonc1qDHEnGU9dd76segp4ZfCuCTlMd0cydV/EgLknDQN8hG+dW41vf11s5 X-Received: by 2002:a17:906:f8ca:: with SMTP id lh10mr4592184ejb.528.1602773191384; Thu, 15 Oct 2020 07:46:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602773191; cv=none; d=google.com; s=arc-20160816; b=miSUiwGkQff5KIB5zHPYfz53hq5pZimaMpKmh7A4VCSmuBORXmf55eUgbGksKvw8C0 V950eTLn0mRj5TmWzIw8tf7vAuBGftTreY+JEs2cUCOK1vt1tgwcTz0jtI0c8+VU0RG3 yTiqXloATtZyqrMUEZxVQvrr8Bu5G6J6n1QSp9zGkvKXzHtLYO6+L1OI0FDssS2fYXKz fjDJiGtzq61pc/xYxEznxLy/c2oTpHtllPPX7m1jb9C1EjTwlCIZDQCz+B/fDt46xOf9 V2mj7b4QeMtGhRX0MxfBRcufcPEFMIdbxMmMBg4GhdfKuyNNSmjTYgHY4WI86qUVN9YU eTvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=MeShlhmQePzhYrhnxCh1xoXkzKIrQ+wwpOnr+ODxTdg=; b=OwS96YYF3tUWUNcIiU/Ld7MN1KwGqE8HKMUBZfo6Dk21W1hQifFMtZaTQPP5kRsUFG 2rFlGgc+LIXhtu1GjHow0+3xLlEjhRCnrUYtflulZ3cRckk0MBNgnuDNDZm+lyXVjYCa g4NltRYyd6jNREtAfaJkoMDp1FtRLdPkrS4JNhO10q1/ElsZQPnJPJhuWFKVIUSL9tPi T/mSOXfYIgc4qA2qlkd0o9h86B3EUMVzyQH+LKRpugcz0cjeYkP6tQKrJWxqBR2HBL+y IRdBOq/lKKSKLH9BBZUKp68P3O9i+KG3OdCno9nsQgpGUetF71r14w3GXclD6bIF6C7o 2/nw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OpxsRmzl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gu20si2317895ejb.343.2020.10.15.07.46.02; Thu, 15 Oct 2020 07:46:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OpxsRmzl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388778AbgJOOo2 (ORCPT + 99 others); Thu, 15 Oct 2020 10:44:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:59917 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726925AbgJOOo2 (ORCPT ); Thu, 15 Oct 2020 10:44:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602773067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MeShlhmQePzhYrhnxCh1xoXkzKIrQ+wwpOnr+ODxTdg=; b=OpxsRmzlrjdJclPDE7L7xSNl5BBU3a4agVTPqGsMAlM9Wz8Q49yHij7zpefQdjcoWaXRNX /NPoYCkdf95OHfbGBOoWCHCc5wIOeD8F7enTCtI1/Wwzqfd2a6fmvRkU0ODfaOtwAcASY8 6p+gglVZEnj3XWliRvUIOrmt8Gju+RQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-5-TMBvXjXNOy2CHsx_NNFUqQ-1; Thu, 15 Oct 2020 10:44:23 -0400 X-MC-Unique: TMBvXjXNOy2CHsx_NNFUqQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 70917107AFAF; Thu, 15 Oct 2020 14:44:22 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.40.193.8]) by smtp.corp.redhat.com (Postfix) with SMTP id 007BB6EF72; Thu, 15 Oct 2020 14:44:20 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Thu, 15 Oct 2020 16:44:22 +0200 (CEST) Date: Thu, 15 Oct 2020 16:44:19 +0200 From: Oleg Nesterov To: Jens Axboe Cc: linux-kernel@vger.kernel.org, io-uring@vger.kernel.org, peterz@infradead.org, tglx@linutronix.de Subject: Re: [PATCH 3/5] kernel: add support for TIF_NOTIFY_SIGNAL Message-ID: <20201015144419.GH24156@redhat.com> References: <20201015131701.511523-1-axboe@kernel.dk> <20201015131701.511523-4-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201015131701.511523-4-axboe@kernel.dk> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/15, Jens Axboe wrote: > > This adds TIF_NOTIFY_SIGNAL handling in the generic code, which if set, > will return true if signal_pending() is used in a wait loop. That causes > an exit of the loop so that notify_signal tracehooks can be run. If the > wait loop is currently inside a system call, the system call is restarted > once task_work has been processed. > > Signed-off-by: Jens Axboe So I strongly disagree with CONFIG_GENERIC_ENTRY. Otherwise, Reviewed-by: Oleg Nesterov