Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp452529pxu; Thu, 15 Oct 2020 08:04:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLVh+PlTD+gzDvRZ2KWWerYdABK326Xm9FKY324qRdIOGQ0m5zPF1qxeKYCFNwceOO9CK1 X-Received: by 2002:a17:906:3a97:: with SMTP id y23mr4981003ejd.250.1602774245145; Thu, 15 Oct 2020 08:04:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602774245; cv=none; d=google.com; s=arc-20160816; b=X50KEKUhP1LOufPQilQr4NG8TzgcSso97LmrXB+sKBV3m66+65/e0w2q4ka057UfHf bd11ZoqTgjRcgEhzUzuyrTNfnBS9Cjk2qYN7gUqMUk1I2fLZ5Ii1BsSu2Y0d2U4tkULq t+mJA3LQiDYhRN00doyi360tk2ULIkIBHy04fZs1sYi1v4tMMp/eEB/2yKN8M14zCCfI HynMcWQwsRAAtxI47K8/UkyHwhAlS0CLnWnUdgBaYNq/j/eg7Y1meG0WzJi7tHceHk9e vxsdZJ7VYV19OOH7zgGB/xXNSwIldPbu7nnMw5nBNr6PuM8VgyeL90aRJxUXwBvzVgiV /iFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=+DuzvGKr+uouQPicd3btzTpBKj/5LVLg1yi/nXnEH1M=; b=iLLdqO0cnpcM8PLqhhQcKEa/uKcuTiKD0kpv6LJ4puSRaiBGAZ6RW9q7DyyQdRaFmv PeTDjiGOY5tfQO67oAYFXvdH90cgQUJUvU5eRiLG+rCrmkF7HM7wis+pmFqhYHaWUhUd v/hR5WUFAhTtHYF0OGW59F/kEjKD+NJO6AAQI2tR1iCjJELh14myfpdE7+7QP6QtYcS3 aSAoVEBtSV7gFTFEM7DP1wnHD1XqfNcQ4gK9i0bnt2dwRQ3dBNO7Mhf+Wcpf/yxh2XP0 xqpUeknxW6WMKhGT49FNSLFz9Kdiw4ZDTod9uEqstd2swic1ht51AfOF9hIAsqf63cR9 9AXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="mDMRS/8E"; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cy8si2095829edb.527.2020.10.15.08.03.28; Thu, 15 Oct 2020 08:04:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="mDMRS/8E"; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389051AbgJOPBP (ORCPT + 99 others); Thu, 15 Oct 2020 11:01:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388086AbgJOPBP (ORCPT ); Thu, 15 Oct 2020 11:01:15 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2ADCC061755; Thu, 15 Oct 2020 08:01:14 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1602774073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+DuzvGKr+uouQPicd3btzTpBKj/5LVLg1yi/nXnEH1M=; b=mDMRS/8Et7iVSKGXRG0qPg3GpdinFibrmtscDezhbH4liiBttp5q78MM84WhBgjcFM4KBm 0R5bGiuJFiP5vgDnebSITaFljWa/pXVPjUrWBfh7/4r8R8dNAzTD/ZQlRKPTKioFp/X0Rm Ufkt9ooD/LPSdrmUJn6f6WXi8jyhW2aT+/ZptAj7EFdKGTbcN6TXDSelPUTUppAv4cwnNY 3zo7Q8rYY6d6AdTejhqVtBnbBGBE6hx8g0MjOckTt7CztrqBVskc149aCzprowHXwhdNEA fSNZrALNGPCepVpCjULiys/SxRN+tMGR1FiWMWojXoB1r8H/8+E0cI71zu35rQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1602774073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+DuzvGKr+uouQPicd3btzTpBKj/5LVLg1yi/nXnEH1M=; b=eztVgQEYp+HzQIkMh71WxUwdkCYIhvU3k+Rlk0GbSO0yB7CAcXf9YgE65sVh7V59zpNRIm HQbLwiakXwA2LUBA== To: Oleg Nesterov , Jens Axboe Cc: linux-kernel@vger.kernel.org, io-uring@vger.kernel.org, peterz@infradead.org Subject: Re: [PATCH 3/5] kernel: add support for TIF_NOTIFY_SIGNAL In-Reply-To: <20201015143728.GE24156@redhat.com> References: <20201015131701.511523-1-axboe@kernel.dk> <20201015131701.511523-4-axboe@kernel.dk> <20201015143151.GB24156@redhat.com> <5d231aa1-b8c7-ae4e-90bb-211f82b57547@kernel.dk> <20201015143728.GE24156@redhat.com> Date: Thu, 15 Oct 2020 17:01:13 +0200 Message-ID: <87r1pzv8hy.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 15 2020 at 16:37, Oleg Nesterov wrote: > On 10/15, Jens Axboe wrote: >> On 10/15/20 8:31 AM, Oleg Nesterov wrote: >> > I don't understand why does this version requires CONFIG_GENERIC_ENTRY. >> > >> > Afaics, it is very easy to change all the non-x86 arches to support >> > TIF_NOTIFY_SIGNAL, but it is not trivial to change them all to use >> > kernel/entry/common.c ? >> >> I think that Thomas wants to gate TIF_NOTIFY_SIGNAL on conversion to >> the generic entry code? > > Then I think TIF_NOTIFY_SIGNAL will be never fully supported ;) Yeah, we proliferate crap on that basis forever. _ALL_ architectures have the very same entry/exit ordering problems (or subsets and different ones) which we fixed on x86. So no, we don't want to have 24 different variants of the same thing again. That's what common code is for. Not doing that is making the life of everyone working on core infrastructure pointlessly harder. Architecture people still have enough ways to screw everyone up. Thanks, tglx