Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 15 Oct 2020 23:04:48 +0800
From:   Leo Yan <leo.yan@linaro.org>
To:     Joe Mario <jmario@redhat.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Andi Kleen <ak@linux.intel.com>,
        David Ahern <dsahern@gmail.com>,
        Don Zickus <dzickus@redhat.com>, Al Grant <Al.Grant@arm.com>,
        James Clark <james.clark@arm.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/8] perf c2c: Refine the organization of metrics
Message-ID: <20201015150448.GB462@leoy-ThinkPad-X240s>
References: <20201014050921.5591-1-leo.yan@linaro.org>
 <79f2db37-a03f-c01f-0b3b-4e2d3ed429f4@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <79f2db37-a03f-c01f-0b3b-4e2d3ed429f4@redhat.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

Hi Joe,

On Wed, Oct 14, 2020 at 02:38:19PM -0400, Joe Mario wrote:

[...]

> > This patch set is to refine metrics output organization.

[...]

> Hi Leo:
> I ran your patches through some perf c2c tests and it all looks good.  
> I agree the new format of the "Shared Data Cache Line Table" makes more sense now.  And it still holds together nicely when sorted on local HitMs (-d lcl).
> 
> Thank you for doing this.
> Joe
> 
> Tested-by: Joe Mario <jmario@redhat.com>

Thank you for quick response and testing.

I share the same thinking with Jiri that we should respect the existed
usages and habits of the tool, I was also a bit concern that my changes
might introduce inconvinence for others.  But it's great that receive
your agreement for the changes!

I have respinned the patch set v2 [1] with adding your test tag and
updated documentation; furthermore, I sent out another patch set for
enhancement perf c2c with sorting on LLC load hit, you are welcome to
reivew and comment on it [2].

Thanks,
Leo

[1] https://lore.kernel.org/patchwork/cover/1321499/
[2] https://lore.kernel.org/patchwork/cover/1321514/