Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp578438pxu; Thu, 15 Oct 2020 11:00:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxMs7sC0txZbK8BCqH1ETlBEMzgP6as33Gda3qmITTTYC3Mh2oO4779OeY2VQ/m5YLi7sDz X-Received: by 2002:aa7:c451:: with SMTP id n17mr5490676edr.266.1602784851821; Thu, 15 Oct 2020 11:00:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602784851; cv=none; d=google.com; s=arc-20160816; b=srLvoSl7WZDzF/btH5aDWnyjCqtTg1Z6wFk2mqrTp1FHjqyvZJCoaqbWam7FoCxA/L lMZpsPiokpKJjdf4OR3luVELTBHx4X84lEZn9opYC7lyaistxEKKuWRp+gA1dWB/9b/2 PGnFOJprFGcqxWwmT2PDRJSnX3uEjEB6uLBKQJJsmjHZOu8UVWWUFBYcEHc9UKhlV9ng QQFKhbgTv6hRzokLGpXQrWKSDq10DCk0QwQ7mTFRJoxRjyM59cKZJfoCf64oKQZTk/zg UcQTeXW5PxDI5S0UQCYQJPDmxN9DgOcOQg3Qi9veK7C0NzroPKLdB3/7v2FcPiXR6RIc NQEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=UEDAxbK12unAlS0H5ou1pR8JIF/E3aFY8NK/xYdYeus=; b=TqOGV47D95iiLEDLSzz7qgk5CdWalFYT/7xYZWsn48L6aHH4rbiJzL7+06Hv0mWyiH byuWgieAezEZO7Wy1+LvcoVIp5RlcBorXWaZExRh8tHgAy3xlFTeAD7DiHiYxze+lw+j gB0oItewcEwRuEB2qa5qD3c6I2NsT3nNF4gFkokZ+/OiiiaKl2mykE2fxVcROAJJGzfH Lt5nZv/ucrB7VZ8Q7EAh8xcYgCdF5g5AQx5ciGrsGm/OMjpiJHxzeBHWIaQRvwP/UE4z ww8uEJEzC55r4Z6rSmT0DgHiLrFJ0T521fl8JjejRSlTPhAY//9g4nJuYgu++8EZljDz 0V+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q12si2570331ejs.146.2020.10.15.11.00.18; Thu, 15 Oct 2020 11:00:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726299AbgJOMQE (ORCPT + 99 others); Thu, 15 Oct 2020 08:16:04 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:15219 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726103AbgJOMQE (ORCPT ); Thu, 15 Oct 2020 08:16:04 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id BB12D79062E39210F1E9; Thu, 15 Oct 2020 20:16:00 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Thu, 15 Oct 2020 20:15:51 +0800 From: Shijie Luo To: CC: , , , , Subject: [PATCH] mm: fix potential pte_unmap_unlock pte error Date: Thu, 15 Oct 2020 08:15:34 -0400 Message-ID: <20201015121534.50910-1-luoshijie1@huawei.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When flags don't have MPOL_MF_MOVE or MPOL_MF_MOVE_ALL bits, code breaks and passing origin pte - 1 to pte_unmap_unlock seems like not a good idea. Signed-off-by: Shijie Luo Signed-off-by: linmiaohe --- mm/mempolicy.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 3fde772ef5ef..01f088630d1d 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -571,7 +571,11 @@ static int queue_pages_pte_range(pmd_t *pmd, unsigned long addr, } else break; } - pte_unmap_unlock(pte - 1, ptl); + + if (addr >= end) + pte = pte - 1; + + pte_unmap_unlock(pte, ptl); cond_resched(); if (has_unmovable) -- 2.19.1