Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp580410pxu; Thu, 15 Oct 2020 11:03:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyiZtERLelOjHy4Z07X/GQDAd9f2B2XQCfBeJSU/tpMR+JRF/GIpYiPJ03l/Vs3wFfCcVR7 X-Received: by 2002:a1c:4604:: with SMTP id t4mr12032wma.95.1602785009271; Thu, 15 Oct 2020 11:03:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602785009; cv=none; d=google.com; s=arc-20160816; b=LRxHXIFJK7ssFVzLZAcpJoS6slMHc+TIS8xWZE7VGwMHhuAUB7Chk7M7To/kv5835f duwpodvKV8kLBj9uKut1pAE185onkoRFAvllcgzQGAf7qrw7qtcFYiMtayrNu9STlHZd upUNGGeizWvd/g3VuvWhY5Gpnd/B1+2MN/WaWzq3vcJxSvT/KTZV2TPkID1qiMSTztbp QiMJuoEt9IetGyRuZxPismkSj1Qd61mlotROswskMCRJk4iCNYSxNGFFigzfFV3zjvxE /hpeFgc1pV5XrbX1Kjg9dgK7qMgJQRZWLVCRy4HQaBNsNy0gF+BbRaj30ptjqcpoEv4E C5Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=L/AKCyiEi7KAA5xRX7k+4+OgGpcFSgryY4yaW9+Z7eI=; b=alEZP3n1qL9ufyC5rMI1ulJWRNSjhLjAXjbxCFUfDw3MYc6bJPVLZ+jjW/8ong6cQC CxmpL/Ud8rROQvatjqhTGGwrLv+WMRX6rIIGyOsxU2js8HKI5By1L1BmmhG1803Imci1 qlsB5oiEHMOgxcfZxwF8uaET7L3J/6RXARbakSkXA1J2PAts7TkECorIvjy4KJQjxkQE Qr3h2mEvDI8icCbG6eS8pI55a/vbaEu4CuMS0dwmMwxvtYS1JuU9D7KttGlG99Wmu/iI phmlpNxSCyY886yiS643gFEYD4DZVTVVIdsCQYYZFRpExbHacnKZEyMpevjwPnI7OZZJ alLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ma63it46; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bx11si2680527ejb.319.2020.10.15.11.02.48; Thu, 15 Oct 2020 11:03:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ma63it46; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731214AbgJORee (ORCPT + 99 others); Thu, 15 Oct 2020 13:34:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:43468 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731190AbgJORee (ORCPT ); Thu, 15 Oct 2020 13:34:34 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 51DFC2225F; Thu, 15 Oct 2020 17:34:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602783274; bh=DNxvAuV7cKNsPEncClCJJJ0vr4kkwu9AJqh2X91MJ+I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ma63it46MNeYoPlFyYS5c1K5Cr4yl4b0mvpITcv+TdQSvEqmopd6R4HZanFaS0Ga3 Sg9uHJdGQ51/ZZRXYNcxvJph/r1CpZQxyJWJzJhM7/JtRPWs7mYClAwKFR7Swjx7/8 48jSLBH9u8JSFCL2ndfp0McKVKoUbsT8Lq397YIg= Date: Thu, 15 Oct 2020 10:34:31 -0700 From: Jakub Kicinski To: Henrik Bjoernlund Cc: , , , , , , , , , Horatiu Vultur Subject: Re: [PATCH net-next v6 07/10] bridge: cfm: Netlink SET configuration Interface. Message-ID: <20201015103431.25d66c8b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201015115418.2711454-8-henrik.bjoernlund@microchip.com> References: <20201015115418.2711454-1-henrik.bjoernlund@microchip.com> <20201015115418.2711454-8-henrik.bjoernlund@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Oct 2020 11:54:15 +0000 Henrik Bjoernlund wrote: > + [IFLA_BRIDGE_CFM_MEP_CONFIG_MDLEVEL] = { > + .type = NLA_U32, .validation_type = NLA_VALIDATE_MAX, .max = 7 }, NLA_POLICY_MAX(NLA_U32, 7) Also why did you keep the validation in the code in patch 4?