Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Ioana Ciornei <ioana.ciornei@nxp.com>
To:     Randy Dunlap <rdunlap@infradead.org>
CC:     Jose Abreu <Jose.Abreu@synopsys.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: linux-next: Tree for Oct 15 (drivers/net/pcs/pcs-xpcs.o)
Thread-Topic: linux-next: Tree for Oct 15 (drivers/net/pcs/pcs-xpcs.o)
Thread-Index: AQHWowIM9GlE3TKOm0uVxOyhfasoWqmYw5AAgAAgOwCAAA0YAIAABM6A
Date:   Thu, 15 Oct 2020 18:06:08 +0000
Message-ID: <20201015180607.xtackyvta7nsiwzh@skbuf>
References: <20201015182859.7359c7be@canb.auug.org.au>
 <e507b1ec-a3ae-0eaa-8fed-6c77427325c3@infradead.org>
 <BN6PR12MB17798590707177F08FD60653D3020@BN6PR12MB1779.namprd12.prod.outlook.com>
 <20201015170204.bnnpgogczjiwntyc@skbuf>
 <3418cac1-eff7-d06a-6ba7-9877f0f266e9@infradead.org>
In-Reply-To: <3418cac1-eff7-d06a-6ba7-9877f0f266e9@infradead.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1C7AF28C101C3442B233B720E25CC119@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 079e671d-9ce3-49b3-3d66-08d87134fdc7
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2020 18:06:08.1716
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ArIP59zNRMqPkHcUTxGiZpYYH5v/ogElzbL4XLiWNZtkiAWBxZqirMfnD+bXMJOVnqwsuFgxWy/WgGeKeKw/gg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4029
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 15, 2020 at 10:48:56AM -0700, Randy Dunlap wrote:
> On 10/15/20 10:02 AM, Ioana Ciornei wrote:
> > On Thu, Oct 15, 2020 at 03:06:42PM +0000, Jose Abreu wrote:
> >> From: Randy Dunlap <rdunlap@infradead.org>
> >> Date: Oct/15/2020, 15:45:57 (UTC+00:00)
> >>
> >>> On 10/15/20 12:28 AM, Stephen Rothwell wrote:
> >>>> Hi all,
> >>>>
> >>>> Since the merge window is open, please do not add any v5.11 material=
 to
> >>>> your linux-next included branches until after v5.10-rc1 has been rel=
eased.
> >>>>
> >>>> News: there will be no linux-next releases next Monday or Tuesday.
> >>>>
> >>>> Changes since 20201013:
> >>>>
> >>>
> >>> on i386:
> >>>
> >>> ld: drivers/net/pcs/pcs-xpcs.o: in function `xpcs_read':
> >>> pcs-xpcs.c:(.text+0x29): undefined reference to `mdiobus_read'
> >>> ld: drivers/net/pcs/pcs-xpcs.o: in function `xpcs_soft_reset.constpro=
p.7':
> >>> pcs-xpcs.c:(.text+0x80): undefined reference to `mdiobus_write'
> >>> ld: drivers/net/pcs/pcs-xpcs.o: in function `xpcs_config_aneg':
> >>> pcs-xpcs.c:(.text+0x318): undefined reference to `mdiobus_write'
> >>> ld: pcs-xpcs.c:(.text+0x38e): undefined reference to `mdiobus_write'
> >>> ld: pcs-xpcs.c:(.text+0x3eb): undefined reference to `mdiobus_write'
> >>> ld: pcs-xpcs.c:(.text+0x437): undefined reference to `mdiobus_write'
> >>> ld: drivers/net/pcs/pcs-xpcs.o:pcs-xpcs.c:(.text+0xb1e): more undefin=
ed references to `mdiobus_write' follow
> >>>
> >>>
> >=20
> > I think this stems from the fact that PHYLIB is configured as a module
> > which leads to MDIO_BUS being a module as well while the XPCS is still
> > built-in. What should happen in this configuration is that PCS_XPCS
> > should be forced to build as module. However, that select only acts in
> > the opposite way so we should turn it into a depends.
> >=20
> > Is the below patch acceptable? If it is, I can submit it properly.
>=20
> Hi,
> Did you copy-paste this patch?  It contains spaces instead of tabs
> so it doesn't apply cleanly/easily, but I managed to apply and test it, s=
o
>=20

Yes, it was a quick copy-paste. Sorry for the trouble.

> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
>=20

Thanks.

Ioana=