Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Min Li <min.li.xe@renesas.com>
To:     Min Li <min.li.xe@renesas.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net 2/4] ptp: ptp_idt82p33: add more debug logs
Thread-Topic: [PATCH net 2/4] ptp: ptp_idt82p33: add more debug logs
Thread-Index: AQHWbNOFfZDtT11nNU+wHU0tO2aeC6mZea3Q
Date:   Thu, 15 Oct 2020 19:30:46 +0000
Message-ID: <OSAPR01MB1780733AA3B25A528A76F8F2BA020@OSAPR01MB1780.jpnprd01.prod.outlook.com>
References: <1596815868-11045-1-git-send-email-min.li.xe@renesas.com>
In-Reply-To: <1596815868-11045-1-git-send-email-min.li.xe@renesas.com>
Accept-Language: en-CA, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: b87be427-dc0e-46b3-7e0e-08d87140d0bb
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2020 19:30:46.5000
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nPA8SUmKZRtSV+AdD7/fNpvsUAxhcEA7wofooDxVkB3Ph95W00vJ3X5MabAvJ/axuhHXDyQcKLYbHv4ee9T8lQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSBPR01MB2583
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi David/Richard

When you have time, can you take a look at this change? Thanks

Min

-----Original Message-----
From: min.li.xe@renesas.com <min.li.xe@renesas.com>=20
Sent: August 7, 2020 11:58 AM
To: richardcochran@gmail.com
Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Min Li <min.li.xe=
@renesas.com>
Subject: [PATCH net 2/4] ptp: ptp_idt82p33: add more debug logs

From: Min Li <min.li.xe@renesas.com>

Signed-off-by: Min Li <min.li.xe@renesas.com>
---
 drivers/ptp/ptp_idt82p33.c | 88 +++++++++++++++++++++++++++++++++++++++++-=
----
 1 file changed, 79 insertions(+), 9 deletions(-)

diff --git a/drivers/ptp/ptp_idt82p33.c b/drivers/ptp/ptp_idt82p33.c index =
bd1fbcd..189bb81 100644
--- a/drivers/ptp/ptp_idt82p33.c
+++ b/drivers/ptp/ptp_idt82p33.c
@@ -86,6 +86,7 @@ static int idt82p33_xfer(struct idt82p33 *idt82p33,
 	struct i2c_client *client =3D idt82p33->client;
 	struct i2c_msg msg[2];
 	int cnt;
+	char *fmt =3D "i2c_transfer failed at %d in %s for %s, at addr:=20
+%04X!\n";
=20
 	msg[0].addr =3D client->addr;
 	msg[0].flags =3D 0;
@@ -99,7 +100,12 @@ static int idt82p33_xfer(struct idt82p33 *idt82p33,
=20
 	cnt =3D i2c_transfer(client->adapter, msg, 2);
 	if (cnt < 0) {
-		dev_err(&client->dev, "i2c_transfer returned %d\n", cnt);
+		dev_err(&client->dev,
+			fmt,
+			__LINE__,
+			__func__,
+			write ? "write" : "read",
+			(u8) regaddr);
 		return cnt;
 	} else if (cnt !=3D 2) {
 		dev_err(&client->dev,
@@ -448,8 +454,13 @@ static int idt82p33_measure_tod_write_overhead(struct =
idt82p33_channel *channel)
=20
 	err =3D idt82p33_measure_settime_gettime_gap_overhead(channel, &gap_ns);
=20
-	if (err)
+	if (err) {
+		dev_err(&idt82p33->client->dev,
+			"Failed at line %d in func %s!\n",
+			__LINE__,
+			__func__);
 		return err;
+	}
=20
 	err =3D idt82p33_measure_one_byte_write_overhead(channel,
 						       &one_byte_write_ns);
@@ -613,13 +624,23 @@ static int idt82p33_enable_tod(struct idt82p33_channe=
l *channel)
=20
 	err =3D idt82p33_pps_enable(channel, false);
=20
-	if (err)
+	if (err) {
+		dev_err(&idt82p33->client->dev,
+			"Failed at line %d in func %s!\n",
+			__LINE__,
+			__func__);
 		return err;
+	}
=20
 	err =3D idt82p33_measure_tod_write_overhead(channel);
=20
-	if (err)
+	if (err) {
+		dev_err(&idt82p33->client->dev,
+			"Failed at line %d in func %s!\n",
+			__LINE__,
+			__func__);
 		return err;
+	}
=20
 	err =3D _idt82p33_settime(channel, &ts);
=20
@@ -728,6 +749,11 @@ static int idt82p33_adjfine(struct ptp_clock_info *ptp=
, long scaled_ppm)
=20
 	mutex_lock(&idt82p33->reg_lock);
 	err =3D _idt82p33_adjfine(channel, scaled_ppm);
+	if (err)
+		dev_err(&idt82p33->client->dev,
+			"Failed at line %d in func %s!\n",
+			__LINE__,
+			__func__);
 	mutex_unlock(&idt82p33->reg_lock);
=20
 	return err;
@@ -751,10 +777,19 @@ static int idt82p33_adjtime(struct ptp_clock_info *pt=
p, s64 delta_ns)
=20
 	if (err) {
 		mutex_unlock(&idt82p33->reg_lock);
+		dev_err(&idt82p33->client->dev,
+			"Failed at line %d in func %s!\n",
+			__LINE__,
+			__func__);
 		return err;
 	}
=20
 	err =3D idt82p33_sync_tod(channel, true);
+	if (err)
+		dev_err(&idt82p33->client->dev,
+			"Failed at line %d in func %s!\n",
+			__LINE__,
+			__func__);
=20
 	mutex_unlock(&idt82p33->reg_lock);
=20
@@ -770,6 +805,11 @@ static int idt82p33_gettime(struct ptp_clock_info *ptp=
, struct timespec64 *ts)
=20
 	mutex_lock(&idt82p33->reg_lock);
 	err =3D _idt82p33_gettime(channel, ts);
+	if (err)
+		dev_err(&idt82p33->client->dev,
+			"Failed at line %d in func %s!\n",
+			__LINE__,
+			__func__);
 	mutex_unlock(&idt82p33->reg_lock);
=20
 	return err;
@@ -785,6 +825,11 @@ static int idt82p33_settime(struct ptp_clock_info *ptp=
,
=20
 	mutex_lock(&idt82p33->reg_lock);
 	err =3D _idt82p33_settime(channel, ts);
+	if (err)
+		dev_err(&idt82p33->client->dev,
+			"Failed at line %d in func %s!\n",
+			__LINE__,
+			__func__);
 	mutex_unlock(&idt82p33->reg_lock);
=20
 	return err;
@@ -849,8 +894,13 @@ static int idt82p33_enable_channel(struct idt82p33 *id=
t82p33, u32 index)
 	channel =3D &idt82p33->channel[index];
=20
 	err =3D idt82p33_channel_init(channel, index);
-	if (err)
+	if (err) {
+		dev_err(&idt82p33->client->dev,
+			"Failed at line %d in func %s!\n",
+			__LINE__,
+			__func__);
 		return err;
+	}
=20
 	channel->idt82p33 =3D idt82p33;
=20
@@ -859,12 +909,22 @@ static int idt82p33_enable_channel(struct idt82p33 *i=
dt82p33, u32 index)
 		 "IDT 82P33 PLL%u", index);
=20
 	err =3D idt82p33_dpll_set_mode(channel, PLL_MODE_DCO);
-	if (err)
+	if (err) {
+		dev_err(&idt82p33->client->dev,
+			"Failed at line %d in func %s!\n",
+			__LINE__,
+			__func__);
 		return err;
+	}
=20
 	err =3D idt82p33_enable_tod(channel);
-	if (err)
+	if (err) {
+		dev_err(&idt82p33->client->dev,
+			"Failed at line %d in func %s!\n",
+			__LINE__,
+			__func__);
 		return err;
+	}
=20
 	channel->ptp_clock =3D ptp_clock_register(&channel->caps, NULL);
=20
@@ -896,8 +956,13 @@ static int idt82p33_load_firmware(struct idt82p33 *idt=
82p33)
=20
 	err =3D request_firmware(&fw, FW_FILENAME, &idt82p33->client->dev);
=20
-	if (err)
+	if (err) {
+		dev_err(&idt82p33->client->dev,
+			"Failed at line %d in func %s!\n",
+			__LINE__,
+			__func__);
 		return err;
+	}
=20
 	dev_dbg(&idt82p33->client->dev, "firmware size %zu bytes\n", fw->size);
=20
@@ -981,8 +1046,13 @@ static int idt82p33_probe(struct i2c_client *client,
 		for (i =3D 0; i < MAX_PHC_PLL; i++) {
 			if (idt82p33->pll_mask & (1 << i)) {
 				err =3D idt82p33_enable_channel(idt82p33, i);
-				if (err)
+				if (err) {
+					dev_err(&idt82p33->client->dev,
+						"Failed at %d in func %s!\n",
+						__LINE__,
+						__func__);
 					break;
+				}
 			}
 		}
 	} else {
--
2.7.4