Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201012125323.17509-1-david@redhat.com> <20201012125323.17509-9-david@redhat.com>
In-Reply-To: <20201012125323.17509-9-david@redhat.com>
From:   Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Date:   Thu, 15 Oct 2020 22:32:46 +0200
Message-ID: <CAM9Jb+gFAJh95JtFPse-4rNjabY9nS_OaN2WjbnDixTFSvAX1g@mail.gmail.com>
Subject: Re: [PATCH v1 08/29] virtio-mem: drop last_mb_id
To:     David Hildenbrand <david@redhat.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, Linux MM <linux-mm@kvack.org>,
        virtualization@lists.linux-foundation.org,
        Andrew Morton <akpm@linux-foundation.org>,
        "Michael S . Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> No longer used, let's drop it.
>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
>  drivers/virtio/virtio_mem.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
> index 37a0e338ae4a..5c93f8a65eba 100644
> --- a/drivers/virtio/virtio_mem.c
> +++ b/drivers/virtio/virtio_mem.c
> @@ -84,8 +84,6 @@ struct virtio_mem {
>
>         /* Id of the first memory block of this device. */
>         unsigned long first_mb_id;
> -       /* Id of the last memory block of this device. */
> -       unsigned long last_mb_id;
>         /* Id of the last usable memory block of this device. */
>         unsigned long last_usable_mb_id;
>         /* Id of the next memory bock to prepare when needed. */
> @@ -1689,8 +1687,6 @@ static int virtio_mem_init(struct virtio_mem *vm)
>         vm->first_mb_id = virtio_mem_phys_to_mb_id(vm->addr - 1 +
>                                                    memory_block_size_bytes());
>         vm->next_mb_id = vm->first_mb_id;
> -       vm->last_mb_id = virtio_mem_phys_to_mb_id(vm->addr +
> -                        vm->region_size) - 1;
>
>         dev_info(&vm->vdev->dev, "start address: 0x%llx", vm->addr);
>         dev_info(&vm->vdev->dev, "region size: 0x%llx", vm->region_size);

Reviewed-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>