Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 16 Oct 2020 09:25:47 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To:     Minchan Kim <minchan@kernel.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>, rajekumar@google.com,
        amosbianchi@google.com, joaodias@google.com,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH] zram: support a page writeback
Message-ID: <20201016002547.GA2412725@google.com>
References: <20201012071452.1613131-1-minchan@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201012071452.1613131-1-minchan@kernel.org>
Precedence: bulk

On (20/10/12 00:14), Minchan Kim wrote:
>  
>  With the command, zram writeback idle pages from memory to the storage.
>  
> +If admin want to write a specific page in zram device to backing device,
> +they could write the page index into the interface.
> +
> +	echo 1251 > /sys/block/zramX/writeback
> +

May be we can make it more explicit?

	echo "page_index=123" > /sys/block/zramX/writeback

Just in case of future extensions. E.g. someone might want to
have something like

	echo "idle_nr=123" > /sys/block/zramX/writeback

which would write_back 123 idle pages max.

	-ss