Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201005130128.3430804-1-poeschel@lemonage.de> <20201005130128.3430804-20-poeschel@lemonage.de>
In-Reply-To: <20201005130128.3430804-20-poeschel@lemonage.de>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Fri, 16 Oct 2020 05:25:47 +0200
Message-ID: <CANiq72kaDBJX5mc8UwrzdTs7my_Eb96o5bU6v-+FQ5wydmw6pQ@mail.gmail.com>
Subject: Re: [PATCH v4 32/32] auxdisplay: add a driver for lcd2s character display
To:     Lars Poeschel <poeschel@lemonage.de>
Cc:     open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Oct 5, 2020 at 3:01 PM <poeschel@lemonage.de> wrote:
>
> +       while (*esc && i < LCD2S_CHARACTER_SIZE + 2) {
> +               shift ^= 4;
> +               if (*esc >= '0' && *esc <= '9') {
> +                       value |= (*esc - '0') << shift;
> +               } else if (*esc >= 'A' && *esc <= 'Z') {
> +                       value |= (*esc - 'A' + 10) << shift;
> +               } else if (*esc >= 'a' && *esc <= 'z') {
> +                       value |= (*esc - 'a' + 10) << shift;

This should also probably use hex_to_bin() or similar (see my other
comment on patch 24) and/or share the implementation as much as
possible.

Cheers,
Miguel