Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp971632pxu; Thu, 15 Oct 2020 23:46:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykfZlu6mAAH7BS5ekbft3/BdRFU2VzpKHjjOs2sGvsGtyYmuSmvIYsvQ3IhyonVNwOvrSM X-Received: by 2002:a50:cbc7:: with SMTP id l7mr2234384edi.148.1602830787941; Thu, 15 Oct 2020 23:46:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602830787; cv=none; d=google.com; s=arc-20160816; b=a0pxj9ZC/Q/jEfqeZIU4YgwR0heP9uHHpMQguxNfaKFhIMhGUA7xUoyUcIaObJFSR/ FlJjLa9KEpGLVu/5lUlOcgG8Sv9nCcP5SOyzAaTcGMa7hVIeU+AbpEsXkC+2RHBgCKlc 6QpmCACe6lfqBxM0IXDbW8qbpX0I8KuaFSPoYiVpx7uoia0QSmeCKWlX+wnzKFumFDzG 6sDMQE+5adMyYnx4IoCpyWZ7xfXPolykazijem6iBTAsu3YQ8+7EtojX9IxIjQkIFHfc tMrr8gp0mF/EXtFrytgNkkdQbJbJkPKO2xprqsDwQBmsx/syd90f+fmOsTJ6nk5cBVO4 F/Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=1nLee9OxfWJumMQb1Blhe6f0ID/OAoOAAAY6sR9ws0c=; b=Cy7Bk0fnIsFtCMYU5QMNt+HYIEmvnZTS+SVz4rNxFZxCSsdRfkL61jl/n6DpmTVeO/ SOywF4gBVlVNJLOBw05wFCvLbQ6ODL6Sh0Ac8+DnmKxrtsiP7/YBHovHZ2fD+NbCDifh UaxYHvp7Rgnzx1f3Q4CIuKhaagJDH2LqTqQ64uTQQFqr9Amx/ev2kvoIeKCvGug3Molh eWIve8BdEH71pRR1wYdeyav4fbsjc9CDjfcR+gZZg2gXD8wvgyCNLTpYdbJM6BLhd/zC HHr7/74+hZB5u4VLOP5jK7E9uUfEHgJiduyzwdsKRsSgIsh/HSKfpKqWXwyljqaGYGxq 4z7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m26si935493edf.113.2020.10.15.23.45.53; Thu, 15 Oct 2020 23:46:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390718AbgJPGA2 (ORCPT + 99 others); Fri, 16 Oct 2020 02:00:28 -0400 Received: from foss.arm.com ([217.140.110.172]:53494 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390427AbgJPGA1 (ORCPT ); Fri, 16 Oct 2020 02:00:27 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3420B30E; Thu, 15 Oct 2020 23:00:26 -0700 (PDT) Received: from bogus (unknown [10.57.17.164]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4F6DF3F66B; Thu, 15 Oct 2020 23:00:23 -0700 (PDT) Date: Fri, 16 Oct 2020 07:00:21 +0100 From: Sudeep Holla To: Viresh Kumar Cc: ulf.hansson@linaro.org, "Rafael J. Wysocki" , Kevin Hilman , Pavel Machek , Len Brown , Greg Kroah-Hartman , Viresh Kumar , Nishanth Menon , Stephen Boyd , Kukjin Kim , Krzysztof Kozlowski , linux-pm@vger.kernel.org, Vincent Guittot , nks@flawful.org, georgi.djakov@linaro.org, Stephan Gerhold , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH V2 1/2] opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER Message-ID: <20201016060021.sotk72u4hioctg7o@bogus> References: <24ff92dd1b0ee1b802b45698520f2937418f8094.1598260050.git.viresh.kumar@linaro.org> <20201015180555.gacdzkofpibkdn2e@bogus> <20201016042434.org6ibdqsqbzcdww@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201016042434.org6ibdqsqbzcdww@vireshk-i7> User-Agent: NeoMutt/20171215 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 16, 2020 at 09:54:34AM +0530, Viresh Kumar wrote: > On 15-10-20, 19:05, Sudeep Holla wrote: > > OK, this breaks with SCMI which doesn't provide clocks but manage OPPs > > directly. Before this change clk_get(dev..) was allowed to fail and > > --EPROBE_DEFER was not an error. > > I think the change in itself is fine. We should be returning from > there if we get EPROBE_DEFER. The question is rather why are you > getting EPROBE_DEFER here ? > Ah OK, I didn't spend too much time, saw -EPROBE_DEFER, just reverted this patch and it worked. I need to check it in detail yet. -- Regards, Sudeep