Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1035476pxu; Fri, 16 Oct 2020 02:03:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztKHFyHp1XXMDgz8OeUjMBnqKZdl5apmKjrUgKpol7mVUZTXMOrmbCRU4q/Le5q+h4YT9o X-Received: by 2002:a17:906:fd7:: with SMTP id c23mr2801078ejk.324.1602838993756; Fri, 16 Oct 2020 02:03:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602838993; cv=none; d=google.com; s=arc-20160816; b=fEz/lygGapaYhu1i5/fljjt9d9If7Qu9n0WEZtvIWY47e6+WtkwN9fcWwVWBoyBeFX 4ZdS8b1h1PXJm5+LCIpMTPExojv57VR2fGT4tBgO6PeIIHNTmUPxmYFnQVjkDfrMxZ72 mV/J1jyWKy1njvck9bgOHLI3LzkHPBPz+lLOffZbuCcMoNMKWxTKUKnXMGMn8obOUYP6 H3eTkvEPhzamV3JvBPDZRSgUdBMn0+/bXkroEc5WyMvMpPHtP4LT0ShvG+KwaiLDs/40 HAirGEa3Rhklz4h57Yvl9q8O5XjwLosZXDUQylU1T/7wUQfbn3Jl32cld4k3uEH2CUL4 i2Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Hr64Vn0+HOozpsku169KlWnz5smy9iW/9D6WwYh/U4U=; b=xGesgRW0HqrqaHP572udxBoG/vf843SpF6NJO5W2IkBN4mIrOha++dZAfZQ9EBP3ky 9sVlCRkEkFmyoTjcdq0esF3dxWF6d29JQw2pmNXldQlDP4vqHgS31QFeydmSNnIFlajr l75icwVW9sJ/880Cx/u3taH8tVnarrF0Cd0BP8ofJM4lKnau/cAqT8VK3flHZnAy+c/l B5An1JAIp690FCDTUaH6uWxoDJbYu2VL9f0uyifnA2QJPStlOLGsb85wT5XOvH0RL7et rnTo3DkFpS0YhVaLLjdcmIz+q9T50R9nhJRg4HjzWXixQuLOL37Ku/wc7a7MhMNqW+Ku W+Jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=DY6ChfUU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j17si1183410edh.295.2020.10.16.02.02.51; Fri, 16 Oct 2020 02:03:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=DY6ChfUU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404536AbgJPHUq (ORCPT + 99 others); Fri, 16 Oct 2020 03:20:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404508AbgJPHUq (ORCPT ); Fri, 16 Oct 2020 03:20:46 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6950DC061755; Fri, 16 Oct 2020 00:20:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Hr64Vn0+HOozpsku169KlWnz5smy9iW/9D6WwYh/U4U=; b=DY6ChfUU+XuHd8pI3W8vg66Skt hpkSqI7Jb5NYjnCvzyTg/pgLU3QYTkLO8duny6oxc8mWj1GOZ3FoiBbPkNDlYgTAEBbLEHmlvNUR1 fmTp4R5h7zAtTUZKWvSkN6jsMAaJs90n3QJ6dl02zXqLyf2XoZxm+66Cbl1Uac9Fzj/ftCmDXAjra /s3Pz9WFFnyYOKXXuMBxn4Ofnd3r3IltTDgR0KtHyIZVEUbCmV9ELXsHJUueQhvF7GmjVofirFjE4 G+vHY+nP9wKmqFrdPbM5Zi6ayYn/qt017fZTBhJP5oRCvFfMEuy9FgdM8UibVypz4+IV/BdF8rVaL j7Wf1V4A==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kTK2e-0004IG-WD; Fri, 16 Oct 2020 07:20:45 +0000 Date: Fri, 16 Oct 2020 08:20:44 +0100 From: Christoph Hellwig To: Satya Tangirala Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com, Jens Axboe , Alasdair Kergon , Mike Snitzer , Eric Biggers Subject: Re: [PATCH v2 1/4] block: keyslot-manager: Introduce passthrough keyslot manager Message-ID: <20201016072044.GB14885@infradead.org> References: <20201015214632.41951-1-satyat@google.com> <20201015214632.41951-2-satyat@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201015214632.41951-2-satyat@google.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org And this just validates my argument that calling the inline crypto work directly from the block layer instead of just down below in blk-mq was wrong. We should not require any support from stacking drivers at the keyslot manager level.