Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1037760pxu; Fri, 16 Oct 2020 02:07:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwMz1ZCeIR/xX61lULGCDQyIwrSsAdcLkLBiYOlVwzNoZDXn/jb6f407BqOE6I6rdsgayyt X-Received: by 2002:a05:6402:2076:: with SMTP id bd22mr2793833edb.197.1602839239463; Fri, 16 Oct 2020 02:07:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602839239; cv=none; d=google.com; s=arc-20160816; b=h0RMOOOIpac4rvu/fJKkn6L8yAMeAJS/Z+Rr51XYQedTwu5Wolbw8LMpuhLfCGFF3g YFYvIuvU5NloprjzR+39If2cGp6px1I4eaJES/2Skd+AsJyXRY1XmfDXxnkfjK7p6Oeu LHN3maybYJ6E0vi4GwbMl2vsjrX1nQR5fvx+KfDLDuXgKOh/DdYfJE2QxyQY2WzL0HkB 46j7K8GvQHTNyNjP6oQaGmg7zUytU+zH/HbqWMy0hMpzJIkHsC0eIOIBRa42/sIcam01 OEELRuBTQMovTcrLBAODqa5pAF653FZQBMxZgJj918wXT4l94sqRg+PJfAxnxX4waqym h0kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=4kEnSFSZxbIJJK2f6vPVqVDX9jW+/8z+1Xueo6/t7eI=; b=MFwIQlkgN6t5iev71Fq5thyLlLEoxvWc50PzWUmkkYIQ1r/8ziqwyopV658v+mSCrs 0/LpOKx+y+hjVWId4RWZpmsMv1+O0MI3GPavgzTfOxtp40y/6dGrkklPcIwYidM60tvM 6eUhC4OzmlBS0YN11zVJdVqY22hMj9jME/03cyC1mh+/O/U7ziva0dt6Ec2LpX2su7jU J6Zb/o4piNyDOpDXnTH+mqTBYi+83XA+TcjreCLG6ldHLT+x9iAth38SrDujSwtCtFTO dKp6lJdRh99+Ezr1ThVavUHq2hlfIfssk//Lol6EKMlBne6zOiSxUCnK8JkGV7MtMNBJ rdew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mh11si1330375ejb.676.2020.10.16.02.06.57; Fri, 16 Oct 2020 02:07:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404860AbgJPHw2 (ORCPT + 99 others); Fri, 16 Oct 2020 03:52:28 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:40150 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2404854AbgJPHw2 (ORCPT ); Fri, 16 Oct 2020 03:52:28 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id B1D4F836F1B584A3BFB9; Fri, 16 Oct 2020 15:52:26 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.487.0; Fri, 16 Oct 2020 15:52:18 +0800 From: Jing Xiangfeng To: , , , , , , , , CC: , , Subject: [PATCH] RDMA/core: Fix error return in _ib_modify_qp() Date: Fri, 16 Oct 2020 15:58:45 +0800 Message-ID: <20201016075845.129562-1-jingxiangfeng@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix to return error code PTR_ERR() from the error handling case instead of 0. Fixes: 51aab12631dd ("RDMA/core: Get xmit slave for LAG") Signed-off-by: Jing Xiangfeng --- drivers/infiniband/core/verbs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c index 307886737646..bf63c7561e8c 100644 --- a/drivers/infiniband/core/verbs.c +++ b/drivers/infiniband/core/verbs.c @@ -1685,8 +1685,10 @@ static int _ib_modify_qp(struct ib_qp *qp, struct ib_qp_attr *attr, slave = rdma_lag_get_ah_roce_slave(qp->device, &attr->ah_attr, GFP_KERNEL); - if (IS_ERR(slave)) + if (IS_ERR(slave)) { + ret = PTR_ERR(slave); goto out_av; + } attr->xmit_slave = slave; } } -- 2.17.1