Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Tianxianting <tian.xianting@h3c.com>
To:     Michal Hocko <mhocko@suse.com>
CC:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] mm: vmscan: avoid a unnecessary reschedule in
 shrink_slab()
Thread-Topic: [PATCH] mm: vmscan: avoid a unnecessary reschedule in
 shrink_slab()
Thread-Index: AQHWo29cMaRbAMdQE0ycFn5GylDeeqmZnPOAgACJFdA=
Date:   Fri, 16 Oct 2020 12:48:23 +0000
Message-ID: <9a2b772b13f84bdd9517b17d8d72aa89@h3c.com>
References: <20201016033952.1924-1-tian.xianting@h3c.com>
 <20201016120749.GG22589@dhcp22.suse.cz>
In-Reply-To: <20201016120749.GG22589@dhcp22.suse.cz>
Accept-Language: en-US
Content-Language: zh-CN
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Precedence: bulk

Thanks, my understanding is,
In shrink_slab(), do_shrink_slab() will do the real reclaim work, which will occupy current cpu and consume more cpu time, so we need to trigger a reschedule after reclaim.
But if it jumps to 'out' label, that means we don't do the reclaim work at this time, it won't cause other thread getting starvation, so we don't need to call cond_resched() in this case.
Is it right?

-----Original Message-----
From: Michal Hocko [mailto:mhocko@suse.com] 
Sent: Friday, October 16, 2020 8:08 PM
To: tianxianting (RD) <tian.xianting@h3c.com>
Cc: akpm@linux-foundation.org; linux-mm@kvack.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: vmscan: avoid a unnecessary reschedule in shrink_slab()

On Fri 16-10-20 11:39:52, Xianting Tian wrote:
> In shrink_slab(), it directly goes to 'out' label only when it can't 
> get the lock of shrinker_rwsew. In this case, it doesn't do the real 
> work of shrinking slab, so we don't need trigger a reschedule by 
> cond_resched().

Your changelog doesn't explain why this is not needed or undesirable. Do you see any actual problem?

The point of this code is to provide a deterministic scheduling point regardless of the shrinker_rwsew.

> 
> Signed-off-by: Xianting Tian <tian.xianting@h3c.com>
> ---
>  mm/vmscan.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c index 466fc3144..676e97b28 
> 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -687,8 +687,9 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid,
>  	}
>  
>  	up_read(&shrinker_rwsem);
> -out:
> +
>  	cond_resched();
> +out:
>  	return freed;
>  }
>  
> --
> 2.17.1
> 

-- 
Michal Hocko
SUSE Labs