Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 16 Oct 2020 12:48:12 +0200
From:   Niklas =?utf-8?Q?S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>
To:     Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc:     linux-renesas-soc@vger.kernel.org, geert+renesas@glider.be,
        laurent.pinchart@ideasonboard.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] dt-bindings: media: renesas,vin: Add V3U support
Message-ID: <20201016104812.nxdqjznjj6fxidmu@oden.dyn.berto.se>
References: <20201016111158.17521-1-jacopo+renesas@jmondi.org>
 <20201016111158.17521-6-jacopo+renesas@jmondi.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20201016111158.17521-6-jacopo+renesas@jmondi.org>
Precedence: bulk

Hi Jacopo,

Thanks for your work.

On 2020-10-16 13:11:57 +0200, Jacopo Mondi wrote:
> Add compatible string definition for R-Car V3U.
> 
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
> 
> This and the following patch are still under discussion as the
> proper support for the V3U VIN might require the implementation
> of a different driver.
> 
> I'm fine deferring it to when we'll have a more clear plan for V3U support.

I think it's best we defer it until we have a plan for how we are going 
to support it on the driver side.

> 
> v2:
> - Increase maxium value for the 'renesas,id' property to support
>   the V3U's 31 VIN instances
> 
> ---
>  Documentation/devicetree/bindings/media/renesas,vin.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,vin.yaml b/Documentation/devicetree/bindings/media/renesas,vin.yaml
> index ad2fe660364b..f7ac1fd3df25 100644
> --- a/Documentation/devicetree/bindings/media/renesas,vin.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,vin.yaml
> @@ -51,6 +51,7 @@ properties:
>                - renesas,vin-r8a77980 # R-Car V3H
>                - renesas,vin-r8a77990 # R-Car E3
>                - renesas,vin-r8a77995 # R-Car D3
> +              - renesas,vin-r8a779a0 # R-Car V3U
> 
>    reg:
>      maxItems: 1
> @@ -120,7 +121,7 @@ properties:
>      description: VIN channel number
>      $ref: /schemas/types.yaml#/definitions/uint32
>      minimum: 0
> -    maximum: 15
> +    maximum: 31
> 
>    ports:
>      type: object
> --
> 2.28.0
> 

-- 
Regards,
Niklas S?derlund