Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1255870pxu; Fri, 16 Oct 2020 07:44:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyUaa8F6huzPt3jsUGvUQNHMKVcfgG3v/Wg53CU98b19pnA0cNl8iP02c2pxzFdnDSuuvUT X-Received: by 2002:a17:906:4d10:: with SMTP id r16mr4384395eju.68.1602859443547; Fri, 16 Oct 2020 07:44:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602859443; cv=none; d=google.com; s=arc-20160816; b=ZyX8HQVP6IeVkaGKEYXAvmy7WybcOUD7sp7i5I3gMRdrsZczVfH+2tIjehZ/o2/UOy BCdS4xYcyAoMpAUP7JkorDds/z84ST2/61irhpO5bMTKpHuMoBSVIiWVAIFShot2aYH3 5iTNS6lOAHVgCEPtaUmMqrDYk2VuutSnS5uG7uJpw0OUCU0bC03boNIIhlZYVcAl680d anIh3IuFpkkRTTwWGf3Mwu3JC/ohSHeht1sQPhymoTPxhezAT9dkbIcyKGAEg7HniTZl TcJsWLTcq6DMn7r7HBmGQxsCnLCsNVb35w+H8RLXonepMrjzoUKNYj8CKLFmx/eB6RIM ZSHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=eyZ2qg64RQ303sBdkP1lBs7fkr9God3dSz0qy38M/4M=; b=jhiXld7eL+BXa0yCKDR/1bZP3QeyYbBt5RE6DLRnCgg9OI2wxsO9McQ8EQ8oYQkBuf hJD9zTvMW+vBzMrZOGQwqQvMIePI9wNngh+n7wEYodQT8KKejYsacjDD7SS5elTaDmIP b4JChTAiafKt05tGhBYZLIkXattY/+W1tbAZXBGIu3DwIG8Qtnd+RbFHyi+2U+aomETz EQZ1L3332LcxoocN8dfx3lqDE4hx697XDEtk6zutsDG8ZXYp8z5cRmhOuZF0p6PyCnN9 JTAjRizHAWKOgh2mcqXMh/snEQkrW7uZ/jE1Dc/CY/rAAPzoUsp6L4nut2gbFqAv41At 7dtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=merlin.20170209 header.b=dZ9yLLnD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h18si1891210ejl.297.2020.10.16.07.43.41; Fri, 16 Oct 2020 07:44:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=merlin.20170209 header.b=dZ9yLLnD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395545AbgJPLIE (ORCPT + 99 others); Fri, 16 Oct 2020 07:08:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394978AbgJPLIE (ORCPT ); Fri, 16 Oct 2020 07:08:04 -0400 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB189C061755; Fri, 16 Oct 2020 04:08:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=eyZ2qg64RQ303sBdkP1lBs7fkr9God3dSz0qy38M/4M=; b=dZ9yLLnDn8uHkOohF4LtcVTtmG vD/AvaMvtW7Iv79FR7SYDe3WCGkohikUM/LA3sJTkktbuTGecWJvkHruNptN/hVsM2IupFmNIA5S2 H69bQ0Xu77anBDXOJpsYWe7HHiH337wX6hYLdljPurcjoEypXOYYjyKQvTTowiu2JOKasGGQ3Ossx x62zDNQP0/8RlsPG6ycSOA2wYISuv2XuWA+cMKIfe67hrK8616drWYuaoceAy9lBS9hNaXpb/QDXH NY6rmTF3WZZmzQ9PYAMvqWkvZcVjSAbvTFWrdah3Db5WssoZG3WYHZbfoY6sxywhh63dSN4xzCz1t SJLSJzPA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kTNaP-0001gC-NE; Fri, 16 Oct 2020 11:07:49 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 978F03011E6; Fri, 16 Oct 2020 13:07:47 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 8A2F622E98D29; Fri, 16 Oct 2020 13:07:47 +0200 (CEST) Date: Fri, 16 Oct 2020 13:07:47 +0200 From: Peter Zijlstra To: ira.weiny@intel.com Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Andy Lutomirski , Fenghua Yu , x86@kernel.org, Dave Hansen , Dan Williams , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH RFC V3 5/9] x86/pks: Add PKS kernel API Message-ID: <20201016110747.GM2611@hirez.programming.kicks-ass.net> References: <20201009194258.3207172-1-ira.weiny@intel.com> <20201009194258.3207172-6-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201009194258.3207172-6-ira.weiny@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 09, 2020 at 12:42:54PM -0700, ira.weiny@intel.com wrote: > +static inline void pks_update_protection(int pkey, unsigned long protection) > +{ > + current->thread.saved_pkrs = update_pkey_val(current->thread.saved_pkrs, > + pkey, protection); > + preempt_disable(); > + write_pkrs(current->thread.saved_pkrs); > + preempt_enable(); > +} write_pkrs() already disables preemption itself. Wrapping it in yet another layer is useless.