Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1297842pxu; Fri, 16 Oct 2020 08:37:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxOd8eI7b3uqP6XtOJ67oHW5OTTgDtBxS91Ea9sxpdA3y68YwhpGBJZsKHEji6HKsjVFrJK X-Received: by 2002:aa7:cd1a:: with SMTP id b26mr4546732edw.97.1602862634564; Fri, 16 Oct 2020 08:37:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602862634; cv=none; d=google.com; s=arc-20160816; b=KgQNKhIqxfjarWoQ2h8LPUPMTqJAjaRy6h4KPBD85AKySWoR4FzvrGuA76utqXh99F l7bc4aBDOLWAVsu3xEUlhenETxCl35WH1z8u5rv11lKPdpYLoUfsR5LkD5GPxHEtBiM9 GM/1J3OK0Tg1SL4p7UH7EMMRvKyc/qwlCh4a4Qpw3KfRgI6aaiIbLylCZTOs6BJpW7PZ K6CwGrubPSGInVImsXzwRPJdp7TSg1cAcQgjTRunFEurzbRoAuZNcDQ+EeoCgH6OSTxm eN+A8P9kbtHzagsCOP2TuVcI3F56QrYBREOTlFf0olTksEL+tzAVRkA51RNHv12eiijg hrNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=7ZxiSkKJIQIB5PidhClNmB2YPlNf3Wah9XPCO/SvxnQ=; b=xl1qbRh12OsaLABDXl49SE40OOQlePVqb4ctNXHGh/dGhPnlSNvJO4mikol+Dmx8vQ 2OmU3r3Ak1wQ9guIoKTYU2bbBjUKfTySVwK+FjTUiFibHaZfG5CQKEmYJuG+obdl3Z/p TW2A6aOR6F7Ezsv3pX9yW7ZnAatjWdsH7e3JYr02FFbfCkkuAz01133Fne/sSZOBqCY2 UFFRDri5Le48YHdVnxtTZVmJRBUs8PK4Y4zZrk5iBTjrJDPx1XoLabaoIyhLa+x4a7PY n/LfwruDIAR5d+mAPLZ/FIAqvbk8RiLG6uPwM1SKQOtqvjkAr5KuOGcLH+UeivOITWVT WUXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ABXe786v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id el4si1897495ejc.254.2020.10.16.08.36.52; Fri, 16 Oct 2020 08:37:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ABXe786v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408447AbgJPOAm (ORCPT + 99 others); Fri, 16 Oct 2020 10:00:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394143AbgJPOAm (ORCPT ); Fri, 16 Oct 2020 10:00:42 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34E7CC061755; Fri, 16 Oct 2020 07:00:42 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id d3so3080828wma.4; Fri, 16 Oct 2020 07:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7ZxiSkKJIQIB5PidhClNmB2YPlNf3Wah9XPCO/SvxnQ=; b=ABXe786v9mEdTIIAGOuMPv93Amrvl26X+bvova6WNMzoWbn/s43ZDlJI94dsaxLOZu 1UbW1odsrxKdlY6VjITDACb222IfEBTxU8L0O3pDw5/tvTLAlI/+RQUC44EAWxpL6ufV gDfjF6Vi3h08A/tncqNXRSg8VbnsE9w/Krz/6S1B7qbnlvcK3cwIYSmBf6eD8aR+I2Q5 nZ8D+3x7v8WQG2Yg7vna1oz6SSKZZcG/IdMRU7ZKnaRas2BNbfAuT3ygeOAG25NLmswp 8WrRQ4uQsP8RQHAAUfik/riech7+0iH1c2CV78Ie0oklNAxePLTE1OP5IINmY879RuqZ bRlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7ZxiSkKJIQIB5PidhClNmB2YPlNf3Wah9XPCO/SvxnQ=; b=U+OtHDFerl8ioeEmUYVrI6hxBG5KDLHvAgF1B5EALKj5yXlJ352DbpbDlpwbzsFKuR Em+d+k/ht6YBx0pSZEdoc4tUY09VVfM+ApeDmmociMytORDUqaF+m/uyEV9lbYjFG64t laqpVTSiX1sXDyJdO1Fo9foxGpiBQVnMLlnXMhAtXxnUMHmOd18/pulCGx0Vi8rbdNWh mXcsIL3ldQMWYThB//RS7PAgjWhpdq6txrWeIhwh0Tt9CCnJAsUoxNTe1JpT4D3Vn7AW PeI+LBlSOUzBR0ONa9LdepreC3bOQv2k/B14x/dZCNa4wX7pc87XMmutsSSbuH8aNNXy 6oBA== X-Gm-Message-State: AOAM530RlBPmeVvLQele7J06kn0URMskcBSXi+RPf2LE+r+42J4B/hoT 6Pc7JbqFKdCcywlgjtgVVqRAPWUTAb5K6WDRFgI= X-Received: by 2002:a7b:c7d5:: with SMTP id z21mr4010888wmk.73.1602856840762; Fri, 16 Oct 2020 07:00:40 -0700 (PDT) MIME-Version: 1.0 References: <20201016124009.GQ2611@hirez.programming.kicks-ass.net> In-Reply-To: <20201016124009.GQ2611@hirez.programming.kicks-ass.net> From: Mikhail Gavrilov Date: Fri, 16 Oct 2020 19:00:29 +0500 Message-ID: Subject: Re: swapon/913 is trying to acquire lock at zcomp_stream_get+0x5/0x90 [zram] but task is already holding lock at zs_map_object+0x7a/0x2e0 To: Peter Zijlstra Cc: Linux List Kernel Mailing , linux-block@vger.kernel.org, Mike Galbraith , minchan@kernel.org, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, bigeasy@linutronix.de Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Oct 2020 at 17:40, Peter Zijlstra wrote: > > > Joy... __zram_bvec_write() and __zram_bvec_read() take these locks in > opposite order. > > Does something like the (_completely_) untested below cure things? Excellent! This patch (_completely_) cured all other warnings which were present in the log. dmesg before patch: https://pastebin.com/tZY3npHG dmesg after patch: https://pastebin.com/iD7ZL1mb Thanks! -- Best Regards, Mike Gavrilov.