Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1320717pxu; Fri, 16 Oct 2020 09:07:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHNJejjO9xkgRCLKu8Ajla2o8ZxXxsFpjJoVhnfcwGXHcXZBRBwtsDT4cjwBysxxit4+jW X-Received: by 2002:a17:906:4a03:: with SMTP id w3mr4612635eju.15.1602864454775; Fri, 16 Oct 2020 09:07:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602864454; cv=none; d=google.com; s=arc-20160816; b=BuFHOwMl24lq2tRctkbC41eVJHdVw0HNSFvjAJIts8B8xBcqwfcfQjgwJx6Xdmmqnz +wzCSh2KyjbVViejz9lECLlLuEXr8ssJuI1M0n5YzOrDJxvfZE6jVelzgIeR2gF0yMoC feE/ES+EtlJ6if0UMQl9M8G1lG/fqGCt9Wxxav21IbRltdrvE2KIoaaNE4glx3QsJQRE zxzlybicVRqTqa4paBZ7h8DeHN8MHqlZIPJv1vDWdJv5Lx1v9t860jcDXZhrY4Ce4a4j oSu783x+3FegS6qtvkARQVsD8yNfikD3wUsV0D4tKU2D4vFZZs47Ukv4MmthRwCcroHa hLLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=kBtWUw3GIVsSeyCo9bJLswKdHG8dpp1UAeDuAGGyOhU=; b=exBIoCImI5LF/AU/tKzddOMcAlrWbSc+MZLYSlMI2OafsSt6oJQwejcnUptYqnLDlY 5LN7gq+PiRhQaIS4dQpUxWITcQSzyEzzvoxSKD+FBxQkm2ckDJt1BRlW/lyPQiiBs5qt rEewdS8eynBo4zTGnME+cSm4rg9xs85PI9cDqPJIUVOOk/65zB3EAEP5BJYjYhDfQ/Vo 5OQjLJdVjXbGiYRYVbPweYxRzsuVpw5flisR72s42pBj4zYAaMDBoCJHOFQ6I6lcMLAn a9Lrod8iRWc49txxAThBH62Lo5qFKMSNgWFQ66aFa4rOg86pytiPN/PKR3HtlItzyBv/ z3jQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Pu8yEIgU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nx19si1849238ejb.591.2020.10.16.09.07.12; Fri, 16 Oct 2020 09:07:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Pu8yEIgU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2409282AbgJPOvt (ORCPT + 99 others); Fri, 16 Oct 2020 10:51:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46677 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2409247AbgJPOvs (ORCPT ); Fri, 16 Oct 2020 10:51:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602859907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kBtWUw3GIVsSeyCo9bJLswKdHG8dpp1UAeDuAGGyOhU=; b=Pu8yEIgUI4BXlTPlC0NJ0egti+7zTjeOsMmSUsU72tu3Jvbgasm51Zvkt/l8/aGDaNTLNw Og5x9Ekk4xTdua9KMfVr4FRFZ2TxCEu8AKACKDuCWsYFSnkb+/wTaCpWhNIIpc4A6HWVKc 0jhI2AVwFGz4O3QxZx3hsFc7cmmh0zk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-21-zcry8vEoOc6_vqJsH77Lrg-1; Fri, 16 Oct 2020 10:51:43 -0400 X-MC-Unique: zcry8vEoOc6_vqJsH77Lrg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BE8BE80365F; Fri, 16 Oct 2020 14:51:41 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.40.192.149]) by smtp.corp.redhat.com (Postfix) with SMTP id 1885C5B4A2; Fri, 16 Oct 2020 14:51:39 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Fri, 16 Oct 2020 16:51:41 +0200 (CEST) Date: Fri, 16 Oct 2020 16:51:38 +0200 From: Oleg Nesterov To: Thomas Gleixner Cc: Jens Axboe , linux-kernel@vger.kernel.org, io-uring@vger.kernel.org, peterz@infradead.org, Roman Gershman Subject: Re: [PATCH 5/5] task_work: use TIF_NOTIFY_SIGNAL if available Message-ID: <20201016145138.GB21989@redhat.com> References: <20201015131701.511523-1-axboe@kernel.dk> <20201015131701.511523-6-axboe@kernel.dk> <20201015154953.GM24156@redhat.com> <87a6wmv93v.fsf@nanos.tec.linutronix.de> <871rhyv7a8.fsf@nanos.tec.linutronix.de> <87a6wmtfvb.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a6wmtfvb.fsf@nanos.tec.linutronix.de> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16, Thomas Gleixner wrote: > > With moving the handling into get_signal() you don't need more changes > to arch/* than adding the TIF bit, right? we still need to do something like - if (thread_flags & _TIF_SIGPENDING) + if (thread_flags & (_TIF_SIGPENDING | _TIF_NOTIFY_SIGNAL)) do_signal(...); and add _TIF_NOTIFY_SIGNAL to the WORK-PENDING mask in arch/* code. Oleg.