Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 16 Oct 2020 18:56:45 +0300
From:   Vladimir Oltean <olteanv@gmail.com>
To:     Christian Eggers <ceggers@arri.de>
Cc:     Kurt Kanzenbach <kurt@linutronix.de>,
        Woojung Huh <woojung.huh@microchip.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: ksz: fix padding size of skb
Message-ID: <20201016155645.kmlehweenqdue6q2@skbuf>
References: <20201014161719.30289-1-ceggers@arri.de>
 <4467366.g9nP7YU7d8@n95hx1g2>
 <20201016090527.tbzmjkraok5k7pwb@skbuf>
 <1655621.YBUmbkoM4d@n95hx1g2>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1655621.YBUmbkoM4d@n95hx1g2>
Precedence: bulk

On Fri, Oct 16, 2020 at 02:44:46PM +0200, Christian Eggers wrote:
> Machine:
> - ARMv7 (i.MX6ULL), SMP_CACHE_BYTES is 64
> - DSA device: Microchip KSZ9563 (I am currently working on time stamping support)

I have a board very similar to this on which I am going to test.

> Last, CONFIG_SLOB must be selected.

Interesting, do you know why?

> 3. "Manually" unsharing in dsa_slave_xmit(), reserving enough tailroom
> for the tail tag (and ETH_ZLEN?). Would moving the "else" clause from
> ksz_common_xmit()  to dsa_slave_xmit() do the job correctly?

I was thinking about something like that, indeed. DSA knows everything
about the tagger: its overhead, whether it's a tail tag or not. The xmit
callback of the tagger should only be there to populate the tag where it
needs to be. But reallocation, padding, etc etc, should all be dealt
with by the common DSA xmit procedure. We want the taggers to be simple
and reuse as much logic as possible, not to be bloated.