Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 16 Oct 2020 10:02:45 -0700
From:   Roman Gushchin <guro@fb.com>
To:     Johannes Weiner <hannes@cmpxchg.org>
CC:     Michal =?iso-8859-1?Q?Koutn=FD?= <mkoutny@suse.com>,
        Richard Palethorpe <rpalethorpe@suse.com>,
        <ltp@lists.linux.it>, Andrew Morton <akpm@linux-foundation.org>,
        Shakeel Butt <shakeelb@google.com>,
        Christoph Lameter <cl@linux.com>,
        Michal Hocko <mhocko@kernel.org>, Tejun Heo <tj@kernel.org>,
        Vlastimil Babka <vbabka@suse.cz>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] mm: memcg/slab: Stop reparented obj_cgroups from
 charging root
Message-ID: <20201016170245.GB230727@carbon.DHCP.thefacebook.com>
References: <20201014190749.24607-1-rpalethorpe@suse.com>
 <20201016094702.GA95052@blackbook>
 <20201016145308.GA312010@cmpxchg.org>
In-Reply-To: <20201016145308.GA312010@cmpxchg.org>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from carbon.DHCP.thefacebook.com (2620:10d:c090:400::5:e7ba) by MW2PR16CA0027.namprd16.prod.outlook.com (2603:10b6:907::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.20 via Frontend Transport; Fri, 16 Oct 2020 17:02:50 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d4f50bfa-32a5-4961-b8f5-08d871f550e6
X-MS-TrafficTypeDiagnostic: BYAPR15MB3157:
X-Microsoft-Antispam-PRVS: <BYAPR15MB3157C671310682C110C9B90BBE030@BYAPR15MB3157.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: tcDpFeexD6ztQLbNX8MbsYul3iC9dT92iNwF5RLLu6P72acJguBxxQuJS8HmPH3Y0sQrPoT3pwt2kBOSsTW+XrIRubfkX9Q/07uG9Mr145k684G8rUQzxOhPiHEwQnNqK5xIRa1W5a+X5NS8nVIVqWwOB5Yh7QLSIQIRn6MhTE1E2eXNvAPK/MZODO50hPkrsaTCvEk4cIk+MRfIgwceR4BPHM//orSXT60VN9CkFb0aWn+b1Ho0exlfUq0/Ck82MDI23oRnNbV1/jysLx2npyGwgSdysbkouWGxzp1Hz3akg8nAeP+OuExUBtbzzropIA9M5Bgp4efW1hkCI9ao0g==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR15MB4136.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(376002)(39860400002)(346002)(396003)(366004)(316002)(478600001)(54906003)(6506007)(33656002)(186003)(16526019)(83380400001)(6916009)(8676002)(9686003)(55016002)(86362001)(8936002)(52116002)(66556008)(6666004)(4326008)(1076003)(2906002)(66946007)(66476007)(7696005)(7416002)(5660300002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: FQkCCYMuSirPe4Hb6HR+S8x7TbYfEFW4qzituTqEVUt9qWHT07kaly1prqZcDEY0pgvWXoIvM/WTKUFMKQ2lFthG34jAjIkT28u6odU7iyZhGv/aj4HptHVlXDdQdEeqlmuRStCRJWGdlDlFb1dd9WP5AzBBqdZ6fTX7z6Zza7G+V2LOf5Ya0oMhgTWzOAGx45zL+wPQ1djpDQpr2jDsj8cshntFxRl3vypo+/9jIKn3PK/Odf0K8QJNLpeOzGbF1bs32GoMs/7nqGpLwr2oI4plz/aTZePPdisMjpdIWLmM/UGZKEtlGd2I3yVL6KEcSKJKfaCUq9XkXcgvmz0JPlwYoRv3Vp+Roia2X2LxCY319bLuJZdiuMgmxYqafYZnydsZJGDfqN1180YpCtJScHToLE+aL7g6idXO+dPX0/aozd/hs5gaN2EzGSTY9nNYNijdXpJIlX6vgmbmCMZFWADAJQa5bsQte1OqTop0xmoIX0jqsNSIGL/DVhgPvLUI6S8tg5b5xJqqt62M/U4Mlz3uYTt5hJr6BgE6382Ce2hQBDSlTr5g7II+0y6+W52SXWwTRYCC6TOURMO2NbWkBqE4hQDd/8Im5gy+xpsaLjz3nK2UtZ2grgGJruYTeiqItSWqQ2LJ4dWNDfaLIO3Dl52t/HMtK5zOsbET65ldGnU=
X-MS-Exchange-CrossTenant-Network-Message-Id: d4f50bfa-32a5-4961-b8f5-08d871f550e6
X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4136.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2020 17:02:51.4707
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XkJA4n+wCyVXcdwk1AjU41Ev/JwIN4MAxZfSrhDRx353T86/JU4yhb+L69E2PMmF
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3157
X-OriginatorOrg: fb.com
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687
 definitions=2020-10-16_08:2020-10-16,2020-10-16 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 phishscore=0
 impostorscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0
 priorityscore=1501 clxscore=1015 bulkscore=0 spamscore=0 mlxscore=0
 suspectscore=1 mlxlogscore=999 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2009150000 definitions=main-2010160127
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 16, 2020 at 10:53:08AM -0400, Johannes Weiner wrote:
> On Fri, Oct 16, 2020 at 11:47:02AM +0200, Michal Koutn? wrote:
> > Hello.
> > 
> > On Wed, Oct 14, 2020 at 08:07:49PM +0100, Richard Palethorpe <rpalethorpe@suse.com> wrote:
> > > SLAB objects which outlive their memcg are moved to their parent
> > > memcg where they may be uncharged. However if they are moved to the
> > > root memcg, uncharging will result in negative page counter values as
> > > root has no page counters.
> > Why do you think those are reparented objects? If those are originally
> > charged in a non-root cgroup, then the charge value should be propagated up the
> > hierarchy, including root memcg, so if they're later uncharged in root
> > after reparenting, it should still break even. (Or did I miss some stock
> > imbalance?)
> 
> Looking a bit closer at this code, it's kind of a mess right now.
> 
> The central try_charge() function charges recursively all the way up
> to and including the root. But not if it's called directly on the
> root, in which case it bails and does nothing.
> 
> kmem and objcg use try_charge(), so they have the same
> behavior. get_obj_cgroup_from_current() does it's own redundant
> filtering for root_mem_cgroup, whereas get_mem_cgroup_from_current()
> does not, but its callsite __memcg_kmem_charge_page() does.
> 
> We should clean this up one way or another: either charge the root or
> don't, but do it consistently.

+1

> 
> Since we export memory.stat at the root now, we should probably just
> always charge the root instead of special-casing it all over the place
> and risking bugs.

Hm, we export memory.stat but not memory.current. Charging the root memcg
seems to be an extra atomic operation, which can be avoided.

I wonder if we can handle it in page_counter.c, so there will be a single
place where we do the check.

> 
> Indeed, it looks like there is at least one bug where the root-level
> memory.stat shows non-root slab objects, but not root ones, whereas it
> shows all anon and cache pages, root or no root.

I'll take a look.