Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1474112pxu; Fri, 16 Oct 2020 12:57:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx+qYAvM1bDumaC6nEhyGhalxCWRarLpc7tJysaj8cEipZMBE8U6e/dNC6StZEWCWkFHdde X-Received: by 2002:a17:906:2191:: with SMTP id 17mr5775932eju.449.1602878234072; Fri, 16 Oct 2020 12:57:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602878234; cv=none; d=google.com; s=arc-20160816; b=bW8/Vmmty1sjB4rPpss2C817srYcvsOLN1ox3e7yR8IXvpC/+5qFyz1UGGxk6XDNeJ 5CV6tx5JLBrBoOCyJyfwo6XwYrOvJuBiYER+Hu0d7pYCE7k0G7rvmllQCVWWB6I+X4MP PGj5MGmXTIT+DcTBcRCzXc0eIb/EUAQirW0GReozuGhN64aZHo6t9mASyHE1cLPkBQtk aksx/6uQCHAVQerZ4/IUSbjhPOpU0/AnSEvKVztO7u9IJYfT6vzgp3fpyBF1efRhpYuA eZ0Zz7yDWfRUtQcNLUrUpQeZcKAQlPkLTkK89JyG8LmvVh6WbtK3D3OGkNyF6N/PBXlg nGjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:dkim-signature; bh=Ury9+A5KVDrs2eb5ZK1ouytUwjEllvi61ZQxySjuOQc=; b=ns8xYOsIzUBMHDQ0a3GmpfN+TmyL6KTEglYmqX1G/Vpz+rpjH6lYQ5PsOzIu8OSjyZ 6cfJFdUiVIEF+LQLMW0Ag3EMrD5q2+VZpuW9eCh7jejMVW4Tc4/TsRH5g8sWJmb/fy2N Xm/Iae2TjzQjcnSHwY8vu35G3g+lvk1e6rb5GR3GieqUMIhBYa6i1ZxNfC97mXLq7s0G kNugAsGVfqsn3WQq5CF1vjlc38CJouK6ChJoniGxoq9R5WxElIrajmCO7dJ3IG3kBGIw Sqsgp6Y41nlxwZhBILH5nHguhCEmwaCHOvPf+iynEFwqFUfZoEL3+jYjtAPCjcs78ZG1 sByQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=teNqmeiJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dp6si2429033ejc.610.2020.10.16.12.56.51; Fri, 16 Oct 2020 12:57:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=teNqmeiJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2410849AbgJPQsS (ORCPT + 99 others); Fri, 16 Oct 2020 12:48:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2410672AbgJPQsS (ORCPT ); Fri, 16 Oct 2020 12:48:18 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 372DCC061755; Fri, 16 Oct 2020 09:48:19 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id o9so1574030plx.10; Fri, 16 Oct 2020 09:48:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Ury9+A5KVDrs2eb5ZK1ouytUwjEllvi61ZQxySjuOQc=; b=teNqmeiJlvw/8EElknbxAii907IB3Iql048rcuiAz+hov2vbEAQI6DmbEEB0PgBqIS 7AsiDkgc3KkeJspPx/YqhFjP1nSdzcAqm7KCcWZ/Bq906kNLJigkDc0XqLKo8hnxybpD S9K+wwpP2L3hbKt+1JAQrUxYoYTF2mtw49cd74YrUNhDuFPGHefUbGZwoZSfGNa0jY5Y +AQa/e5hzHH8FRDl1LMNZFQ/HglFja/d+X9MnQAi+NgQJdsPBBvvfnpHU4TBXexrnV5y UY29tcbZaxKq1ydZIsHNln24kDo9Rul/9QyDfvGAODlGB38maBWqi+RUTlJQhJ/Tbs7N el5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Ury9+A5KVDrs2eb5ZK1ouytUwjEllvi61ZQxySjuOQc=; b=fzkGxqtCI9hLHK7XXNM8e56FWuEVTX4SbL+q3eREVoS7zSYHwbKemon03kwOx8lsYY pas4dqf+WwzFeZXNYPn8RFx65i6BuYqUm7gpD8F7EH38MC6kfvcuTYkPs70wEUF69aVN RXr5GyAIepEWJXrfd6GGEa4JnZVZvdtze6Dz87YWQGLVTyFEMLYO6/kYVne9qnSwg1E3 oJtXQnHiTy6E2qbKa62zXTBHCUD+2Ah7dshXjoIpRFJjFFoecupepQ4e2ZTTgqbD0h8b a63oDQaSHPQS4oDi5zuZc3pgEp8zgSAgcV3QfMsEx7/1Uf1YB/lEty9npI/SK/tXLiUW 06mQ== X-Gm-Message-State: AOAM533qjy1ouked1dLptp8Z7Nkuw+f3QSxtGu+hZiW7e4IPpqAdaC26 z4ySTrGf9NrHkFPDWG21d0jh6+zdmpI= X-Received: by 2002:a17:90a:a613:: with SMTP id c19mr4996618pjq.119.1602866898277; Fri, 16 Oct 2020 09:48:18 -0700 (PDT) Received: from [10.67.48.230] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id k13sm3555325pfh.177.2020.10.16.09.48.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Oct 2020 09:48:17 -0700 (PDT) Subject: Re: [PATCH v2 1/2] arm64: dts: broadcom: clear the warnings caused by empty dma-ranges To: Arnd Bergmann , Zhen Lei Cc: Rob Herring , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list , Andy Gross , Bjorn Andersson , linux-arm-msm , devicetree , linux-arm-kernel , linux-kernel References: <20201016090833.1892-1-thunder.leizhen@huawei.com> <20201016090833.1892-2-thunder.leizhen@huawei.com> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: Date: Fri, 16 Oct 2020 09:48:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/20 4:01 AM, Arnd Bergmann wrote: > On Fri, Oct 16, 2020 at 11:09 AM Zhen Lei wrote: >> >> The scripts/dtc/checks.c requires that the node have empty "dma-ranges" >> property must have the same "#address-cells" and "#size-cells" values as >> the parent node. Otherwise, the following warnings is reported: >> >> arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14: Warning \ >> (dma_ranges_format): /usb:dma-ranges: empty "dma-ranges" property but \ >> its #address-cells (1) differs from / (2) >> arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14: Warning \ >> (dma_ranges_format): /usb:dma-ranges: empty "dma-ranges" property but \ >> its #size-cells (1) differs from / (2) >> >> Arnd Bergmann figured out why it's necessary: >> Also note that the #address-cells=<1> means that any device under >> this bus is assumed to only support 32-bit addressing, and DMA will >> have to go through a slow swiotlb in the absence of an IOMMU. >> >> Suggested-by: Arnd Bergmann >> Signed-off-by: Zhen Lei > > Acked-by: Arnd Bergmann > > I see that at least the 'bcd' and 'xhci' devices in fact try to > use 64-bit DMA. It would be good to test this on actual > hardware to ensure that it works correctly when this is enabled. > > Ideally avoiding the swiotlb bounce buffering should only > make it faster here, but there are many chips on which > 64-bit DMA is broken in some form. Is this change really an improvement though? This 'usb' pseudo bus node could just keep being defined with #address-cells = <1> and #size-cells = <1> so as to satisfy the 'reg' definition however we could just adjust dma-ranges to indicate full 64-bit addressing capability. Would not that work? -- Florian