Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: tdas=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0BE4FC433C9
Subject: Re: [PATCH v2 2/3] dt-bindings: clock: Add YAML schemas for the QCOM
 Camera clock bindings.
To:     Stephen Boyd <sboyd@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>
Cc:     David Brown <david.brown@linaro.org>,
        Rajendra Nayak <rnayak@codeaurora.org>,
        linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        Andy Gross <agross@kernel.org>, devicetree@vger.kernel.org,
        robh@kernel.org, robh+dt@kernel.org
References: <1602609110-11504-1-git-send-email-tdas@codeaurora.org>
 <1602609110-11504-3-git-send-email-tdas@codeaurora.org>
 <160264138707.310579.18410759318207954658@swboyd.mtv.corp.google.com>
From:   Taniya Das <tdas@codeaurora.org>
Message-ID: <73c47703-b6cf-5ab7-949b-45231f883d1c@codeaurora.org>
Date:   Sat, 17 Oct 2020 00:09:48 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.3.2
MIME-Version: 1.0
In-Reply-To: <160264138707.310579.18410759318207954658@swboyd.mtv.corp.google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Thanks for your review Stephen.

On 10/14/2020 7:39 AM, Stephen Boyd wrote:
> Quoting Taniya Das (2020-10-13 10:11:49)
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7180-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7180-camcc.yaml
>> new file mode 100644
>> index 0000000..07bd38e
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/qcom,sc7180-camcc.yaml
>> @@ -0,0 +1,73 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/clock/qcom,sc7180-camcc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Camera Clock & Reset Controller Binding for SC7180
>> +
>> +maintainers:
>> +  - Taniya Das <tdas@codeaurora.org>
>> +
>> +description: |
>> +  Qualcomm camera clock control module which supports the clocks, resets and
>> +  power domains on SC7180.
>> +
>> +  See also:
>> +  - dt-bindings/clock/qcom,camcc-sc7180.h.
> 
> Maybe just
> 
>       - dt-bindings/clock/qcom,camcc-sc7180.h
> 
> so that us copy/pasters don't have to delete anything.
> 

Will be fixed in the next patch.

>> +
>> +properties:
>> +  compatible:
>> +    const: qcom,sc7180-camcc
>> +
>> +  clocks:
>> +    items:
>> +      - description: Board XO source
>> +      - description: Camera_ahb clock from GCC
>> +      - description: Camera XO clock from GCC
>> +

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--