Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201015120851.229242-1-vitor@massaru.org>
In-Reply-To: <20201015120851.229242-1-vitor@massaru.org>
From:   Brendan Higgins <brendanhiggins@google.com>
Date:   Fri, 16 Oct 2020 11:42:58 -0700
Message-ID: <CAFd5g46TfFSTDO+SeYVrtJU8b+jYv_U9GWYhcGxGD4r1KHnxtw@mail.gmail.com>
Subject: Re: [PATCH] lib: kunit: Fix compilation test when using TEST_BIT_FIELD_COMPILE
To:     Vitor Massaru Iha <vitor@massaru.org>
Cc:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Shuah Khan <skhan@linuxfoundation.org>,
        KUnit Development <kunit-dev@googlegroups.com>,
        Johannes Berg <johannes@sipsolutions.net>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Oct 15, 2020 at 5:08 AM Vitor Massaru Iha <vitor@massaru.org> wrote:
>
> A build condition was missing around a compilation test, this compilation
> test comes from the original test_bitfield code.
>
> And removed unnecessary code for this test.
>
> Fixes: d2585f5164c2 ("lib: kunit: add bitfield test conversion to KUnit")
> Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
> Link: https://lore.kernel.org/linux-next/20201015163056.56fcc835@canb.auug.org.au/

Reviewed-by: Brendan Higgins <brendanhiggins@google.com>

Thanks for taking care of this so quickly!