Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1480226pxu; Fri, 16 Oct 2020 13:06:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxY1ODjJ7EGZdQCwJnQQhzG35Icchnk5yGLEI18wy091zFHLBlnF0Todl+LOcvktqM3/2wL X-Received: by 2002:a50:fa89:: with SMTP id w9mr5924372edr.235.1602878805943; Fri, 16 Oct 2020 13:06:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602878805; cv=none; d=google.com; s=arc-20160816; b=Uyv9MKL3A7B72QgHgUsk2JYJxDomKxN15fWbt4TiPeyt0xDenDpk6fT/6JNvh5NtC4 icjNCmVZNa31U5fGu6PfBL8dWlwbC2ftv7Km2B10Bo/nCkLZlgqvH2d0Vm/f0uEgqJej ljtLbQxHG8b53ggw+VuAyfj5TdYAbYwNjaSBCcjbFP/enYRo8Uw9ZBYNz1MO46bvHMR/ t1DLPm1wPTKBNbYMI/kl+3hE/7qW+uZmdgt9U7rLKCr6gpmjGB96NGmSm2INcoSALY9+ RkCTQFlg0nAlpH4zrBAXieU8o/1plJ9S6mUc0J3wwRTR7CflMvUowI0CJ1w39BauvF/R O/YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=CoJmX6IpKHCc1tXzEbve866HXUXHp5b/dVlN4op2hOs=; b=w8wIh2fRwLtXYNGmsuCtsstfh5J92I6iyA8yFTHntP1IpXeu9I23RTthGcgXWLPVua qX9iwgsCLdI9Fam7FhvhHixglCcpbdkvT5Cp5qUiqq6/uTbYsTgY/DxfAxn7LnQKeQAx FLyhUSfqhaDXfPyt44ewG6TMifkakkuQZnGonuFBYqr+682Aj1MlLwwmjXLbv6GA5//I pLlAblp4rlTwuT1mlbYXlrOtdLEpurDKSv78FKoXSo1laSJ8LhQtrkpHD/L/o7naD9CP jikixn0YLxjvzzG/liez5soDnLe7PiZ9PlusUHYGs8VWFubIAIoJ3tpU3NVhEROoF5cE PC1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=Hp8RiN00; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k25si2700983ejk.10.2020.10.16.13.06.23; Fri, 16 Oct 2020 13:06:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=Hp8RiN00; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408077AbgJPTbo (ORCPT + 99 others); Fri, 16 Oct 2020 15:31:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393210AbgJPTbo (ORCPT ); Fri, 16 Oct 2020 15:31:44 -0400 Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78038C0613D4 for ; Fri, 16 Oct 2020 12:31:44 -0700 (PDT) Received: by mail-io1-xd41.google.com with SMTP id b15so1438931iod.13 for ; Fri, 16 Oct 2020 12:31:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CoJmX6IpKHCc1tXzEbve866HXUXHp5b/dVlN4op2hOs=; b=Hp8RiN00S4UbjdiAH9fYjKe26CEMWqNt0uxrzzh6X+5MxleKUZPwAD9pujs7214dky Pf0yW+uAMNd1To0E0/TJeTiVydZALRturHnEmIp5eVrrJR4GapmlF2oku37oSnakQBhQ CUr2JzPGlYFHvEOWXJSfyW5k8cBIrDW88rYs8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CoJmX6IpKHCc1tXzEbve866HXUXHp5b/dVlN4op2hOs=; b=Mg+7wChhVfgN0bHPKYKBT6xDkK16TbFc5mLNhDQUmlLCsO9IAcNTIk0/lDLSFTQ2LI Kjbh+Vc04fuF7GE8zOHrRD7CxzhZCg45SOL8aJrccx7NL6ezv08x84FLZ9s2mqF7qdE1 /AcMLiIM9kQWsggAwOEwfgjap78RKdtJAe41/oSu0EDwdizUbCwWkfM8LbJ2No/cY+Um SGM7DB39li8kJQYp6f7vj/5o/DGzdCwnwve22Kbm6XTVSOyqYqYTClDtdQ4lCZOXSPbv auhQmKyJSpUIIECxykYYrtqGHTqMX7peRLMrhvSz6l25Gq5UdfdcAZbjUMOYoHs5ZcAS EY2A== X-Gm-Message-State: AOAM533sNcwXU/qdOdZq2YEpAildimxj9nr0xkhEBrKW6Us/Q5u51Bn7 9Fkls8zZuokSgWCABlSXfB1jzw== X-Received: by 2002:a5e:c90c:: with SMTP id z12mr1189989iol.150.1602876703661; Fri, 16 Oct 2020 12:31:43 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id x13sm3006127iob.8.2020.10.16.12.31.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Oct 2020 12:31:42 -0700 (PDT) Subject: Re: [PATCH] lib: kunit: Fix compilation test when using TEST_BIT_FIELD_COMPILE To: Brendan Higgins , Vitor Massaru Iha Cc: Stephen Rothwell , KUnit Development , Johannes Berg , Linux Kernel Mailing List , Linux Next Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , Shuah Khan References: <20201015120851.229242-1-vitor@massaru.org> From: Shuah Khan Message-ID: Date: Fri, 16 Oct 2020 13:31:41 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/20 12:42 PM, Brendan Higgins wrote: > On Thu, Oct 15, 2020 at 5:08 AM Vitor Massaru Iha wrote: >> >> A build condition was missing around a compilation test, this compilation >> test comes from the original test_bitfield code. >> >> And removed unnecessary code for this test. >> >> Fixes: d2585f5164c2 ("lib: kunit: add bitfield test conversion to KUnit") >> Signed-off-by: Vitor Massaru Iha >> Link: https://lore.kernel.org/linux-next/20201015163056.56fcc835@canb.auug.org.au/ > > Reviewed-by: Brendan Higgins > > Thanks for taking care of this so quickly! > Thank you both. Applied to linux-kselftest kunit branch I will send the pull request with this in a day or two. Added Reported-by for Stephen. Thanks for finding the problem. thanks, -- Shuah