Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1839117pxu; Sat, 17 Oct 2020 02:57:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyk/ndKKp6KlP9gIoXvKa130W0vte88J7hIbwRZjaMncKBFjbrWzuKD4w6PVZ52wHzahFaT X-Received: by 2002:a17:906:486:: with SMTP id f6mr7763952eja.473.1602928648962; Sat, 17 Oct 2020 02:57:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602928648; cv=none; d=google.com; s=arc-20160816; b=j67ypqmZjjNTjnOx2SwVsaaCx19kpsGmCFq5gJBhDp7D9BJ4g+SwJ7x0yXRl0OSURY shHryi/xglZcRmpLErDf2e4is/IC5ikYAkeGVCv++CrTsWCebRcKmgwkf5SrQ4dcAAsF LxBzvLNYkfX1v4jzNICnfGta3/6G7MtlCM49/s6nv0t8rdp+Y4V4ZPeDZr7G7N9c3Ot9 diFpD/V0PpUOGdt9VszSLeLuPq2jMwGT5fwXl3c+6dWUr7+KfoZq0do9FMDRyUG95AQ/ R4RBE02Tx5k7bY0mFTIx0/90SmH+pGBnTQDXxc19R5j23dyhgUhu7dUnlvlKWXAlQCWh c7mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:mime-version:message-id:date :sender:dkim-signature; bh=gYXoTy8UdH0s1OT5tLFrTZAYUQ4IBX8u576c7QZTu7o=; b=Vs4nSO4xqIoYm0Uy1tXw2fayQ2q/fhlV0TtaUGfRP1nJRo+lLzs/4FbM0sdDN+b+nJ lQjqV3ZsUVPdu2sNq7Q1Yh+JmQWVc28UHfAFXUwlM0vQMkf4582eIlghWeDPffeVAnxq 7pr2ZSp3STzYReosuDtYs//mw1gUsKnu+Cj/87mP/8P+eEIaXoxHpoS7aIAjcCkcI1Qr ISTg4Wcac2M0QFlSUcP2WDx4TwJB3o4L6hiTtOtdZCzxnsc2wzJbvvVUk4+xwS+9Yba2 Y8yGV2QpYJ2z1Vf7cZUvAFKacQZMGSzBVtaIVfuM/Q+GKyHoiFtOm8RU9QIFyW4lFmP/ ZpPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=rrrjzDx+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cy11si3558671edb.227.2020.10.17.02.57.06; Sat, 17 Oct 2020 02:57:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=rrrjzDx+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437159AbgJQGlc (ORCPT + 99 others); Sat, 17 Oct 2020 02:41:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437155AbgJQGlb (ORCPT ); Sat, 17 Oct 2020 02:41:31 -0400 Received: from mail-pg1-x54a.google.com (mail-pg1-x54a.google.com [IPv6:2607:f8b0:4864:20::54a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78910C0613D3 for ; Fri, 16 Oct 2020 23:41:31 -0700 (PDT) Received: by mail-pg1-x54a.google.com with SMTP id f2so2472774pgf.5 for ; Fri, 16 Oct 2020 23:41:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:message-id:mime-version:subject:from:to:cc; bh=gYXoTy8UdH0s1OT5tLFrTZAYUQ4IBX8u576c7QZTu7o=; b=rrrjzDx+j+nCaUrOb0wLsA6On/IqHbnnbFwI85l1uJ0rGXZSw+zOGrbvtS5PnXlmmm c9/rvAEbDfSZGfcLvsXzwgVDOoVO4FU/n9ZaUAq4dE3dGC7h1gCnFKxKds3BfLVSrWCL h49JLEmiUzcdMiw64wUAMYay+3n5bRIrlY+oidihC0KjrPZI8q05GNI2XJP1OmqFFIpg bgkHahykVJvBAs1Kt6Ht2BWg4YnzAC2JF96es+fOLEkd+7+t+Mvh+MnCiqGfMh6b+IPS 1daAB6zNcUj/uMcsTRUK6QcqWKrtrcXKHsfDkf+1Oy7ZA66JHtYY2rX0bSaFh1VLtGq0 3osA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:message-id:mime-version:subject:from :to:cc; bh=gYXoTy8UdH0s1OT5tLFrTZAYUQ4IBX8u576c7QZTu7o=; b=t9LRIqxvI9sd7YW5o4as/YZDrEBHlQLYZ+kZ+Ei1iehrG14uC+ldsr0RRzmCckKkt6 NdkhxT4/KhyPN6l5nTOBjtb6uxG0ZC+18Xcf2FjSwyPdnunsoh1eZyl8NgiNABbJRtA2 BjTuqWF8vjVvv0JXcP35ALiZcgaBAdNLi+GWpBQ+BnGOGg9Ma49k6fWQz0C/Cq7reDac 1uRDRXcR/fzdd6pXXkkRbICFEFv4RTZ6oU2hrp7Rkd6w4sBvTnpSAKIv5JA8GDkXuNv9 vceWLgg94iQHokMSRwVmlLrBBurtiDFosONlRSIZNPrkjB0rW9OxG9swHyDLF923PIot LvOw== X-Gm-Message-State: AOAM530gbOMSKGpUntuwJmx54FV66roBUIWr8N88H4f4NjYiG8wk+TV9 OKBqRD17+qzAvl6/zCR4l81qbvDJOWvV4g== Sender: "davidgow via sendgmr" X-Received: from spirogrip.svl.corp.google.com ([2620:15c:2cb:201:42a8:f0ff:fe4d:3548]) (user=davidgow job=sendgmr) by 2002:a63:c44c:: with SMTP id m12mr5945328pgg.92.1602916890770; Fri, 16 Oct 2020 23:41:30 -0700 (PDT) Date: Fri, 16 Oct 2020 23:41:07 -0700 Message-Id: <20201017064107.375174-1-davidgow@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.29.0.rc1.297.gfa9743e501-goog Subject: [PATCH] fat: Add KUnit tests for checksums and timestamps From: David Gow To: OGAWA Hirofumi , Brendan Higgins , shuah@kernel.org Cc: linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, David Gow Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add some basic sanity-check tests for the fat_checksum() function and the fat_time_unix2fat() and fat_time_fat2unix() functions. These unit tests verify these functions return correct output for a number of test inputs. These tests were inspored by -- and serve a similar purpose to -- the timestamp parsing KUnit tests in ext4[1]. [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/ext4/inode-test.c Signed-off-by: David Gow --- fs/fat/Kconfig | 13 +++ fs/fat/Makefile | 2 + fs/fat/fat_test.c | 197 ++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 212 insertions(+) create mode 100644 fs/fat/fat_test.c diff --git a/fs/fat/Kconfig b/fs/fat/Kconfig index 66532a71e8fd..fdef03b79c69 100644 --- a/fs/fat/Kconfig +++ b/fs/fat/Kconfig @@ -115,3 +115,16 @@ config FAT_DEFAULT_UTF8 Say Y if you use UTF-8 encoding for file names, N otherwise. See for more information. + +config FAT_KUNIT_TEST + tristate "Unit Tests for FAT filesystems" if !KUNIT_ALL_TESTS + select FAT_FS + depends on KUNIT + default KUNIT_ALL_TESTS + help + This builds the FAT KUnit tests + + For more information on KUnit and unit tests in general, please refer + to the KUnit documentation in Documentation/dev-tools/kunit + + If unsure, say N diff --git a/fs/fat/Makefile b/fs/fat/Makefile index 70645ce2f7fc..2b034112690d 100644 --- a/fs/fat/Makefile +++ b/fs/fat/Makefile @@ -10,3 +10,5 @@ obj-$(CONFIG_MSDOS_FS) += msdos.o fat-y := cache.o dir.o fatent.o file.o inode.o misc.o nfs.o vfat-y := namei_vfat.o msdos-y := namei_msdos.o + +obj-$(CONFIG_FAT_KUNIT_TEST) += fat_test.o diff --git a/fs/fat/fat_test.c b/fs/fat/fat_test.c new file mode 100644 index 000000000000..c1b4348b9b3b --- /dev/null +++ b/fs/fat/fat_test.c @@ -0,0 +1,197 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * KUnit tests for FAT filesystems. + * + * Copyright (C) 2020 Google LLC. + * Author: David Gow + */ + +#include + +#include "fat.h" + +static void fat_checksum_test(struct kunit *test) +{ + /* With no extension. */ + KUNIT_EXPECT_EQ(test, fat_checksum("VMLINUX "), 44); + /* With 3-letter extension. */ + KUNIT_EXPECT_EQ(test, fat_checksum("README TXT"), 115); + /* With short (1-letter) extension. */ + KUNIT_EXPECT_EQ(test, fat_checksum("ABCDEFGHA "), 98); +} + + +struct fat_timestamp_testcase { + const char *name; + struct timespec64 ts; + __le16 time; + __le16 date; + u8 cs; + int time_offset; +}; + +const static struct fat_timestamp_testcase time_test_cases[] = { + { + .name = "Earliest possible UTC (1980-01-01 00:00:00)", + .ts = {.tv_sec = 315532800LL, .tv_nsec = 0L}, + .time = 0, + .date = 33, + .cs = 0, + .time_offset = 0, + }, + { + .name = "Latest possible UTC (2107-12-31 23:59:58)", + .ts = {.tv_sec = 4354819198LL, .tv_nsec = 0L}, + .time = 49021, + .date = 65439, + .cs = 0, + .time_offset = 0, + }, + { + .name = "Earliest possible (UTC-11) (== 1979-12-31 13:00:00 UTC)", + .ts = {.tv_sec = 315493200LL, .tv_nsec = 0L}, + .time = 0, + .date = 33, + .cs = 0, + .time_offset = 11 * 60, + }, + { + .name = "Latest possible (UTC+11) (== 2108-01-01 10:59:58 UTC)", + .ts = {.tv_sec = 4354858798LL, .tv_nsec = 0L}, + .time = 49021, + .date = 65439, + .cs = 0, + .time_offset = -11 * 60, + }, + { + .name = "Leap Day / Year (1996-02-29 00:00:00)", + .ts = {.tv_sec = 825552000LL, .tv_nsec = 0L}, + .time = 0, + .date = 8285, + .cs = 0, + .time_offset = 0, + }, + { + .name = "Year 2000 is leap year (2000-02-29 00:00:00)", + .ts = {.tv_sec = 951782400LL, .tv_nsec = 0L}, + .time = 0, + .date = 10333, + .cs = 0, + .time_offset = 0, + }, + { + .name = "Year 2100 not leap year (2100-03-01 00:00:00)", + .ts = {.tv_sec = 4107542400LL, .tv_nsec = 0L}, + .time = 0, + .date = 61537, + .cs = 0, + .time_offset = 0, + }, + { + .name = "Leap year + timezone UTC+1 (== 2004-02-29 00:30:00 UTC)", + .ts = {.tv_sec = 1078014600LL, .tv_nsec = 0L}, + .time = 48064, + .date = 12380, + .cs = 0, + .time_offset = -60, + }, + { + .name = "Leap year + timezone UTC-1 (== 2004-02-29 23:30:00 UTC)", + .ts = {.tv_sec = 1078097400LL, .tv_nsec = 0L}, + .time = 960, + .date = 12385, + .cs = 0, + .time_offset = 60, + }, + { + .name = "VFAT odd-second resolution (1999-12-31 23:59:59)", + .ts = {.tv_sec = 946684799LL, .tv_nsec = 0L}, + .time = 49021, + .date = 10143, + .cs = 100, + .time_offset = 0, + }, + { + .name = "VFAT 10ms resolution (1980-01-01 00:00:00:0010)", + .ts = {.tv_sec = 315532800LL, .tv_nsec = 10000000L}, + .time = 0, + .date = 33, + .cs = 1, + .time_offset = 0, + }, +}; + +static void fat_time_fat2unix_test(struct kunit *test) +{ + struct msdos_sb_info fake_sb; + int i; + struct timespec64 ts; + + for (i = 0; i < ARRAY_SIZE(time_test_cases); ++i) { + fake_sb.options.tz_set = 1; + fake_sb.options.time_offset = time_test_cases[i].time_offset; + + fat_time_fat2unix(&fake_sb, &ts, + time_test_cases[i].time, + time_test_cases[i].date, + time_test_cases[i].cs); + KUNIT_EXPECT_EQ_MSG(test, + time_test_cases[i].ts.tv_sec, + ts.tv_sec, + "Timestamp mismatch (seconds) in case \"%s\"\n", + time_test_cases[i].name); + KUNIT_EXPECT_EQ_MSG(test, + time_test_cases[i].ts.tv_nsec, + ts.tv_nsec, + "Timestamp mismatch (nanoseconds) in case \"%s\"\n", + time_test_cases[i].name); + } +} + +static void fat_time_unix2fat_test(struct kunit *test) +{ + struct msdos_sb_info fake_sb; + int i; + __le16 date, time; + u8 cs; + + for (i = 0; i < ARRAY_SIZE(time_test_cases); ++i) { + fake_sb.options.tz_set = 1; + fake_sb.options.time_offset = time_test_cases[i].time_offset; + + fat_time_unix2fat(&fake_sb, &time_test_cases[i].ts, + &time, &date, &cs); + KUNIT_EXPECT_EQ_MSG(test, + time_test_cases[i].time, + time, + "Time mismatch in case \"%s\"\n", + time_test_cases[i].name); + KUNIT_EXPECT_EQ_MSG(test, + time_test_cases[i].date, + date, + "Date mismatch in case \"%s\"\n", + time_test_cases[i].name); + KUNIT_EXPECT_EQ_MSG(test, + time_test_cases[i].cs, + cs, + "Centisecond mismatch in case \"%s\"\n", + time_test_cases[i].name); + } +} + +static struct kunit_case fat_test_cases[] = { + KUNIT_CASE(fat_checksum_test), + KUNIT_CASE(fat_time_fat2unix_test), + KUNIT_CASE(fat_time_unix2fat_test), + {}, +}; + +static struct kunit_suite fat_test_suite = { + .name = "fat_test", + .test_cases = fat_test_cases, +}; + +kunit_test_suites(&fat_test_suite); + +MODULE_LICENSE("GPL v2"); + -- 2.29.0.rc1.297.gfa9743e501-goog