Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1861299pxu; Sat, 17 Oct 2020 03:48:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJziFBPMaqDOpvrAudDMnX8TTeFPmLXys7DT0lL0xl9E9esRPBI+kiLDhHJIrEziCmUTGPlB X-Received: by 2002:a50:fb0d:: with SMTP id d13mr8715018edq.85.1602931693566; Sat, 17 Oct 2020 03:48:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602931693; cv=none; d=google.com; s=arc-20160816; b=HJ+Lb7EtmsKLu1FSqLgyMykVvW2NwzHzyaTtjjozMC0QnMwDIydu74e0Ywbsx1vytf ev1wCkSwdmL7mmGTF8xG5oFuWm1On2Qi4wT5zrjRbRYcR2tslfS/VX9H+Fo+o2GHfxuV MaAVY+MlJhjPz0RzgshNDanCQdhA/fDmd/+6JG7P5wJlUm7R4o+trKl23wLzTbWbKKky X6JuilRL/jfgkb0kt0aT5Q0ZForQJk5R9xk6UCP0/ufTt97V/fJdsi42W73wDzFfvFIp rUQ/4GXB6rMwUt9OGpIkEBFJXaTRm0sBvbcdMX8FiM/7p0fAHQ5hJ4sVBOoKzPR4BxXr W1Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=syV8qCnR9RjadzZoAtRjADeGCpwhW0Tk9NohJtR7ntA=; b=vKZ9Pzi0n6uyrwBi802PAjEIm7mo9fQejc2Xbe1KjJ+dbmRCwGLB2D7hrbPF03sE/4 z7KAhR0QXOrh3FiVgGHE7nNB0wy08r7LCsVV543enMXZozeUNpoP8k9M8v85679gXqhM ZEkeO1h1Y2xV5bQ8K5PuvwwaeYA5IhggAAa9zD+2KiIV6DYNfB9szy9olqnfPueAdr4u 1+se5dflO2v+aCkagG/Ag+PtabOH3bLHwHstDXwL13PoVVKDcKjgpx7qTtMswo/NdBnP w0uNxMZqPtLaKYJ7k924TaRRNdXCP6JLoTH8HCMxCIpPGYph0PefQudY7en93HhxAXiN Ze8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1ethAoxx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ot7si3467203ejb.663.2020.10.17.03.47.51; Sat, 17 Oct 2020 03:48:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1ethAoxx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437630AbgJQIMC (ORCPT + 99 others); Sat, 17 Oct 2020 04:12:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:38288 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2408113AbgJQIMC (ORCPT ); Sat, 17 Oct 2020 04:12:02 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BD6042072D; Sat, 17 Oct 2020 08:11:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602922320; bh=Fdv+SrEB+S3f6Ce4YSY8YMKKjArM3G8B7oba96e+lHY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1ethAoxxp66PI9AxEwMMl3Hb230JkEFp70omfMXrxQD9Yq8F/t9FFT55cg5XSdP1n 5gaXgbTSQnXYCYe76blV1mo2gkkXLlRR2qZJx2bnNtvi6GqX/9wGFLOIMNyCs+4DGw OJpTcadIxsRhyPlqrKDmUv1hSlJUKkdnMmVzJW2g= Date: Sat, 17 Oct 2020 10:12:49 +0200 From: Greg Kroah-Hartman To: Pavel Machek Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, syzbot+009f546aa1370056b1c2@syzkaller.appspotmail.com, Anant Thazhemadam Subject: Re: [PATCH 4.19 14/21] staging: comedi: check validity of wMaxPacketSize of usb endpoints found Message-ID: <20201017081249.GA310845@kroah.com> References: <20201016090437.301376476@linuxfoundation.org> <20201016090437.987989197@linuxfoundation.org> <20201016130626.GA4335@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201016130626.GA4335@amd> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 16, 2020 at 03:06:27PM +0200, Pavel Machek wrote: > Hi! > > > From: Anant Thazhemadam > > > > commit e1f13c879a7c21bd207dc6242455e8e3a1e88b40 upstream. > > > > While finding usb endpoints in vmk80xx_find_usb_endpoints(), check if > > wMaxPacketSize = 0 for the endpoints found. > > > > Some devices have isochronous endpoints that have wMaxPacketSize = 0 > > (as required by the USB-2 spec). > > However, since this doesn't apply here, wMaxPacketSize = 0 can be > > considered to be invalid. > > > > Reported-by: syzbot+009f546aa1370056b1c2@syzkaller.appspotmail.com > > Tested-by: syzbot+009f546aa1370056b1c2@syzkaller.appspotmail.com > > Signed-off-by: Anant Thazhemadam > > Cc: stable > > Link: https://lore.kernel.org/r/20201010082933.5417-1-anant.thazhemadam@gmail.com > > Signed-off-by: Greg Kroah-Hartman > > Signed-off-by: Greg Kroah-Hartman > > Why duplicate Sign-off? My scripts, I missed this :(