Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750767AbWHKIMD (ORCPT ); Fri, 11 Aug 2006 04:12:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750769AbWHKIMD (ORCPT ); Fri, 11 Aug 2006 04:12:03 -0400 Received: from mx1.redhat.com ([66.187.233.31]:23774 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1750767AbWHKIMA (ORCPT ); Fri, 11 Aug 2006 04:12:00 -0400 From: David Howells In-Reply-To: <20060810125306.61425f94.akpm@osdl.org> References: <20060810125306.61425f94.akpm@osdl.org> To: Andrew Morton Cc: Miklos Szeredi , zam@namesys.com, linux-kernel@vger.kernel.org, David Howells Subject: Re: [PATCH try #2] fuse: fix error case in fuse_readpages X-Mailer: MH-E 8.0; nmh 1.1; GNU Emacs 22.0.50 Date: Fri, 11 Aug 2006 09:11:47 +0100 Message-ID: <18358.1155283907@warthog.cambridge.redhat.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 722 Lines: 19 Andrew Morton wrote: > > Don't let fuse_readpages leave the @pages list not empty when exiting > > on error. > > > > Oh dear. read_cache_pages_release_page() is not a readahead thing. It is > a dhowells fscache thing. The pages passed to read_cache_pages() may already be marked with metadata information (such as to-be-cached marks from NFS or AFS calling FS-Cache), so we can't just ditch the pages on an error, we have to clean them up properly. David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/