Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 18 Oct 2020 13:00:48 -0400
From:   William Breathitt Gray <vilhelm.gray@gmail.com>
To:     David Lechner <david@lechnology.com>
Cc:     jic23@kernel.org, kamel.bouhara@bootlin.com, gwendal@chromium.org,
        alexandre.belloni@bootlin.com, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com,
        patrick.havelange@essensium.com, fabrice.gasnier@st.com,
        mcoquelin.stm32@gmail.com, alexandre.torgue@st.com
Subject: Re: [PATCH v5 1/5] counter: Internalize sysfs interface code
Message-ID: <20201018170048.GF231549@shinobu>
References: <cover.1601170670.git.vilhelm.gray@gmail.com>
 <e38f6dc3a08bf2510034334262776a6ed1df8b89.1601170670.git.vilhelm.gray@gmail.com>
 <17c22445-d523-07f8-d1ff-59e8dbc73cc8@lechnology.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="GV0iVqYguTV4Q9ER"
Content-Disposition: inline
In-Reply-To: <17c22445-d523-07f8-d1ff-59e8dbc73cc8@lechnology.com>
Precedence: bulk


--GV0iVqYguTV4Q9ER
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 14, 2020 at 08:38:40PM -0500, David Lechner wrote:
> On 9/26/20 9:18 PM, William Breathitt Gray wrote:
> > +static ssize_t counter_comp_u8_store(struct device *dev,
> > +				     struct device_attribute *attr,
> > +				     const char *buf, size_t len)
> > +{
> > +	const struct counter_attribute *const a =3D to_counter_attribute(attr=
);
> > +	struct counter_device *const counter =3D dev_get_drvdata(dev);
> > +	struct counter_count *const count =3D a->parent;
> > +	struct counter_synapse *const synapse =3D a->comp.priv;
> > +	const struct counter_available *const avail =3D a->comp.priv;
> > +	int err;
> > +	bool bool_data;
> > +	u8 data;
> > +
> > +	switch (a->comp.type) {
> > +	case COUNTER_COMP_BOOL:
> > +		err =3D kstrtobool(buf, &bool_data);
> > +		data =3D bool_data;
> > +		break;
> > +	case COUNTER_COMP_FUNCTION:
> > +		err =3D find_in_string_array(&data, count->functions_list,
> > +					   count->num_functions, buf,
> > +					   counter_function_str);
> > +		break;
> > +	case COUNTER_COMP_SYNAPSE_ACTION:
> > +		err =3D find_in_string_array(&data, synapse->actions_list,
> > +					   synapse->num_actions, buf,
> > +					   counter_synapse_action_str);
> > +		break;
> > +	case COUNTER_COMP_ENUM:
> > +		err =3D __sysfs_match_string(avail->strs, avail->num_items, buf);
> > +		data =3D err;
> > +		break;
> > +	case COUNTER_COMP_COUNT_MODE:
> > +		err =3D find_in_string_array(&data, avail->enums,
> > +					   avail->num_items, buf,
> > +					   counter_count_mode_str);
> > +		break;
> > +	default:
> > +		err =3D kstrtou8(buf, 0, &data);
> > +		break;
> > +	}
>=20
> In this function, return values are not always errors. So it would make
> sense to call the err variable ret instead and check for ret < 0 below.
>=20
> Setting enums to a value with index > 0 fails currently because of this.

Thank you for pointing this out, I'll fix this.

William Breathitt Gray

> > +	if (err)
> > +		return err;
> > +
> > +	switch (a->scope) {
> > +	case COUNTER_SCOPE_DEVICE:
> > +		err =3D a->comp.device_u8_write(counter, data);
> > +		break;
> > +	case COUNTER_SCOPE_SIGNAL:
> > +		err =3D a->comp.signal_u8_write(counter, a->parent, data);
> > +		break;
> > +	case COUNTER_SCOPE_COUNT:
> > +		if (a->comp.type =3D=3D COUNTER_COMP_SYNAPSE_ACTION)
> > +			err =3D a->comp.action_write(counter, count, synapse,
> > +						   data);
> > +		else
> > +			err =3D a->comp.count_u8_write(counter, count, data);
> > +		break;
> > +	}
> > +	if (err)
> > +		return err;
> > +
> > +	return len;
> > +}
>=20

--GV0iVqYguTV4Q9ER
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAl+MdMAACgkQhvpINdm7
VJKeBw//TwierwwomvmWRWfZmlmzByWQ0Q7nkMtO2BRaENfqcAsKHsPcQL6HjwT7
73s0pwxRoUV/l2SXpb/YQCAGwVHdVLEDXPxYRIHFoC5dCV86zlQxztpNjYhQSi7E
z6ztS9vXxVr4zFxvcOErIujSx1OCfEFMuXNeM7jguaOdy0Pj0l0o8eJ+crxlOgsP
YfTSnWFCF99W/An/uealjV379jc+TywdEiWOHbtB5vLgvQZ/lpLSLLqypq1i+lXX
wcFeTJxqrjGRzbCX7wnK5OEqBMSCv8rSSM5/iSW82KPcN2bI+8GjlIbdOorgrQHy
+o3d0fEAgUU8F7twCEPtA08hZuEbtdlSC8R8aL7nAplRZ0TnLwv1W9VR7nwZ/X9Y
MD2nMl6BX8t4sbccQCa+RYhbgD8DuEeSBRqRPDORpljKF2S8i6yfDxqlXJPkZ3po
DvjaPhCJr9jVgb300ZFYhtELNkH1zrcvlY5l8QIX/WxDYmASg//h/+v4duOxBPuw
DYysQMzezGzsWuUzsJppcRsSyPFDFrBWo6s/irk8tn0rRkr54vLhMmvXWxa0G0fX
YdrtsY08lCP2LzAOQ51axaqq/w9xKZbfgq3efugA3lPdpvMsCR3Iivu10tdEcoaZ
APv6EFt2nxwgyWPIxmDBaSpl9jnTW1znv/KeDR9ZrA8Z/rvhAAI=
=rCo9
-----END PGP SIGNATURE-----

--GV0iVqYguTV4Q9ER--