Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751042AbWHKJVq (ORCPT ); Fri, 11 Aug 2006 05:21:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751050AbWHKJVq (ORCPT ); Fri, 11 Aug 2006 05:21:46 -0400 Received: from wohnheim.fh-wedel.de ([213.39.233.138]:32474 "EHLO wohnheim.fh-wedel.de") by vger.kernel.org with ESMTP id S1751019AbWHKJVp (ORCPT ); Fri, 11 Aug 2006 05:21:45 -0400 Date: Fri, 11 Aug 2006 11:21:32 +0200 From: =?iso-8859-1?Q?J=F6rn?= Engel To: Thomas Klein Cc: Michael Neuling , Alexey Dobriyan , Jan-Bernd Themann , netdev@vger.kernel.org, Thomas Klein , linuxppc-dev@ozlabs.org, Christoph Raisch , linux-kernel@vger.kernel.org, Marcus Eder Subject: Re: [PATCH 3/6] ehea: queue management Message-ID: <20060811092132.GA4137@wohnheim.fh-wedel.de> References: <44D99F38.8010306@de.ibm.com> <20060811000540.200CE67B6B@ozlabs.org> <20060811003204.GA6935@martell.zuzino.mipt.ru> <20060811004602.23EB467B64@ozlabs.org> <44DC319A.10802@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <44DC319A.10802@de.ibm.com> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1060 Lines: 29 On Fri, 11 August 2006 09:28:26 +0200, Thomas Klein wrote: > Michael Neuling wrote: > >>>>+static inline u32 map_swqe_size(u8 swqe_enc_size) > >>>>+static inline u32|map_rwqe_size(u8 rwqe_enc_size) > > > Agreed. Functions were replaced by a single map_wqe_size() function. Just a general thing, try to avoid having two identifiers that are near-100% identical. As seen in this thread, they are _very_ easy to confuse. Ime, there are two methods to avoid this. One is to make the identifiers longer, something like "map_seek_wqe_size" and "map_read_wqe_size". The other is to make them shorter, just "s" and "r" is less confusing than the above. Which method works best depends on many things, including personal taste. J?rn -- And spam is a useful source of entropy for /dev/random too! -- Jasmine Strong - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/