Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932221AbWHKM7G (ORCPT ); Fri, 11 Aug 2006 08:59:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932228AbWHKM7G (ORCPT ); Fri, 11 Aug 2006 08:59:06 -0400 Received: from nf-out-0910.google.com ([64.233.182.189]:13580 "EHLO nf-out-0910.google.com") by vger.kernel.org with ESMTP id S932221AbWHKM66 (ORCPT ); Fri, 11 Aug 2006 08:58:58 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=rjdtWTAAMh/z2jGOc5vN3/ZnnUJ34wbHwahSrPnv1AhYVgumBlGtvE+jVuPG08twkZlbvPK+cmsv+RH0PstIY9wgD4gMSnUnhm5zwsfnEK0HJCqpFA6q5DQoA/2dkPYNUGFmxYYfEPLFedYKTL/f3Rvjo8keiO3hsDJNqIKLmBU= Message-ID: Date: Fri, 11 Aug 2006 08:58:53 -0400 From: "Dmitry Torokhov" To: "Richard Purdie" Subject: Re: [patch 5/6] Convert to use mutexes instead of semaphores Cc: LKML , "Michael Hanselmann" , "Antonino A. Daplas" In-Reply-To: <20060811050611.530817371.dtor@insightbb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20060811050310.958962036.dtor@insightbb.com> <20060811050611.530817371.dtor@insightbb.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 976 Lines: 28 On 8/11/06, Dmitry Torokhov wrote: > Backlight: convert to use mutexes instead of semaphores > Apparently I missed that several drivers also use bd->sem so they need to be converted too... But what is it with the drivers: static void aty128_bl_set_power(struct fb_info *info, int power) { mutex_lock(&info->bl_mutex); up(&info->bl_dev->sem); info->bl_dev->props->power = power; __aty128_bl_update_status(info->bl_dev); down(&info->bl_dev->sem); mutex_unlock(&info->bl_mutex); } Why we are doing up() before down()??? And it is in almost every driver that uses backlight... Do I need more coffee? [CC-ing bunch of people trying to get an answer...] -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/