Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751115AbWHKNmV (ORCPT ); Fri, 11 Aug 2006 09:42:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751118AbWHKNmV (ORCPT ); Fri, 11 Aug 2006 09:42:21 -0400 Received: from hansmi.home.forkbomb.ch ([213.144.146.165]:19741 "EHLO hansmi.home.forkbomb.ch") by vger.kernel.org with ESMTP id S1751115AbWHKNmU (ORCPT ); Fri, 11 Aug 2006 09:42:20 -0400 Date: Fri, 11 Aug 2006 15:42:15 +0200 From: Michael Hanselmann To: Dmitry Torokhov Cc: Richard Purdie , LKML , "Antonino A. Daplas" Subject: Re: [patch 5/6] Convert to use mutexes instead of semaphores Message-ID: <20060811134215.GA26017@hansmi.ch> References: <20060811050310.958962036.dtor@insightbb.com> <20060811050611.530817371.dtor@insightbb.com> <1155302169.19959.16.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WIyZ46R2i8wDzkSu" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1170 Lines: 36 --WIyZ46R2i8wDzkSu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 11, 2006 at 09:34:44AM -0400, Dmitry Torokhov wrote: > How about we add backlight_set_power(&bd, power) to the backlight core > to take care of proper locking for drivers? I've tried to add several functions to the backlight core ({s,g}et_{brightness,power}) and they were rejected. Thus all the locking is spread over the drivers. I agree it's faulty right now. It's still easier to move to backlight core functions than to fix all the drivers. Because I am responsible/wrote for the broken code, how should I proceed? --WIyZ46R2i8wDzkSu Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQFE3Ik36J0saEpRu+oRAsoiAJ0XjLDlev3bKuvm7aSiZvVbDjMr6gCeK7a0 FlIzZdK3l6y8UngH2ag9pYE= =rf4q -----END PGP SIGNATURE----- --WIyZ46R2i8wDzkSu-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/