Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 19 Oct 2020 10:04:08 +0200
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>
To:     Gregory CLEMENT <gregory.clement@bootlin.com>,
        Jason Cooper <jason@lakedaemon.net>,
        Andrew Lunn <andrew@lunn.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Andre Heider <a.heider@gmail.com>,
        =?utf-8?Q?G=C3=A9rald?= Kerma <gerald@gk2.net>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: marvell: espressobin: Add support for LED2
Message-ID: <20201019080408.iv7vmj63cgt2i6vg@pali>
References: <20201006124455.16617-1-pali@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20201006124455.16617-1-pali@kernel.org>
User-Agent: NeoMutt/20180716
Precedence: bulk

Hello! Gregory, I would like to remind you following patch.

Andre, if you have a time, could you test it too?

On Tuesday 06 October 2020 14:44:55 Pali Rohár wrote:
> LED2 is connected to MPP1_2 pin. It is working only on V7 boards.
> V5 boards have hw bug which cause that LED2 is non-working.
> 
> So enable LED2 only for Espressobin V7 boards.
> 
> Note that LED1 is connected to LED_WLAN# pin on miniPCIe card and LED3 to
> power supply. Therefore on Espressobin board only LED2 can be controlled
> directly from the host. LED1 is possible to control via WiFi card inserted
> in miniPCIe slot if driver for particular card supports it.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Tested-by: Gérald Kerma <gerald@gk2.net>
> 
> ---
> 
> Previous version of this patch was sent by Uwe in March 2018, but it did
> not work on any tested V5 board. Now we know it was due to V5 HW bug.
> 
> https://lore.kernel.org/linux-arm-kernel/20180321105005.18426-3-u.kleine-koenig@pengutronix.de/
> ---
>  .../dts/marvell/armada-3720-espressobin-v7-emmc.dts |  4 ++++
>  .../boot/dts/marvell/armada-3720-espressobin-v7.dts |  4 ++++
>  .../boot/dts/marvell/armada-3720-espressobin.dtsi   | 13 +++++++++++++
>  3 files changed, 21 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> index 4775a7eda481..75401eab4d42 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> @@ -39,3 +39,7 @@
>  &sdhci0 {
>  	status = "okay";
>  };
> +
> +&led2 {
> +	status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> index c47a93978386..48a7f50fb427 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> @@ -34,3 +34,7 @@
>  &switch0port3 {
>  	label = "wan";
>  };
> +
> +&led2 {
> +	status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> index 8a1c678bea5f..daffe136c523 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> @@ -41,6 +41,19 @@
>  			  3300000 0x0>;
>  		enable-active-high;
>  	};
> +
> +	led2: gpio-led2 {
> +		/* led2 is working only on v7 board */
> +		status = "disabled";
> +
> +		compatible = "gpio-leds";
> +
> +		led2 {
> +			label = "led2";
> +			gpios = <&gpionb 2 GPIO_ACTIVE_LOW>;
> +			default-state = "off";
> +		};
> +	};
>  };
>  
>  /* J9 */
> -- 
> 2.20.1
>