Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp3087613pxu; Mon, 19 Oct 2020 03:43:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyryAbj0gqYi44kE7CkdkMtyjH3ZoUDTdbXu3jnf+WFJzDNWmU2arlaorE/GttCycAP6dr/ X-Received: by 2002:aa7:cb82:: with SMTP id r2mr17463310edt.306.1603104232811; Mon, 19 Oct 2020 03:43:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603104232; cv=none; d=google.com; s=arc-20160816; b=h0iWbRZeRHI7wXRtHLL9jpmtcMx9+vLVnkI2gqDq0l5/Ec+4ZsPFiaMzTSqLi7dkU5 evZrVKrXVCQMvyvj/fHDhzLA+7GAMkmg5yNSUfYsN1RADjPhgGpVun1tZtSoSBdVjan+ Fw8P3gkdnUCIPpDWRv4UbkpAFSYLSidD686uXBdi+HQFVX6UTy7hINHI1kPLQ6FUlEHW HO2mSkZAeSja4mz1PgE77zuW1Dgv2dQUMocnM3pPNiW70pC/ncnLg+UitCB4C08Cc4u/ 9EcD1H/LyOPiDdsMFRXQ78xDPuqvuWjS5+0LPpX5q02sZ6YwjtOqybmOqqRC5DCzwdR5 LKiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject; bh=D40MkKsbmNM7eJHRw9yMHJ/6F4Z0uLt/kXNwG3/+TQA=; b=U3qC1alzd+Z7MdtP9K7sdEWDwMJgoVNI08Vzp8oeXwOxtoS+BswmZ/UCmC5oyPrNV7 52s5gOFrCtJuegBY64Q0u4DrEb7PtgiB9B9mdFbn5UGzlyzPAc1PsMngX7qVUyzy7MoN CTYT5jvMbhZM6nfm+vw9tAdxvc6wIi1fzn8i7BsDjALrtse4D94KYG26DAG5E/4N5sfs 2ddBQC5DYn3Z4jKofMmVlQ6oYNKh3Bulglmdp2LS7AbWcfpTLMxXjqh4TviZSuLVREeg I6pYdWQeIvPZVQEKh2x7FkFjpzuJortyUH7XlMYBo5xY4yIVR+ux24UpKxkxrZn8cJc3 t9IQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 8si7584252edx.505.2020.10.19.03.43.30; Mon, 19 Oct 2020 03:43:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729845AbgJSJF2 (ORCPT + 99 others); Mon, 19 Oct 2020 05:05:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728124AbgJSJF2 (ORCPT ); Mon, 19 Oct 2020 05:05:28 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F36E9C0613CE for ; Mon, 19 Oct 2020 02:05:27 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kUR6T-0006Ac-C5; Mon, 19 Oct 2020 11:05:17 +0200 Received: from [IPv6:2a03:f580:87bc:d400:ea52:556b:af36:c63f] (2a03-f580-87bc-d400-ea52-556b-af36-c63f.ip6.dokom21.de [IPv6:2a03:f580:87bc:d400:ea52:556b:af36:c63f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mkl@blackshift.org", Issuer "StartCom Class 1 Client CA" (not verified)) (Authenticated sender: mkl@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id C59EC57BE6B; Mon, 19 Oct 2020 09:05:15 +0000 (UTC) Subject: Re: [PATCH V2 8/8] can: flexcan: add CAN wakeup function for i.MX8QM To: Joakim Zhang , "robh+dt@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , Aisheng Dong Cc: "kernel@pengutronix.de" , dl-linux-imx , Ying Liu , "linux-can@vger.kernel.org" , Pankaj Bansal , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20201019155737.26577-1-qiangqing.zhang@nxp.com> <20201019155737.26577-9-qiangqing.zhang@nxp.com> <3ca1d3e9-ef13-283f-8301-68c657628e41@pengutronix.de> <0e871906-e179-a2ea-1379-d0194c9d58fe@pengutronix.de> From: Marc Kleine-Budde Autocrypt: addr=mkl@pengutronix.de; prefer-encrypt=mutual; keydata= mQINBFFVq30BEACtnSvtXHoeHJxG6nRULcvlkW6RuNwHKmrqoksispp43X8+nwqIFYgb8UaX zu8T6kZP2wEIpM9RjEL3jdBjZNCsjSS6x1qzpc2+2ivjdiJsqeaagIgvy2JWy7vUa4/PyGfx QyUeXOxdj59DvLwAx8I6hOgeHx2X/ntKAMUxwawYfPZpP3gwTNKc27dJWSomOLgp+gbmOmgc 6U5KwhAxPTEb3CsT5RicsC+uQQFumdl5I6XS+pbeXZndXwnj5t84M+HEj7RN6bUfV2WZO/AB Xt5+qFkC/AVUcj/dcHvZwQJlGeZxoi4veCoOT2MYqfR0ax1MmN+LVRvKm29oSyD4Ts/97cbs XsZDRxnEG3z/7Winiv0ZanclA7v7CQwrzsbpCv+oj+zokGuKasofzKdpywkjAfSE1zTyF+8K nxBAmzwEqeQ3iKqBc3AcCseqSPX53mPqmwvNVS2GqBpnOfY7Mxr1AEmxdEcRYbhG6Xdn+ACq Dq0Db3A++3PhMSaOu125uIAIwMXRJIzCXYSqXo8NIeo9tobk0C/9w3fUfMTrBDtSviLHqlp8 eQEP8+TDSmRP/CwmFHv36jd+XGmBHzW5I7qw0OORRwNFYBeEuiOIgxAfjjbLGHh9SRwEqXAL kw+WVTwh0MN1k7I9/CDVlGvc3yIKS0sA+wudYiselXzgLuP5cQARAQABtCZNYXJjIEtsZWlu ZS1CdWRkZSA8bWtsQHBlbmd1dHJvbml4LmRlPokCVAQTAQoAPgIbAwIeAQIXgAULCQgHAwUV CgkICwUWAgMBABYhBMFAC6CzmJ5vvH1bXCte4hHFiupUBQJfEWX4BQkQo2czAAoJECte4hHF iupUvfMP/iNtiysSr5yU4tbMBzRkGov1/FjurfH1kPweLVHDwiQJOGBz9HgM5+n8boduRv36 0lU32g3PehN0UHZdHWhygUd6J09YUi2mJo1l2Fz1fQ8elUGUOXpT/xoxNQjslZjJGItCjza8 +D1DO+0cNFgElcNPa7DFBnglatOCZRiMjo4Wx0i8njEVRU+4ySRU7rCI36KPts+uVmZAMD7V 3qiR1buYklJaPCJsnXURXYsilBIE9mZRmQjTDVqjLWAit++flqUVmDjaD/pj2AQe2Jcmd2gm sYW5P1moz7ACA1GzMjLDmeFtpJOIB7lnDX0F/vvsG3V713/701aOzrXqBcEZ0E4aWeZJzaXw n1zVIrl/F3RKrWDhMKTkjYy7HA8hQ9SJApFXsgP334Vo0ea82H3dOU755P89+Eoj0y44MbQX 7xUy4UTRAFydPl4pJskveHfg4dO6Yf0PGIvVWOY1K04T1C5dpnHAEMvVNBrfTA8qcahRN82V /iIGB+KSC2xR79q1kv1oYn0GOnWkvZmMhqGLhxIqHYitwH4Jn5uRfanKYWBk12LicsjRiTyW Z9cJf2RgAtQgvMPvmaOL8vB3U4ava48qsRdgxhXMagU618EszVdYRNxGLCqsKVYIDySTrVzu ZGs2ibcRhN4TiSZjztWBAe1MaaGk05Ce4h5IdDLbOOxhuQENBF8SDLABCADohJLQ5yffd8Sq 8Lo9ymzgaLcWboyZ46pY4CCCcAFDRh++QNOJ8l4mEJMNdEa/yrW4lDQDhBWV75VdBuapYoal LFrSzDzrqlHGG4Rt4/XOqMo6eSeSLipYBu4Xhg59S9wZOWbHVT/6vZNmiTa3d40+gBg68dQ8 iqWSU5NhBJCJeLYdG6xxeUEtsq/25N1erxmhs/9TD0sIeX36rFgWldMwKmZPe8pgZEv39Sdd B+ykOlRuHag+ySJxwovfdVoWT0o0LrGlHzAYo6/ZSi/Iraa9R/7A1isWOBhw087BMNkRYx36 B77E4KbyBPx9h3wVyD/R6T0Q3ZNPu6SQLnsWojMzABEBAAGJAjwEGAEKACYWIQTBQAugs5ie b7x9W1wrXuIRxYrqVAUCXxIMsAIbDAUJAucGAAAKCRArXuIRxYrqVOu0D/48xSLyVZ5NN2Bb yqo3zxdv/PMGJSzM3JqSv7hnMZPQGy9XJaTc5Iz/hyXaNRwpH5X0UNKqhQhlztChuAKZ7iu+ 2VKzq4JJe9qmydRUwylluc4HmGwlIrDNvE0N66pRvC3h8tOVIsippAQlt5ciH74bJYXr0PYw Aksw1jugRxMbNRzgGECg4O6EBNaHwDzsVPX1tDj0d9t/7ClzJUy20gg8r9Wm/I/0rcNkQOpV RJLDtSbGSusKxor2XYmVtHGauag4YO6Vdq+2RjArB3oNLgSOGlYVpeqlut+YYHjWpaX/cTf8 /BHtIQuSAEu/WnycpM3Z9aaLocYhbp5lQKL6/bcWQ3udd0RfFR/Gv7eR7rn3evfqNTtQdo4/ YNmd7P8TS7ALQV/5bNRe+ROLquoAZvhaaa6SOvArcmFccnPeyluX8+o9K3BCdXPwONhsrxGO wrPI+7XKMlwWI3O076NqNshh6mm8NIC0mDUr7zBUITa67P3Q2VoPoiPkCL9RtsXdQx5BI9iI h/6QlzDxcBdw2TVWyGkVTCdeCBpuRndOMVmfjSWdCXXJCLXO6sYeculJyPkuNvumxgwUiK/H AqqdUfy1HqtzP2FVhG5Ce0TeMJepagR2CHPXNg88Xw3PDjzdo+zNpqPHOZVKpLUkCvRv1p1q m1qwQVWtAwMML/cuPga78rkBDQRfEXGWAQgAt0Cq8SRiLhWyTqkf16Zv/GLkUgN95RO5ntYM fnc2Tr3UlRq2Cqt+TAvB928lN3WHBZx6DkuxRM/Y/iSyMuhzL5FfhsICuyiBs5f3QG70eZx+ Bdj4I7LpnIAzmBdNWxMHpt0m7UnkNVofA0yH6rcpCsPrdPRJNOLFI6ZqXDQk9VF+AB4HVAJY BDU3NAHoyVGdMlcxev0+gEXfBQswEcysAyvzcPVTAqmrDsupnIB2f0SDMROQCLO6F+/cLG4L Stbz+S6YFjESyXblhLckTiPURvDLTywyTOxJ7Mafz6ZCene9uEOqyd/h81nZOvRd1HrXjiTE 1CBw+Dbvbch1ZwGOTQARAQABiQNyBBgBCgAmFiEEwUALoLOYnm+8fVtcK17iEcWK6lQFAl8R cZYCGwIFCQLnoRoBQAkQK17iEcWK6lTAdCAEGQEKAB0WIQQreQhYm33JNgw/d6GpyVqK+u3v qQUCXxFxlgAKCRCpyVqK+u3vqatQCAC3QIk2Y0g/07xNLJwhWcD7JhIqfe7Qc5Vz9kf8ZpWr +6w4xwRfjUSmrXz3s6e/vrQsfdxjVMDFOkyG8c6DWJo0TVm6Ucrf9G06fsjjE/6cbE/gpBkk /hOVz/a7UIELT+HUf0zxhhu+C9hTSl8Nb0bwtm6JuoY5AW0LP2KoQ6LHXF9KNeiJZrSzG6WE h7nf3KRFS8cPKe+trbujXZRb36iIYUfXKiUqv5xamhohy1hw+7Sy8nLmw8rZPa40bDxX0/Gi 98eVyT4/vi+nUy1gF1jXgNBSkbTpbVwNuldBsGJsMEa8lXnYuLzn9frLdtufUjjCymdcV/iT sFKziU9AX7TLZ5AP/i1QMP9OlShRqERH34ufA8zTukNSBPIBfmSGUe6G2KEWjzzNPPgcPSZx Do4jfQ/m/CiiibM6YCa51Io72oq43vMeBwG9/vLdyev47bhSfMLTpxdlDJ7oXU9e8J61iAF7 vBwerBZL94I3QuPLAHptgG8zPGVzNKoAzxjlaxI1MfqAD9XUM80MYBVjunIQlkU/AubdvmMY X7hY1oMkTkC5hZNHLgIsDvWUG0g3sACfqF6gtMHY2lhQ0RxgxAEx+ULrk/svF6XGDe6iveyc z5Mg5SUggw3rMotqgjMHHRtB3nct6XqgPXVDGYR7nAkXitG+nyG5zWhbhRDglVZ0mLlW9hij z3Emwa94FaDhN2+1VqLFNZXhLwrNC5mlA6LUjCwOL+zb9a07HyjekLyVAdA6bZJ5BkSXJ1CO 5YeYolFjr4YU7GXcSVfUR6fpxrb8N+yH+kJhY3LmS9vb2IXxneE/ESkXM6a2YAZWfW8sgwTm 0yCEJ41rW/p3UpTV9wwE2VbGD1XjzVKl8SuAUfjjcGGys3yk5XQ5cccWTCwsVdo2uAcY1MVM HhN6YJjnMqbFoHQq0H+2YenTlTBn2Wsp8TIytE1GL6EbaPWbMh3VLRcihlMj28OUWGSERxat xlygDG5cBiY3snN3xJyBroh5xk/sHRgOdHpmujnFyu77y4RTZ2W8 Message-ID: <2bf3da55-5d25-a5b5-f265-40bdc1cd0cad@pengutronix.de> Date: Mon, 19 Oct 2020 11:05:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="YvEeJBb5c80YH9kUelsDq2Kru93lhiKsT" X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --YvEeJBb5c80YH9kUelsDq2Kru93lhiKsT Content-Type: multipart/mixed; boundary="Qj9VfD2TAGpe4SpV5w1ZQRgVST580eBrJ"; protected-headers="v1" From: Marc Kleine-Budde To: Joakim Zhang , "robh+dt@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , Aisheng Dong Cc: "kernel@pengutronix.de" , dl-linux-imx , Ying Liu , "linux-can@vger.kernel.org" , Pankaj Bansal , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Message-ID: <2bf3da55-5d25-a5b5-f265-40bdc1cd0cad@pengutronix.de> Subject: Re: [PATCH V2 8/8] can: flexcan: add CAN wakeup function for i.MX8QM References: <20201019155737.26577-1-qiangqing.zhang@nxp.com> <20201019155737.26577-9-qiangqing.zhang@nxp.com> <3ca1d3e9-ef13-283f-8301-68c657628e41@pengutronix.de> <0e871906-e179-a2ea-1379-d0194c9d58fe@pengutronix.de> In-Reply-To: --Qj9VfD2TAGpe4SpV5w1ZQRgVST580eBrJ Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: quoted-printable On 10/19/20 11:03 AM, Joakim Zhang wrote: >>> include/dt-bindings/firmware/imx/rsrc.h:111:#define IMX_SC_R_CAN_0 >> 105 >=20 > As I can see in rsrc.h file, it just list each resource sequentially, a= nd there is a note in the comments: > "Note items from list should never be changed or removed (only added to= at > the end of the list)." So don't do it! Do not remove the CAN_0...2 :) Only add IMX_SC_R_CAN(x) > So the driver author doesn't want any scu users to > change these resource macro. If we only do below change for CAN, but ke= ep > other devices unchanged, It would be very strange. And I think this cod= e > change could not be accepted. There may be another consideration, now w= e only > has 3 CAN instances, how can we handle if later SoCs have more CAN inst= ances, > and they still want to reuse this header file. This is also reason I pr= efer > to use these defined macros directly in flexcan driver. >=20 > --- a/include/dt-bindings/firmware/imx/rsrc.h > +++ b/include/dt-bindings/firmware/imx/rsrc.h > @@ -108,9 +108,7 @@ > #define IMX_SC_R_ADC_1 102 > #define IMX_SC_R_FTM_0 103 > #define IMX_SC_R_FTM_1 104 > -#define IMX_SC_R_CAN_0 105 > -#define IMX_SC_R_CAN_1 106 > -#define IMX_SC_R_CAN_2 107 > +#define IMX_SC_R_CAN(x) (105 + (x)) > #define IMX_SC_R_DMA_1_CH0 108 > #define IMX_SC_R_DMA_1_CH1 109 > #define IMX_SC_R_DMA_1_CH2 110 > =20 > Add @Aisheng Dong, could above code changes can be accepted by you? Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --Qj9VfD2TAGpe4SpV5w1ZQRgVST580eBrJ-- --YvEeJBb5c80YH9kUelsDq2Kru93lhiKsT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAl+NVsgACgkQqclaivrt 76m5/wgAsN6Dez6e2KQ33mOhmr0QVBLKLO6X1OOvm7UlpR+/V4knP0y56dZeZwTU mffrkhxkLO44ealpZIDVvUkfrj0p5hwXVJBtEo5Lg/r1/lzM/3ZNfCWGjuYurLpg UC8lycc3gxMKu0LohEwXW6VDSlgfzsi+YoDifk4AdR43o+4OSvrtm0i2BRukYiTS SXDsKhVfHrZUI1p61Pr0Jsxf1mpFCNPQ8BFBmQ9JnLQqhIJ3HvEtIbb3FO+HqCuj lzdPrIXYCzICjPnAkTQiL69NQ/EdQadRhUMcgLkIpFBXpviCoLseHn8OVn+SNJzx aWxAIUpB1fa/muv0hrN8K7foGteofg== =ZQxF -----END PGP SIGNATURE----- --YvEeJBb5c80YH9kUelsDq2Kru93lhiKsT--