Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp3092261pxu; Mon, 19 Oct 2020 03:52:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwCXFkcVXzb7/ZzpPzurohJrwzuEDZ/IVjKDJPN4GumtGhqi3JEmvHpGeNnVzpx0F1b/PNh X-Received: by 2002:a17:906:6dc6:: with SMTP id j6mr17574733ejt.354.1603104764921; Mon, 19 Oct 2020 03:52:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603104764; cv=none; d=google.com; s=arc-20160816; b=1C4TUvGts2lMiMBamlXQEh8hXVYpkT54txM9equAX7YEgoktwJ5CoACbPxySQaJtSW GoZIGGZymwa6qKMwQl4d53no7BeeSpQr9Ci9r31gCeV4jpA6fCUXtXbPWSbLZuw8+p5J r4SxrIsmQCNxRetPz9sTMWmCQKYW1hnLXo6wv3hqFblRZDG+qg/vebK2TDmu1+5sgop0 yZhYZEaS3jj2N8cMutdlaiGdUFUDTBFWeeVTAeiBexY3kFnfAM66wKZuoTybcWA/MixE NCbyTFrmybzX1eRkyPoVccsJTg/ag2gkBN5OGIO2M6q9s7rq9puOoAEGqUx7yzMhwnWe 4Lfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:to:from; bh=h3TWBXbJ38bqnOh6bO8h1AlU8+5Sn63B+cwXPVnf3Is=; b=Vxj5Z/rpmMvN8oBk3PQE2CDwbMQrChY+16QemoaSxW/6Crp4jDaf01EthkfEbc81L+ /Sf45VDkClGfg1D0CgJzkVskMkDMytxrkEsn/6Jqznh6wz73PXbQI4kvkWAFADxIaAJW 3o9HKAMo8c34y/beJ9etUiVp9KF6m+/lEh6QvZVK1IceVvcTLoC22LuOtoWHO4Y8UWJc 70BMa8WJRBGGFC3Xg2ivLux6/p7zwDGOxtafR2Oq0kqL6RvQAzER8i9lHJCWVrUR/AYR Y6mnZkqs/MD3QxW7JSOwO2qpBoFfOxbQ0EgG6m631vYMIoPYuesw6MqOuQTky4+13IMz OL0g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 89si7110008edy.301.2020.10.19.03.52.22; Mon, 19 Oct 2020 03:52:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730340AbgJSJ3g (ORCPT + 99 others); Mon, 19 Oct 2020 05:29:36 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:15234 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726015AbgJSJ3g (ORCPT ); Mon, 19 Oct 2020 05:29:36 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 3097AE86B9F87112BE11; Mon, 19 Oct 2020 17:29:34 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Mon, 19 Oct 2020 17:29:28 +0800 From: Tian Tao To: , , Subject: [PATCH] gpu: ipu-v3: replace spin_lock_irqsave by spin_lock in hard IRQ Date: Mon, 19 Oct 2020 17:30:13 +0800 Message-ID: <1603099813-27934-1-git-send-email-tiantao6@hisilicon.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The code has been in a irq-disabled context since it is hard IRQ. There is no necessity to do it again. Signed-off-by: Tian Tao --- drivers/gpu/ipu-v3/ipu-image-convert.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-image-convert.c b/drivers/gpu/ipu-v3/ipu-image-convert.c index aa1d4b6..c28764c 100644 --- a/drivers/gpu/ipu-v3/ipu-image-convert.c +++ b/drivers/gpu/ipu-v3/ipu-image-convert.c @@ -1737,9 +1737,8 @@ static irqreturn_t eof_irq(int irq, void *data) struct ipu_image_convert_run *run; irqreturn_t ret = IRQ_HANDLED; bool tile_complete = false; - unsigned long flags; - spin_lock_irqsave(&chan->irqlock, flags); + spin_lock(&chan->irqlock); /* get current run and its context */ run = chan->current_run; @@ -1778,7 +1777,7 @@ static irqreturn_t eof_irq(int irq, void *data) if (tile_complete) ret = do_tile_complete(run); out: - spin_unlock_irqrestore(&chan->irqlock, flags); + spin_unlock(&chan->irqlock); return ret; } -- 2.7.4