From: Andi Kleen <ak@suse.de>
To: Chuck Ebbert <76306.1226@compuserve.com>
Subject: Re: [PATCH for review] [140/145] i386: mark cpu_dev structures as __cpuinitdata
Date: Fri, 11 Aug 2006 18:07:47 +0200
User-Agent: KMail/1.9.3
Cc: Magnus Damm <magnus@valinux.co.jp>,
       linux-kernel <linux-kernel@vger.kernel.org>
References: <200608111126_MC3-1-C7CA-65CE@compuserve.com>
In-Reply-To: <200608111126_MC3-1-C7CA-65CE@compuserve.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200608111807.47556.ak@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 643
Lines: 19


> But none of these CPUs supports hotplug and only one (AMD) does SMP.
> So this is just wasting space in the kernel at runtime.
> 
> If anything I would only do this for AMD.
> 
> Same for the other patch that does more of this kind of change.
> 
> (IIRC I tried to do this a while ago and was told not to.)

But wouldn't the reference check during build always warn if that 
wasn't fixed?

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/